From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B804908AE for ; Fri, 24 Jul 2026 00:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784852324; cv=none; b=gpFjQJEABso59QUhQiXQXWzED2T5Vjz3iGNR+KjwcWldoMCeETxwJnK4XBEob0YwWJsZGKTwJ2EM6N5bLtBNxMAsUzGdSH/NkKPdV7bsWdo1ESuoL1CeinUL+B4clOKgLOwy0Irtvb863dVMD7eCvvUSxYFlQ8JXDhIlNdbNMw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784852324; c=relaxed/simple; bh=1OIYqOYVsEaZHdf9NHeZAUMVcLKMZ8pVok4Ix/7itjY=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=TVE/t4MiZTEMcJCHE0dGxkKjAqeJGf7Xrqz+mSkSLIWUz5HFSwR5QFvqUuTxa/5YhTNCvhz05EHLPHvg1ewToRfrClFaTO/2xT7Bp4JVfeKf5a3G2VBc0dWtZX9KpjSZzNFIj49bJv3g2nvft2MbECNr0YByq7A9EbxyJv1k+WM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=YQ2oKFMa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="YQ2oKFMa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA5E51F00A3A; Fri, 24 Jul 2026 00:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1784852323; bh=ksKhF11Mjp3pAX3V9fFcfkJV6jbLV5wiUOUzqBAJ9Ks=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YQ2oKFMaekKQZl4Nk1U9Ex5cIo5T2H+e8fcFo3G+6BodGDTi4/TON4lXXcmkMVPAF r+BIHJl7vM6fCnWMJo4CWKvfQxGvP7jYOI/ZsTINRHg487EJwXpPHkc9EljVM1WQfP Mud3gUonr09DGV6wFoLW8HUdyvuDQHRHoKXPCRS8= Date: Thu, 23 Jul 2026 17:18:42 -0700 From: Andrew Morton To: Ridong Cc: Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH v3 0/4] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim Message-Id: <20260723171842.137e45eb36b21b3b45245da0@linux-foundation.org> In-Reply-To: <20260723045718.2052070-1-ridong.chen@linux.dev> References: <20260723045718.2052070-1-ridong.chen@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 Jul 2026 12:57:14 +0800 Ridong wrote: > Fixes and one cleanup. > > Patch 1 fixes "swappiness=max": the anon-only test in get_scan_count() > sat after the "cannot reclaim anon" check, so when no anon was > reclaimable the request fell back to SCAN_FILE and evicted page cache > instead. > > Patch 2 fixes reclaim_store() collapsing every error into -EAGAIN, so > callers can no longer tell an invalid argument from a busy interface; > propagate the real error code, matching the memcg path. > > Patch 3 drops the now-unused gfp_mask parameter from __node_reclaim(). > > Patch 4 fixes the same "swappiness=max" issue for MGLRU. Thanks. AI review might have found several pre-existing issues which might interest the maintainers. Also a suggestion against your [4/4]: https://sashiko.dev/#/patchset/20260723045718.2052070-1-ridong.chen@linux.dev