From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12824483820 for ; Thu, 23 Jul 2026 18:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832412; cv=none; b=qZp//qkl6GD+gPXBc6o+D0DEmnq2bTAKjuSEdh5BHI42mX/gmqg7kKHbUr7qMi/bm950O1l7yCEEIei5EurlFwOfyFjAVyAjEUiWB8wejTi/g8bWeQdg7liB2EhRWfJzyP8BlfkDGx84rC20P7eatK1MF0ETzZrnZjix716MbpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832412; c=relaxed/simple; bh=OjuU5sZNyEfe3NY/W693mYnbMjjdy0/PtxQZI/XdJ4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HhGsB2BRY/RR2h5r6nCo8vkTf1SB++E5SYbTcbF437dv+L/AYu9ZqmFTRI8j2QDV614l0KyeMnPu782APQvvgBkCuQQcx2nUjDizBp/MOyGFhoV2y+oXxG0tl4pyhRGwMxpATeMLInOH9LKMLD0Jf8kMCzLyS3hp19vel8oc+ls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bfn2gqhm; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bfn2gqhm" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1080063a91.2 for ; Thu, 23 Jul 2026 11:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832402; x=1785437202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/ZyPlyAUxTK8Vz/tunABGXVD0bibLKDl8Em93+X7p/Y=; b=bfn2gqhm/GGnWxwuwqByRgdWQ0oGWL0dfEhGLe402t2Jkrd9xl72xo+UF8IscgxRYt 6oWbdXnUXmPJ2/wFW/wY9A4BBfMoBjLM41qpesvBg/6mWmSYRjmNVfopYWGk24biU+Mw Udu+DYkgMSye513XyNhElHr80sydkVL2DSGlQoU4/L74CKZE66Sej7Sx02+sqIwqnWLM EPCe8YuDgW3A/JKWk57YFHWsRnl01mVcHYlrZUnOTLZScDacRf2WTqH81fgeQj5b2L/V uadHYEu0zmDXmMatqWWSKjwjTWsjpQsMk7LSFTQm273w6bY2C3qfrE4c54kb/5CjRwSm kyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832402; x=1785437202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/ZyPlyAUxTK8Vz/tunABGXVD0bibLKDl8Em93+X7p/Y=; b=m7yjLAlfBhD8ybYs4Tv7DMQMSfjpTJfwYqs0juNeG5AMOCcbYTtODM4JwvSugmX4gd qOFAvptVgdTMkflF9v+hGWmsngxTXG674Y33DOOV3AWAA9Cm00xyjdcXnJvZlQd9jZ0X edguWXoT88vmubnqQQH5/YNQ1lx/hEIrNYsWLgnXS3bk4BnAGI2g8w5wxGUhKWbl9+wP SnqvqFFytIJZlKqjv9ZpMbdSo8k8pI2Qo3knCYemnYFUmH0omeTIlE1zha6C2xG2OiKB x1PAVBbyZntRk+rO5sdTumw5s8PW8KWiVtQeyjQUdLj6hnEsWHBvMUzfx8ZssRvwIwmI bGpw== X-Forwarded-Encrypted: i=1; AHgh+Rqq9erRHUro5oRmSsDb32sYqtSczupuvHT4Reqz8DrVtzD6AotRMeaGAcBCtmPd6DkXPzD0Y9KjsctJCBY=@vger.kernel.org X-Gm-Message-State: AOJu0YzO4ajpieknQWbJoUqP9xKVBZGHQkKCbYcElFbxCPzB7WLIYtfv 8dse+/H/kRRK5Bmx+wEVz8cNvC2Z0cYbVH7uUG5Eonlh5S8RZQpgMteDeckUac+GZIc= X-Gm-Gg: AR+sD10dh7QJvfvhmtc8pKzbpNAW946cEvMc+gGkmh5DRgrSGMOrOOnJJMqk3VDRmfX JlJ0sYJiKKq3x9huift/NFdRG1taS/PVXOaFHvssudN5qeIIMJEhcvTgsYSG2x3XzhD7CPfqbC/ fYGxM2nOs1ytIuciD1NHUzYqBc99yPjNhFmHUKlDNuC5edojH5501FteyVl/nRHJzP/gMsIa1v1 DBQgaVe6lqBKUVVvl4VXtxozFYTfrOFt8OriOvD71g0Wz3pe5+tBzU9WtY8Jk9xKR8R7B9eMHfW YJoZBrfosRBO7JpYyl+xQaEvrgCDIohsvjelDwA37iBIMwg6VhphGR2ZSAAF5I8ICMDpQlcCnIV 7QcO0giC0LzojT1mOUpjAmaBeLNsICmF8JzRsKaMAp1NYaxrZ2zcf/6QO3xPS9vcpLTDT7pd2 X-Received: by 2002:a17:90b:1847:b0:381:a766:efcc with SMTP id 98e67ed59e1d1-38ec642bd8dmr4696955a91.14.1784832401698; Thu, 23 Jul 2026 11:46:41 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:41 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Dmitry Torokhov Cc: cocci@inria.fr, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/36] Input: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:18 +0900 Message-ID: <20260723184538.3888637-17-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/input/keyboard/pmic8xxx-keypad.c | 8 +------- drivers/input/mouse/synaptics_i2c.c | 6 +----- drivers/input/rmi4/rmi_smbus.c | 7 +------ 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c index 35d1aa2a22a5..c916e80e2f58 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -462,15 +462,9 @@ static int pmic8xxx_kp_enable(struct pmic8xxx_kp *kp) static int pmic8xxx_kp_disable(struct pmic8xxx_kp *kp) { - int rc; - kp->ctrl_reg &= ~KEYP_CTRL_KEYP_EN; - rc = regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); - if (rc < 0) - return rc; - - return rc; + return regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); } static int pmic8xxx_kp_open(struct input_dev *dev) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c index d4cf982f1263..85e37e2ce45b 100644 --- a/drivers/input/mouse/synaptics_i2c.c +++ b/drivers/input/mouse/synaptics_i2c.c @@ -257,11 +257,7 @@ static s32 synaptics_i2c_reg_set(struct i2c_client *client, u16 reg, u8 val) if (error) return error; - error = i2c_smbus_write_byte_data(client, reg & 0xff, val); - if (error) - return error; - - return error; + return i2c_smbus_write_byte_data(client, reg & 0xff, val); } static s32 synaptics_i2c_word_get(struct i2c_client *client, u16 reg) diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c index 6de68c602558..3160714a514a 100644 --- a/drivers/input/rmi4/rmi_smbus.c +++ b/drivers/input/rmi4/rmi_smbus.c @@ -177,13 +177,8 @@ static int smb_block_read(struct rmi_transport_dev *xport, struct rmi_smb_xport *rmi_smb = container_of(xport, struct rmi_smb_xport, xport); struct i2c_client *client = rmi_smb->client; - int retval; - retval = i2c_smbus_read_block_data(client, commandcode, buf); - if (retval < 0) - return retval; - - return retval; + return i2c_smbus_read_block_data(client, commandcode, buf); } static int rmi_smb_read_block(struct rmi_transport_dev *xport, u16 rmiaddr, -- 2.43.0