From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF67644C517 for ; Thu, 23 Jul 2026 18:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832415; cv=none; b=WM0V7/HChsnJVo6iZSKZznVjtq3QgO47GnHTa/NfwDg7RvMdNHFiH5JLjgq/wGuQ8ZiblYTZR09RxYXwZUPZdr/KZdJWBDXvD9Iur2EHOI+qjS3r5gHQueBbEGn6Xv8h0sjlxNjUkL7bvU93LOO7C4wS/egNC6t9bWHxrN9QDYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832415; c=relaxed/simple; bh=Cw+Iw1oGtwEx51kVwGrw3fev8VnbppEtNmYYejqZ4k8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brBS1ZXRxkwojdNAgvJ9h/96laMDBq7pHBM3XIm4lGQyM/Dn9NX0DIam5xHJOfCWVBn6MhMiBR/ECxCnzrbwpVI0jKMVCjD0GpuPYtayhMMPBpXSSaM2WpKrcYSS0yRXGMcaBFeFWOBrLDNiVmHVJd9Vw936PAbF12UkXaSkH78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rrayn80G; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rrayn80G" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so905944a91.2 for ; Thu, 23 Jul 2026 11:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832404; x=1785437204; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+53O0vXfEk/QFHYiZ5anDwDOO58yxuSoKuAHDn4vUGA=; b=Rrayn80GyoPbn47Awu8p0FeVSUqRihf4syZGb0mp7OMFHoSLIufvs/gTViqDgiy2+r m50WNTDbGGRdLwOiPPtChc/hcD/JWsMoOek13o40xvXQ0ocDCpBdr4SYU6dwcfwHorb1 ErswQHiUI7H+aJW2IkMWIefLGH7H2SNbZdKNiRnQnJBTUSQh/6MD5STi6hG+d5YPUPsX 3pEnW6fZ2g262BLmUNGxRDHBbFQrGBtcVgzQTw0dZfLbDGUye5ucWvWI66+P+y934mN2 Cs/X6eDVdiGbvpwqc5fT7nJR20kGy5hz6+rTDlVXBA+rZSF7nEI2OmCGt7Ezpg7PLE9z 5cIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832404; x=1785437204; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+53O0vXfEk/QFHYiZ5anDwDOO58yxuSoKuAHDn4vUGA=; b=K9kiQt0KekWdWlOabEzRfofSppaDwppZisDco7YfsAeLm+LuRusW1E+ktecXAAwoX5 KjWREY1wko/9cZUB+zM5lFd3pO8IIjf6iL9gMEU1jJ0kAgfO5N33dQdYeShzdk+ik4C4 rDwfXthrIBUIEOKJPAFHuLvC10bglyYU8s1exb1YQeA00VMY73JzIryOMj49+Oz7p0n6 c+7gh8bi7z55fp/ei1CwB5oNUfHvfq1Y9AvbmKcSmjxg1fQ3fo69nQVGw/HdU+2Cfe3q gJ59hOLRTB6r/Y++IXfYDX/GcJvT11i75VszYUKzLolET45yz4eAWk8AvXAplmuo3PNU mv4w== X-Forwarded-Encrypted: i=1; AHgh+RoO+KRPm/rUBHk98SJpCdiajICIdqNg3Kmsw3i1U0OWMFZrBDnclNiNWsks63vuEh9GJDCGHEGjOxZC6d4=@vger.kernel.org X-Gm-Message-State: AOJu0YzrKasb85sW4sSNJo1fIN0cNB0bWvFIPPQExTGrBgNHQCWI0Fms zE7fpviTMRKW+wDIRKMHnTQIthfrv/+j1F1sJaOgerxFbga4u9+L2ZrC X-Gm-Gg: AR+sD10Q0aQ9bwFCYIZifyiRFixmKU9gH8hwlviTWNfbJFeOg1G4IktddOQ8tVOgt4c oFRlx0gga4w2gBlo33y9VNKG24STdZWDZbXD8Se25N6H7+E2IvQymQOPx9rS90qrus7XHUnDD33 Ywp9WpUhMWl5+QY0xY45LjxkkVw2GNp6R9wgYVGCKISRON/Ejdo2d4Sbk/1PZO8d71qw3OFhsLF uRaQWQLzcmIOG/wGUfSx7Xjl5oOoSltLqs9caZFLhKYSpQeQwPm31bA7PrtIkearp15+67mk1/z qp6K3cu8LZXRHP+meSUdKozz6G0FeCgv/uuLWbxFpm++GPo8lknCRluOFDz+jcHDVrFzE9uXvTy fzm5/FVMtMoxbpXFQYX3SY8uWr4EJBlnMbeg8uBhQZzCYXMQItfPJOCZQGpzcPcQ0Yk9YEWbR X-Received: by 2002:a17:90b:2d10:b0:37f:9cdf:f03e with SMTP id 98e67ed59e1d1-38ec6632b70mr4099341a91.33.1784832403772; Thu, 23 Jul 2026 11:46:43 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:43 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Michael Turquette , Stephen Boyd Cc: cocci@inria.fr, Brian Masney , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/36] clk: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:19 +0900 Message-ID: <20260723184538.3888637-18-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. In the lmk04832 driver, the hardware sequence comments are moved above the final return by hand. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/clk/clk-cs2000-cp.c | 6 +----- drivers/clk/clk-lmk04832.c | 12 ++++-------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c index 8800472ba63f..4de581771d7d 100644 --- a/drivers/clk/clk-cs2000-cp.c +++ b/drivers/clk/clk-cs2000-cp.c @@ -404,11 +404,7 @@ static int cs2000_enable(struct clk_hw *hw) if (ret < 0) return ret; - ret = cs2000_wait_pll_lock(priv); - if (ret < 0) - return ret; - - return ret; + return cs2000_wait_pll_lock(priv); } static void cs2000_disable(struct clk_hw *hw) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index 9bf86caad829..f006401c1586 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -822,13 +822,6 @@ static int lmk04832_sclk_sync_sequence(struct lmk04832 *lmk) if (ret) return ret; - ret = regmap_update_bits(lmk->regmap, LMK04832_REG_SYNC, - LMK04832_BIT_SYNC_MODE, - FIELD_PREP(LMK04832_BIT_SYNC_MODE, - lmk->sync_mode)); - if (ret) - return ret; - /* * 9. (optional) if SCLKx_y_DIS_MODE was used to mute SYSREF outputs * during the SYNC event, restore SCLKx_y_DIS_MODE=0 for active state, @@ -843,7 +836,10 @@ static int lmk04832_sclk_sync_sequence(struct lmk04832 *lmk) * SYNC pulse to delay the output by some number of VCO counts). */ - return ret; + return regmap_update_bits(lmk->regmap, LMK04832_REG_SYNC, + LMK04832_BIT_SYNC_MODE, + FIELD_PREP(LMK04832_BIT_SYNC_MODE, + lmk->sync_mode)); } static int lmk04832_sclk_is_enabled(struct clk_hw *hw) -- 2.43.0