From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA734CA292 for ; Thu, 23 Jul 2026 18:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832418; cv=none; b=jFqrV8ZwWuUP3LGh1tFiyJpGYabGR54zeKYhgEL+Z8YDUs9fpDIF6BvgwbUhPsPRr8RLyCg9W6cnmxcGoW4VvG3FFpvO9sgeOMCqExgsQxHVezH4ll71F2YXI8ipuUGyJLXo2WLaxMxqRyUIZTTYNg6hR1ymvN7GuF3+Y37DBLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832418; c=relaxed/simple; bh=2XerIORtjYT6lU/QCxj94nR/+mthwLJM8r1lYonXQgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2HHyNI6yuz0xEFreqEI3pPLI2EPg6lplnMdgyU5J6atFCRej4uM20pjnVeuYhYGDjHS6VEeGV/nvjYJbu3iPo1K4nG5h0LF1ZoB4BtA2TAfooSOV4ytsB0aHVpmoKSob08+Iw9qjIXGgrN1LsqCi+jQQKHphXxd5FivqKse5yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQvez56A; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQvez56A" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38759bcd877so917832a91.2 for ; Thu, 23 Jul 2026 11:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832406; x=1785437206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MvMxjqNvpASivPiDAcPmI8PwBsKAarLbQdQ8wRHMWv0=; b=CQvez56A9PDOxPPkjW5dr+x5rcO2ncfLNjk2XekL77va8AYlax4uwKC+xoCZJFyldM 9vXsoTXkWPSFVSM4MdfBePJi6fZvBAL5HmB5g1wE+uOXC9uE84R+lgGI5ZetHTHgdw/X r0iFOg1smVEQIxmlVQEjPpJabbo0FLkky0ntrUSTvgZzAN9dl/1EiOig0CvQ4nbcEwJs aun1+YDL2wPVMTrkRGSiprOEqbJMNZaq+vpIaGhrMMmUjKtqBLBd2uiRZO8OZxg5CnQ8 6MRIol28m6RCnLrt0OwdUdIq1I4EEuqXcAVd3aYayTm5u8GSqCk+SkqQD2mUiU86TWTj gSKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832406; x=1785437206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MvMxjqNvpASivPiDAcPmI8PwBsKAarLbQdQ8wRHMWv0=; b=dif9paEyvU2f3t+h4PEdzpTgHENg4rRCvYV9F3NpxRkeDQPMw7stUApe2DjbEaYkLQ 3HGjjAZNCxWwki5aYXIKrSx6RQJcB4c+yS//QmJVMHtOPEDmgjtpqDROb1WG9hisPf6U lvokUmFku2HzN0/EvzXu2FVJu3z2vX/OBWnlyDSaOhhwagR1SWhB4qfT8NPE400/TZnW U7WZX/K2lp/hSW6fy5bIiwe8bt/HFyVOOX4S+pR8wdPiSYd7ai4qi6UsswaZqPkw7yAY r3JXs5QCt28hkaKUHhGcuLptzClp9HzJ/4WELe3I2Z7jk7sOtljWaAs5mAvYz929bFKu Q7IA== X-Forwarded-Encrypted: i=1; AHgh+RpA7YENkGEN9Svw15EWTRwxgQGfSw1s9vtZBEJxvw8ZqN6osAJl0MW3HNf2FhDdz9TQkOqYOJnoXD/Ttgo=@vger.kernel.org X-Gm-Message-State: AOJu0YxaQX/CiEbvz5afVFj9H/cqt7Sb5CJ+ClyH6nWN2i15GP/J2+mX mVupzx4LRCinbO2SmWxRWuGvfC2rrxIYhyWt2+rxCn3W1d6WZkpdgh0o X-Gm-Gg: AR+sD13cvw2xqM1F9F+hJOXAd4qFVUKArwMN4KryjM76ZD+HxFJbJxLVk8t0BK8mmup clxX9t7aeHA+MxhR+8Mgh45OP53vUcWgUNr9niWhS3LKZ6TNupWwQA982VCl3Ymz4qj2PKCABZz NiUc59XTkq21IP8VxjCffAjz7Qd0TKoB4S2Hor5Pq9O3JxeZQDcvARxGIlhb4X7vgYPDU+6pYIj jO3++n8fM46/KOKAuA8dW979Mtrp5zAcVX4QH79KH6JkKcJGJiTSoeQryu4eV8MYQz/P+4Rzpwy hO2q/TX+wC+rnfEagYRZkRbZ8pD6N3RJ5zFmdRJ7Rwk7WTZhmFZCWizS9dVA5kIt4A80zkKchh0 8KnklE7YF3kChlJECG5PPvCLXzBBx6/tsTLUs/oIY0JjPmI6xC8oonTBhEEvydFAgHH0bpqvA X-Received: by 2002:a17:90b:3904:b0:38e:584f:2515 with SMTP id 98e67ed59e1d1-38ec6aae88emr4263344a91.37.1784832406282; Thu, 23 Jul 2026 11:46:46 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:45 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Srujana Challa , Bharat Bhushan Cc: cocci@inria.fr, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, qat-linux@intel.com Subject: [PATCH 18/36] crypto: drivers - remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:20 +0900 Message-ID: <20260723184538.3888637-19-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/crypto/intel/qat/qat_common/adf_gen2_config.c | 8 ++------ drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c | 7 +------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c b/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c index c27ff6d18e11..57025bffee73 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c +++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c @@ -155,12 +155,8 @@ static int adf_gen2_comp_dev_config(struct adf_accel_dev *accel_dev) } val = i; - ret = adf_cfg_add_key_value_param(accel_dev, ADF_KERNEL_SEC, ADF_NUM_DC, - &val, ADF_DEC); - if (ret) - return ret; - - return ret; + return adf_cfg_add_key_value_param(accel_dev, ADF_KERNEL_SEC, + ADF_NUM_DC, &val, ADF_DEC); err: dev_err(&GET_DEV(accel_dev), "Failed to add configuration for compression\n"); diff --git a/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c b/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c index 95f3de3a34eb..1542a110ba37 100644 --- a/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c +++ b/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c @@ -235,7 +235,6 @@ int otx2_cpt_lf_reset_msg(struct otx2_cptlfs_info *lfs, int slot) struct otx2_mbox *mbox = lfs->mbox; struct pci_dev *pdev = lfs->pdev; struct cpt_lf_rst_req *req; - int ret; req = (struct cpt_lf_rst_req *)otx2_mbox_alloc_msg_rsp(mbox, 0, sizeof(*req), sizeof(struct msg_rsp)); @@ -248,11 +247,7 @@ int otx2_cpt_lf_reset_msg(struct otx2_cptlfs_info *lfs, int slot) req->hdr.sig = OTX2_MBOX_REQ_SIG; req->hdr.pcifunc = 0; req->slot = slot; - ret = otx2_cpt_send_mbox_msg(mbox, pdev); - if (ret) - return ret; - - return ret; + return otx2_cpt_send_mbox_msg(mbox, pdev); } EXPORT_SYMBOL_NS_GPL(otx2_cpt_lf_reset_msg, "CRYPTO_DEV_OCTEONTX2_CPT"); -- 2.43.0