From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C3314D8DAB for ; Thu, 23 Jul 2026 18:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; cv=none; b=MzgTuWTkhh/JWldV6wGgp5KZDbjdL3Mxx8MtF0IrzfgBfVW3GglT3qIJBAS3Ra/ddUy20vtFivRTWjspFUqk4+Je5tZOp3rJtCkdVTpzrBsOwCUgPtjBXp6Qzp+cuEFpsEE0dC9ywVEK7Gph0wThyIaoNIOqEUKj1Ps8WkquiNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; c=relaxed/simple; bh=JlumXXFYa4YT2z0t/Rv8VpE7rH6ygFShwNbbT7uFZdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ej7UP3wjrB3uF6lT7Ow6NQ3uUltfojmbjOUkqzzimEF+bJVPjeK5N/B7RqFLXAPcwAQimymwFY7IUkuTKyjAlANR1ulN2uczCSclEJUOqr335/PkWhc/+xLiDF+2nnl2lF/qnvMZbcMF4V15Rxgv/VsaXRqXIJmD5CTnOvaQlI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHyUgATG; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHyUgATG" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1066338a91.1 for ; Thu, 23 Jul 2026 11:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832409; x=1785437209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=inEAHAT4FZx62nofTUdSreIh00cPh6gTjTfAeZvFyf4=; b=fHyUgATGzbfJZ2vlpUBJVp3yHBjyEQS5sswCIU+IiRFhFsId1U5H605OqFcKZ5vrdu n4Cm1lK5dxN/St6pRWMW9qoaFjT0vkRxROtV2ajqGZGDaVBjTRokb5lSb9El9sbOfMaf ckjXvJV0YrCmTO/Kg2SAk6vEsWEJEoQBAjRCQ9EDZmanz1WtOypXp6Ln894rMLA9zX9c lRg8M+rtEEyvB7FfT0+qxhdVCsWOhjV+GU+DtQqK2c1AqK60aiSansBLnNSceQUDhFsq nVf3cTWkjwvXExj1CDdEuPlibtyPDDypRehic92vK9OkV7n1Qz26JA+DSv/QERXOhquX Sy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832409; x=1785437209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=inEAHAT4FZx62nofTUdSreIh00cPh6gTjTfAeZvFyf4=; b=pHC7W1ZqGNZwM82Wr5iiYVXp5XLpJVcq9tLy6tnR1PprzW38Br2eik0bcu/Ze5ffbY nQxezH4mND4knvMIJBGZDTJp/sJsEihVb+30sqtHyDhhYdVANYkEkUXAxh1HH2qeGney 34Mjwu5E1V/ClFINSFipceg49m8vbzI1j8uRnTkRjaj1n0wgh4oIGshnli4/WBOya7nU RT1S64X6yTnRE1qe2Hh3Kp7iJm6Da+LxwCMb4/PLXyaG0CtXfrBHrYQDK8hFd4QSZRF+ 3F6CpeQ2P0hBXCzHtKB7EHKi12zALGH6EB2ZOzN9QEsL3PiuwED60TPRd+OXbWqxUUQV EkYg== X-Forwarded-Encrypted: i=1; AHgh+RrOl5Y1lOX7z0J5WT5nptN8jkghFFdP62LEs7ztiKkyzMKObJAjGSicnEFBwzDRYfZmjjhuSBJW3yYA51Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwRIl8mg+fflpM678VN1dODNCeez4x14QANZ9H7yI4bf6adSBjV 8O+zSWrvH1rZwQ3Wb6h2lFw/7EfCPwzDXA3j9vAENoKir7jkV5rTeHIW X-Gm-Gg: AR+sD10mFL4ZFbqBy5gxHUIgZSLK735Hj8xkieoAR1pXjWOr0Dz3nEiohxnSAqfAQ0L 3yd0ttwSiIrnr6ZOmQ8pGlL8DC/P72+j1kINA3ERbSCkbJ2TxkGszNsekUd7s9N63Y1lBALKpA3 FwwRivaUw5yFINvYB/AlxOAkoxUFiyFqTDy4TWTCbw6QEFc8KQMBchvuQXrXJwKpwwKf1no82Rr T4/WHqM8DnGRVUIBd6zXe5eWBvyU3lM9cg6n1/zlUTl+XwEirU6uRZvLVQa+NJhqF3jwEK1hYF9 ij6/UzhPT8+bj9cVz+XoKqfVn25Ek/v1/TDahGTNhqfN2kAUVXC2IwBJSX/cOKTdkRYOdwJDDv9 TJncCXWu0ksYL8IqPsVO7rI6tXdh9h9Q2uf74Z17zAqEAl+pYxddK3U20VzPfbOZRHSubIGDs X-Received: by 2002:a17:90b:5603:b0:38e:7eb:d07b with SMTP id 98e67ed59e1d1-38ec6622023mr4815354a91.34.1784832408660; Thu, 23 Jul 2026 11:46:48 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:48 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sinan Kaya , Vinod Koul Cc: cocci@inria.fr, dmaengine@vger.kernel.org, Frank Li , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/36] dmaengine: qcom_hidma: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:21 +0900 Message-ID: <20260723184538.3888637-20-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/dma/qcom/hidma_ll.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c index 53244e0e34a3..f081aa787f0c 100644 --- a/drivers/dma/qcom/hidma_ll.c +++ b/drivers/dma/qcom/hidma_ll.c @@ -677,11 +677,7 @@ int hidma_ll_setup(struct hidma_lldev *lldev) /* configure interrupts */ hidma_ll_setup_irq(lldev, lldev->msi_support); - rc = hidma_ll_enable(lldev); - if (rc) - return rc; - - return rc; + return hidma_ll_enable(lldev); } void hidma_ll_setup_irq(struct hidma_lldev *lldev, bool msi) -- 2.43.0