From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CED4D2ED5 for ; Thu, 23 Jul 2026 18:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832424; cv=none; b=KVsRTfm66KMAPLqG5ct6kxFD4MuHBoOgBT7qCsxqS1GTyIcZuDx4syAXSAe18cbjF45W5oDzRrN+YjF9E83uPiH988Pz2KJuey/o/nhgSO8QkLV5FsEYe9xjrlMfvGrkogzenjjNMqBV5I3V837jVVzm1m851al0wQnB5WG7nuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832424; c=relaxed/simple; bh=d0EWrVZ42EPe2bhaOHHufbmj44DuHjUEdUtjBw/ex20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aT03vTxeEvYg16MHBCF2zHTyU1miWItOkDwK1ubDYxwVUE3FxAPSZ++2PTXgq4RfEc1pu4d7sOV6oio+DimAikzua4ypcQENChXs+Pu/bWt+bLtUEIc3pElsGn8nzcHIyygOtreOKy113jny/PSfxm5mRC2AeDWC0yeE5r7x+LM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LeV/R+zV; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LeV/R+zV" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so820199a91.0 for ; Thu, 23 Jul 2026 11:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832416; x=1785437216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pa9RhyBV4RDq7tkQpwKRVUOOI8N+P6srYqSVADpe3nI=; b=LeV/R+zV/Qq6oWzzZqslYq4xBY9AOSEsjRVc5DucFqVnQ1m6J/xob2OdY69MCjOQcX grCrFfHzQYBTQdZWkW5t2j3QgFd+axn0rvTv2sYfQQpsiIgz2bRWUxrdwCdomPOg7WsV LLv4ZKm/dYHRkMjGaof1OywC2zvuoMQjgAX2xATzA3Vi/sbytm/ekeU2eVqFPjDxwU6E x28QvIPt25U1D1LcelvFqFrXkhIMvm/ztniRkMU5QSOLOro+sqpbl0jBit5YWALRgkoX UpsCJp7NLQWNHbQKTZSCO2LXEdO6aTT+Oenm3b/Pdiv9jby0+hm6SMiREbjXeEwdjh3v DtKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832416; x=1785437216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Pa9RhyBV4RDq7tkQpwKRVUOOI8N+P6srYqSVADpe3nI=; b=as4J9c0nFxoh6orPsOasVa8Y6HHNhiwEr3j8rXDD3h+q6jx+AfX/LOD+EdQFc9pZce grG2ejEBGv4WY68FyE5WOay+CmH2/5iU6QQ7AAh2Yg2pfrueJq1i5+Ya5ta9UTnchLmc EqHjtMY0MojCoT/J2aC2dOXukKEtpQKUglDPOylgdkbXRQVQ0wYU7DNbNWkGcJk1cTcf AOMW3X/Gr0o0AdS3X1olZkmr3bb2nM0wzUnVhqxQ/XOE+Zd2nQdd8QPKaPpV5ImX6+Xg AT5UkRPi0tjZ6beQsyUNzIF+JbMAhwtyU7WCql+1rf9hFxRFNnLUv2pW2DisxaWj6INF 2tjA== X-Forwarded-Encrypted: i=1; AHgh+RoPJbo63lP95fXbYn8OLNhXPOVxVAK1RwrKzKGuik8nOx3aD+Dt0MMBeZoW6sDYjbGs1ylAVcfl0dTZxlg=@vger.kernel.org X-Gm-Message-State: AOJu0YyL70awK0/JXGOm/V/rvreSzOrrq2rer+gm6PC5VZU6GHFkkfnj 4b9K1QvzGyvj0jc21nfKSp2FY+3LKa6VSCrB9//BSXWk6LSXnKONjk73 X-Gm-Gg: AR+sD10RGmeFM682eeckxfZIKxqA8Wv3RPrcejdf8n9szeW0L2/+CJkXbWh0AEEE9DA jxCP4naknAWiDlAu0OGZS5v8SnAx9BqE5BorrvoZpAd6JtaWwA/Pj3uOFCg4M1fNftI1FEw8RPz 0r4FSAAGldL74LpJPic06+6+8udTpjZVnDxlhBIoQW3RUIf4jaf645f4SxWEUspiuiuI8FB5ZXP FnGd7OEpfjQa9J/njJ0OY6bC/2pQ4ggxd6Nhdn6vFyjK7Q3cIjmPDvf0IKgnNen8gUgsk3QWAa4 jf5ORadkQaaqg+E2atjCQPi2amcpK/SP1BZT9zqhE0JODinXC21xOSyKQXkx2DBf6cFRz6pxNrn Vhy4OA3KwpclvrVnItlclJRvwdBsT84wvau35/kiUbTDZ3nY5RF7r2vghcD7W1+iNfSiQ/xOC X-Received: by 2002:a17:90b:2b47:b0:383:f52b:d616 with SMTP id 98e67ed59e1d1-38ec6454e6dmr4309241a91.10.1784832415649; Thu, 23 Jul 2026 11:46:55 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:55 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Niklas Schnelle , Matthew Rosato , "Joerg Roedel (AMD)" , Will Deacon Cc: cocci@inria.fr, Gerald Schaefer , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Robin Murphy Subject: [PATCH 22/36] iommu/s390: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:24 +0900 Message-ID: <20260723184538.3888637-23-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/iommu/s390-iommu.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c index f148f559ac56..d008b1d14a9e 100644 --- a/drivers/iommu/s390-iommu.c +++ b/drivers/iommu/s390-iommu.c @@ -1115,8 +1115,6 @@ __setup("s390_iommu_aperture=", s390_iommu_aperture_setup); static int __init s390_iommu_init(void) { - int rc; - iommu_dma_forcedac = true; s390_iommu_aperture = (u64)virt_to_phys(high_memory); if (!s390_iommu_aperture_factor) @@ -1124,11 +1122,7 @@ static int __init s390_iommu_init(void) else s390_iommu_aperture *= s390_iommu_aperture_factor; - rc = dma_alloc_cpu_table_caches(); - if (rc) - return rc; - - return rc; + return dma_alloc_cpu_table_caches(); } subsys_initcall(s390_iommu_init); -- 2.43.0