From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BDC4D2ED0 for ; Thu, 23 Jul 2026 18:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832427; cv=none; b=Is1LLGMKO1Jrd+pNmwfN1YrCJD/r2lWKdGJf/QoUQm9iv1vUNl1pE3hgr0JDeqlubqCHiYiqkYaq9xGrT+SJZghQSYVtoQnKjSc7Eg7SWB/FLQOW+0flcIOyFR21zngSqiMPe0nX+3RohDG5mzIuGXdAC62H94zzitSYQ5jsfy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832427; c=relaxed/simple; bh=WVruzY/Eibfw1kvwy8CJSFL+wCY9qOBSRkZxC3F+RJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t43k5uGomRKEn2L4dq7xugCsjREDd/DAp57NwicvqnUfsexHobRQEtWdu17wolmuZTsJf2GbIM8Xta6m0zav52getPcrJ7PRYuc0AkYuLSt9SQ3A2NPMrgBX49poKIp5oUMQGs87rLb9afVUbOKgmFnL50zamuH71cpJBSW8o1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jyQuyCOg; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jyQuyCOg" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e7109321dso720673a91.3 for ; Thu, 23 Jul 2026 11:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832417; x=1785437217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AjI3AsRUClNng1k/UijCjBlEPjB/wot6PGQU56kuWcU=; b=jyQuyCOgszB8+EJljZM+9i5HTDeZiJaAiQeCfZ9FhmbmrbDxL12OIcv3ndGG8YShyP r0ZtNixp1mnoCzmJTQD3nlonpcXL6bOkWg7rDXRCF65MoceRhHnGWtasWVy1dwtVvhDI gWrW+xswEaHudZ+DPDlBfTxvrAnu5AJHs/epnVetSUpFm0fOaUs/CUaKGLpxv4Lxowgg 9bexmsE2++DsOCje8EdjWu5iIdgVKtfdhv6jkRYywKwPxz8fST7QYaOBNQzkVYW4e3YY NCSXdBUGBvUiHw3bx3vm2sHcBENsjiaDV7Zuxw6OQHyGwMDI/ZxSuUNAbpJoXhfLM387 x6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832417; x=1785437217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AjI3AsRUClNng1k/UijCjBlEPjB/wot6PGQU56kuWcU=; b=Zw/eVfUMlTVoaVZzEl97F8k0cUm/1GyVyAxGmfIkZV/5GgNUldMyO1/5kK9WZD47/Z h/Ij1Ew1Tp0zvkH+qhvsNCSyahiRXc2JjmERLx7BH3v4w6LzOnZ1gb6SzGFznx+NCH7W JFQZHoSghW7fYbP+2HtamFOPzg8sXRw1o6/WRpfN+40Zjr91o/n/HarVyFN9tFneO3Do Jl22oP/JHvPnKNy8Dddx6zx6Le1+gIVg4CJM9g1V/4yu/bbks3aZryZMe5JNaE47rOH1 QBib9ghTmhzgQNA5prJToITXHUwVBsR3zog151Blz6W/N87Q29T1jWua5UTVK52zAqXO G3Fw== X-Forwarded-Encrypted: i=1; AHgh+RqzVOLVO0wSruWwSm5ox6y8aRxqZmn8b9OiYuaAvcGEpk1aXD06Wi3irnaSkPjNc5EuFOXXEH5y1KKaxsE=@vger.kernel.org X-Gm-Message-State: AOJu0YzOa45gsTNG8l6KAY0VYFdD8BdeNxYNJ6tKt0EJ9k/9Or8zQL7a xGKTfpjJoWVJ5IjefusQPxCIVcaTEuWc3OmXu3plaNGb28GaPQCdRSuH X-Gm-Gg: AR+sD11FYBpZW/Pa1Wy1B+L/DcdlNx8mmY8i0g3km4FYBYfuKpDBtIy+J3tSUXj+dhs 1Lw5eTMon4/2yK7vKR7a58V8smspxusS0aC05OSzWRUGTHqNbjSJtcZ9rYxx0ZjiaBIWsy6XRjN vEb8nVqUwCEPlvoMH1AAoap1f+mE2vX9I8KTQRRdCdw1DjwfrbaoJJJk+HxbjS+AluISIM58Xki VytDvFNVsOd9+Zf2h023H/FXa7D8Qy8ZZmZeuba4nj5VWNhXV808iGapgqy2f9hNgaYrW/CJY0h 2VEItuzEzIgQC0+VbWMhBjWNv4Uyp9WpjXmb5M0loDcUfki+jGchYfPCyVaiIM0CJstSCnD+C9r 65MYcc/M88OAa1VAWR+9EXrXCYYyrJvo3SsleCfVhQOqYUwOEa3G/+lCSEOgp7Y35rc6YP6FE X-Received: by 2002:a17:90b:1d4f:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-38ec648e273mr4470428a91.2.1784832417345; Thu, 23 Jul 2026 11:46:57 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:56 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Matthew Sakai Cc: cocci@inria.fr, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 23/36] dm vdo: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:25 +0900 Message-ID: <20260723184538.3888637-24-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/md/dm-vdo/encodings.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-vdo/encodings.c b/drivers/md/dm-vdo/encodings.c index d75e023df637..b09373b0cfe8 100644 --- a/drivers/md/dm-vdo/encodings.c +++ b/drivers/md/dm-vdo/encodings.c @@ -1333,12 +1333,8 @@ int vdo_validate_config(const struct vdo_config *config, if (result != VDO_SUCCESS) return result; - result = VDO_ASSERT(is_power_of_2(config->recovery_journal_size), - "recovery journal size must be a power of two"); - if (result != VDO_SUCCESS) - return result; - - return result; + return VDO_ASSERT(is_power_of_2(config->recovery_journal_size), + "recovery journal size must be a power of two"); } /** -- 2.43.0