From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DCB483BCD for ; Thu, 23 Jul 2026 18:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832426; cv=none; b=VXmwwik/yCRM7S6NHDD6wshrh+UOOUZqJpr157vdJuwITRCuT2CGi+a0C28fChtYYDZ6wI6eO3AdNeP/4Wcl2TZY90+9fNe4oxmTcTG2OCE5REUZTVSEoxCqQlg3KT1dz2rEL6i3ow25JioPtgMJ78Bh+stlZChAKhh1JHad6+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832426; c=relaxed/simple; bh=NmlRNc2Hv7I15iZ5R7bh4z3eyVqCDkhiotE+Q1mYe8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ISAPD6xmJxyeHFk5FcEPR+3GkSoeefEP+n6EfnIwpjRvdb3GcMHYgZkn6n4kXKhYak2K0Gk6WJVfyXvq02dJCSImjTcQ37xgi+fro/aTXL8/qHKOmOVbJT19iA26MFjTiS+LTWHHCU040kWYu/9Ia6eFR3oSd4cEOagM+60cAsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C0om41LZ; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C0om41LZ" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso1333267a91.1 for ; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832420; x=1785437220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BNEry2bLNg81OguQ9I1ru3wEUBWoj/YG1funVUmQkdk=; b=C0om41LZTGOUFcPARp0QOJajKF7NWFnQ/6v5amT65HU6GZxIgDOIwGYZB9c9pKThEk Qz/OFisxMaH1xY6LTUAQVAXAbayd7KXxlCsbM8MsWujOpvSxOb3pm5a91bHubMZ20xsn 2/XUwTqNRFZTYGL8yKoRGePhXca+7l2vvM6qd+7K1hp5H0yfKdPXfk995RBD0/YDAY53 MDPpzHZt0X3IdHjrgoKQ2azZRVgdPGO4JzEYADBJEOhvIV/mEXGw5ksXU4i4T88fuoji 8ei0NKRPi5nTxQa7KmQ454jttRr+y/BGuiu7SDdxin7YXLTh2t+wGupaPt2umuZDqUsq CCLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832420; x=1785437220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BNEry2bLNg81OguQ9I1ru3wEUBWoj/YG1funVUmQkdk=; b=beipmtxFHQHciefx9v3U02xpHCw4ZvOGDKWRsZSq+HT0a6PjSyKxAtl4TKAtpkmNs8 nmJDMx4R7ykfBtC1yr2lQdUlTSq3yBhmbgvmyzxRm+Aa6GpsbpaZEWR9fNkp0sX3x7/v frBkTkatyNvtcQc/PmH/074iekdi4+PduGIdDlX77ANgnLA8TWVQ/HXejy67vSU7n4Fx 9sM2p/DwH6U997B8xUD/oheA38fU8UiN+TzJTd8wckqg9XEpnfwJUQSMFxYTR75W0Chx DhOUkxN8gcYNboSoc1Zc9Ve2DVdQBC3PIftl7e/CdGxN2IbcVDcmfVcSVkioNMpCxYgp 7dSQ== X-Forwarded-Encrypted: i=1; AHgh+Rr6hqEY3i1caojffrZUtsQUm4MyCzC363ZOhZrapYLUtP3KHx4gQ11VxETSDMdqTD9xERKjFQBokahL1Vs=@vger.kernel.org X-Gm-Message-State: AOJu0YxbTczl3WIxThSjy50z5PBeejxaKowKoY59rrevnAlkdfXO64DU XCeZV63neo99g2PDM4FrPd5U2MTTg7kQsikfaDnSFg5TGkghjOpge9FL X-Gm-Gg: AR+sD126kRBHxt+vzTqh5TG6Wghckxd07yUQqlt6hxwWcwsZoLrAQHanH0Sog3TJKfj sKlOj5aZdZwW4aodUk5vo78OKGG5ftQ2MzHUOmZmIuff6ol7bDeFp1NzvJa8QwBF1u54FeaILj4 2c0Z8VRM1L8nXMga8XB/sPJC1POMTaX90LhVuPG/Easm7Zeyjy7n17aOjTRC/kALqu0Qmpq0+Cx orsiDQcxTDzcYalisyFUXix0hL+NTuYNqTJuVaZBf40qNjIEA4Hv6yMasiP4c6Yp8NYebEwg3f7 8m+4+BSFuI87v4X2/cNJ6sTGpnen8XJZaFleaCbb6p+ktNI42IAIKl/T7a5zOq8/Pb48vZGtaTH CpxYpyoyi19uKDdoNtvVag2FY8/0LWBheYw1zRNNbCgcgbi3fppMQFC/qsH+WxdVfIz0ZrXxX X-Received: by 2002:a17:90b:53c4:b0:38d:ef48:b04 with SMTP id 98e67ed59e1d1-38ec657558amr4646237a91.10.1784832420077; Thu, 23 Jul 2026 11:47:00 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:59 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno Cc: cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 24/36] pinctrl: mediatek: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:26 +0900 Message-ID: <20260723184538.3888637-25-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 4918d38abfc2..a8ab982d8f21 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -1242,11 +1242,7 @@ int mtk_pinconf_adv_drive_set(struct mtk_pinctrl *hw, if (err) return err; - err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1); - if (err) - return err; - - return err; + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1); } EXPORT_SYMBOL_GPL(mtk_pinconf_adv_drive_set); -- 2.43.0