From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73FC7483BE2 for ; Thu, 23 Jul 2026 18:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832433; cv=none; b=oq/vdTrMeNkSXmI/I6+hj1nXvohOo6IsA9bbcOGgQxNMmHjWXzjt5UGDyLmmf2o7C5+zy8MOqVMjT34+fgFxGwtEooN/tBGfKGNQfM9CtDm7iJrr1A+RwSOUpOJGbTDAQIlOoM2GHFynkp8ET6VihFtE7KvazH0J/GiKu4SZwhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832433; c=relaxed/simple; bh=fqeRCaJ05QJbdHKiFDfxqyKSnyoUuDOaEx4VGjGig0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEzShkZWvWyIBCleX1JNfjZPCZCBa8LrWp3WdjXoc68AFqAUBrrJ1qxGr0QuqxtaoYJopnim8ZIALfsyz7I7FF/vZ6LN2YqB7YsbBm0uYl0mylznVeH+Ke3JjyX/CFwiPFxDu5rAwD6wBnbcLQ107W3fvwvqzFEw8DNs1SBa86w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pGbpTHPC; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pGbpTHPC" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so1050785a91.3 for ; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832422; x=1785437222; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O0IXVWZk1Ru5X2yu0BgI0Dx4RhQRg+VvgM7kUVgisNw=; b=pGbpTHPC6buNyKLICHhTVHnS/5hfh7akl2eR+RjWQZTovLjNPLengDWiWeajubNxnK N6oJx2+lwbVNMf/QWFV9+4z5tCX8tUeMSH/fbYZIF6GofwtfwhQjGg2IHXYINYl/cCFY aL3JcFIb1HXzN5MqTW4Fp7baqpEEEvF0FifIU3qxfMoeFanKtzrQk7ZQijwc6T70IsvZ 1cCZLMKC+NdlGu7wHD3EE7WNCmul8VB1NhW0cGI/aEuiBFyCeFwje6qhx4mvnzOfFqLX 6p/rnC1ZYQ2sjXTutmD370Vtk9vBn5WqUDtXadmmT9LXsprd/IBx59B+QBKehpmrAFwY rp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832422; x=1785437222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O0IXVWZk1Ru5X2yu0BgI0Dx4RhQRg+VvgM7kUVgisNw=; b=Rvjc47PqeKaW6OhCGwb05lbxmkY3O3TGpwu6F18ucIvuKUaru9f65NMLaI0Hh/ngC8 w4qU1WH/AwuK0O6/xyCc+WPwJlAvxZ/rEyQqybPzxA/lq+FkMwA8WM5N9LooJFZwQsOm Kgihti5O24CUdoZREBVtKIc4DJi77/n6IGSwzU/yUPyOVv7cH+92ij+KooAN4imSEDeP NKFKoO2Z0viJE90MTJph0YMSvth/AI8aBRxFuuZ3F3RrA3YoPTlnqEuW2sWzs5rfpm1w pDsB0h0SDAleOdO7n7vTwRRtSCjzOtpUNYuMzFk0QEJq8hDtxIvMnV4nS7j+i9HS0R7L QBQA== X-Forwarded-Encrypted: i=1; AHgh+RqwqGhgLf8Al6d4Z7b628gs7GzYiOTE1AkJh5C2f6Paq0q/fKPkgoCoODJ+YUdZUQDNnSGQ7Zm9vrLXQCc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjQALcqTmHDSYsc09+xWGL2skU/b8Azxur/JXIrEBbFv0DgMrw WwFvobbUkU9x3auK+DEQKiCwAK5kviT47JdeiedDae7cVNeZWunPXJCU X-Gm-Gg: AR+sD11xQamew1EA56OS6Erj6d5OwAszlnB18FwJIbWtkHqxI1Xj5ySU8EE82vaBOL0 IlYXBHLngPgQtQe6RBIkSkno7WEK1WJfVrBR2urwq9a9QfNmCnq84v8CDCmrYEEwE82IgZUNe6b fxg0AnX5wkAwOC+FGQSFHs6lId4l6XxNAHU+OhllRMmppNJWiEXQk08nlQHuDwSacIoKImiYCZH 6LQalSbJR5/CWSA45bg39gWYT9biSAtVduYO0bYvS5FOYumNY3YCgCIZRJ23vsiW0rJRYMI/FOV 1ZOcmyJpjasm+kTKk8Llg4o+MLrfxCzvW5Va88V+TSDURkW465WnYB/PVy7iitBRlaijoHs2wYz /5IW1/A+zPib6K6RrzsZtSlW4P7ziimF3eizp2w4ieDaiHGjLaPqHkXFdsDAl359CN6V69jF8 X-Received: by 2002:a17:90b:1350:b0:37f:c69d:ce69 with SMTP id 98e67ed59e1d1-38ec64a7b7emr4626593a91.10.1784832422117; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:01 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Azael Avalos , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 25/36] platform/x86: toshiba_haps: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:27 +0900 Message-ID: <20260723184538.3888637-26-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/platform/x86/toshiba_haps.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/toshiba_haps.c index c6633b74029f..4f62476b8dd1 100644 --- a/drivers/platform/x86/toshiba_haps.c +++ b/drivers/platform/x86/toshiba_haps.c @@ -251,11 +251,7 @@ static int toshiba_haps_resume(struct device *device) haps->protection_level); /* Reset the protection on resume */ - ret = toshiba_haps_reset_protection(haps->acpi_dev->handle); - if (ret != 0) - return ret; - - return ret; + return toshiba_haps_reset_protection(haps->acpi_dev->handle); } #endif -- 2.43.0