From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D3F4D2EFC for ; Thu, 23 Jul 2026 18:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832441; cv=none; b=ppOJcJvXbrlSWMEcQQyz8JR+543a4gtuqSsp/0dONVRcP1ofo9abTt48KOUZunrnl1epZoxE2+clo1FBdgngDDsQtkAr2QOz33ioMrfleorOe2WCdC0dzUF5UHRzt/eU4KIQ1TpWcBJQWdCbEUUJxXj48Fd8+ApWKJV+0YjgXXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832441; c=relaxed/simple; bh=GO3HXrwvfG6IudXoKBCuvVESTCczNdLq2mlP9R/wk2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g0WrisiBbe77QiSPN6CN7lmAJSpffC6zm/BTOjysB4nRH/hEFBB5qA0ZyVeDMTAE5NP4nxYal41aHg8rJcDsIBEHbdAp9hDliR46a4sY4dCGagbvErSzeN8ZV9abZgirOTdxtS3dSJOTcjzuKepDOduv2UU8Iqr2I3AARck3Cp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZQNlvzY0; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZQNlvzY0" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e69bdb0fcso809466a91.1 for ; Thu, 23 Jul 2026 11:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832428; x=1785437228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uC6QoEcftILT8FAj1uSkH8G4vFtlGaDcPImQjtMJshQ=; b=ZQNlvzY0Pi0GmYE2mPvsdGQyU8iS7GEPhKiOQfdBg+Hx6EpODl/OhqFxjIwpxMX7Pr 0J/HDm5perc2W+l/T7D8sFYEe3nPxJjUc49+Lb/BwsWuqIQpR4NxZ1MIXZ7N0BJI+ms/ AsL3YGajkac28gq/2z5dvIIbzUBDTCAISplFoe2OoXwv6zz5YFbMPwsgJRYczzgtiTGz Exw7qdt58IG7TezKKOUQIlSx6AUtKnCXzWOTpXR9V/9W9PHXz3v5VqYlrDx+o6GnqldQ p3gwcciJY+XIbWaUv65MAA+bT1tVDwfd/BhhT2N5eDCQ0bZLkw7RiCpsAErNVRd2iF+Z M+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832428; x=1785437228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uC6QoEcftILT8FAj1uSkH8G4vFtlGaDcPImQjtMJshQ=; b=rNhJ8C699IaEbuK+H0GS/aZZLDINc9MF4wWIeSioSYKKNQS8f1i8bsN/TgFMcWQpwj y9SaQahLo5KvYzQ4fMcX8qqL8ZeMZ+bg9Vifb6ePOCAZBqiiwNM2YGGMyyXBzo0Up/fd rkiAx8FjNJcAG9hHNp6BthlVXnl5nbQQJ7cdbanX0407/ILEpCLwi9HJhdB6eEQjI9D+ LOKlJjet2u6XH5I9X0LclmvCSuXj1RS6WEP4XypVpwlvxorIMkhUzOu2+1tsQodp63CU WlSnU9ADs0u7WsnM4ZOxPYi+ej8/OK2w9y7oJLEUaPCVzhbM5Z9qa2uWe+OkOQRhY0Zs Ax/w== X-Forwarded-Encrypted: i=1; AHgh+Rqcj4tJdATEkhgb3SIC9eoOvdjqwkbFTz9agShf4T/gZfpkORW117AlFEJI1idFZxRTyni8QudqQ1uUOr4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3eK8C30ntsOeo5QJkn4fWfWSash1kKn3P8k5B/+nF6//bjUJI ZVhhcJv9YqwktiivOvFgZPxHW02AsG0Prd8okS44aQqGb31gpE7BdM95SFvFXbKHluk= X-Gm-Gg: AR+sD12QEZ8AL9rNKUHtOLlsfKEFsWyykCvRm7fcxnKIFwRITxAB53SDeV4IATaHXpx kCJHQR+nFAMP9aQuG6gbxoA3RbHInKQGoHj0a+DTDBlVzQf37CHVvvC6rNAW63pkMfF5fI2YCHz AdxXPpJUsKBoosKlNeQpQS55nkMgt+5h14SsHg7XBpF9PZUyXu26Ag0wSvvtVT9kVxYDFOIFqDp VPFPYo04OviJKAJxC9NmilDZu5jaUObwBbzy4kycvuOthBT3aSe58P/CQ03WjAjuSY4IX0zPpPS 3ycflvnV0jZyZYmratJQYWUxqd/gxc8m41Y6s3iKfb9CHvjk66FCLrLL6pQyGNB3Ra3YYt5E3L0 3ZZHlbKt3icL4q6kb+72BGj899Xh6mj819FIhaZycen+lptzqBP07yVblwpTGNjzwFyw7i1i7 X-Received: by 2002:a17:90b:54c8:b0:38e:b400:a86c with SMTP id 98e67ed59e1d1-38ec698f5a0mr4314176a91.16.1784832427550; Thu, 23 Jul 2026 11:47:07 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:07 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Liam Girdwood , Mark Brown Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 28/36] regulator: wm831x-isink: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:30 +0900 Message-ID: <20260723184538.3888637-29-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/regulator/wm831x-isink.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/regulator/wm831x-isink.c b/drivers/regulator/wm831x-isink.c index 43f220cea21c..b46e2cde5e9d 100644 --- a/drivers/regulator/wm831x-isink.c +++ b/drivers/regulator/wm831x-isink.c @@ -62,11 +62,7 @@ static int wm831x_isink_disable(struct regulator_dev *rdev) if (ret < 0) return ret; - ret = wm831x_set_bits(wm831x, isink->reg, WM831X_CS1_ENA, 0); - if (ret < 0) - return ret; - - return ret; + return wm831x_set_bits(wm831x, isink->reg, WM831X_CS1_ENA, 0); } -- 2.43.0