From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE69C3515E4 for ; Thu, 23 Jul 2026 18:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832443; cv=none; b=iX2u7FfXzHVwmQ1dSDc3el9cVgS9l7S0EIj6T0JF9ARyB0XCqDflLTlIt91KRnuTib7r1mhlHUKnKrbedEb/5NGJleqVr+RG3usdLoq5OEneqlDXaG5oIrpUrbjld6VSqK4anrql47zcTW3Wvvo1rFukyEuAdUuTuzEs6AbOTVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832443; c=relaxed/simple; bh=34ZFRB+t5TBTN8y4CUuvqqvfbV1iOyh2tVj2zJDSmAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KXuAfPvlxjON4W66+X9Pabguvamq7sNDEtFoSBVPn0UDwNxR6eZAqgCT1KA83gycxk9ruL2Bx6pKRSmuXJWlftIJHpPD8u6AYCtO1CRRa8cbAro4Wq9f6K9RXZbLZDYCztOUbdlkNIgLtLY1SsS1Os1nigfqZOLiIBez/lXYhGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TD/1Pkc1; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TD/1Pkc1" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so977971a91.3 for ; Thu, 23 Jul 2026 11:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832430; x=1785437230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SS85S9k55fKh3CHy42qY+ZLh5U3vliQxWiJO6SqlhjU=; b=TD/1Pkc1wq8iwAQ6o1mNDtpMuoZuvSkiuGwfhUneJRw1HzYJ5qGaenT5rbJhCPlkMk R/8P0GeILLaYJBuBLIkNvrunADMq40IVULA3BKz9G2K/rmUPWQzPoOAbjNYYXTlixg/4 QOw2LsB0nNGeEId9vQ/SPB9KLPBhRJp+ejGxLsb0Jpi11z4RB4xfIBiULLYoMcsGwjZo zQBzcZN/GB3uSFV0WmiUyaW3mK06FdQOm7FVDt6aMoLbQjF2OWSg8FF9aWJBMV9pIejL 2ixwjIBGwGPQX80PfBWJxl/dfv/8Bu7jzSBfrbthCE8L5rjPA2T6Lf15a3dXmbwi/n8a v/xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832430; x=1785437230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SS85S9k55fKh3CHy42qY+ZLh5U3vliQxWiJO6SqlhjU=; b=NT9Fo5HYRZ+jfXzEOniIQQz44Zp/RfztlHuPxGTtZFav0yE20lgnZFasjZoxYeYalY QCYLBzs03KbNRgRSGdMsPOnYt2avmH5O9fzrtS7r6+yTO+vm0FqMpRclUW8nn7uL9oTW 5se9AEg4ZTi4Ar+4B50jzVyfjwDXCki/JtxsV2n9tmDqiA0eY/Y7Z75rhCKPCmejGpAO ATYN5CmgZquTZSHPXu+lGTCGqbmSvCrsyW8pJy+65ONGrdG9nFAdFkYLCmBsgh2DkDnL 9hMNFRD/NPg8yKk7l2ws8Q/M7VOxnfloNAE3stKNkzmeKUOcuWVIooQKA1YECRaM/WN9 wL5Q== X-Forwarded-Encrypted: i=1; AHgh+RoRe6ZWXwrVLwd9OUHyek0VzWTooVskLqawQ8iXbReZmJ3xsp5dnPxci6cQYEtrcUoFkYNeI2DSEV+mGzY=@vger.kernel.org X-Gm-Message-State: AOJu0YznUU6J4d+pjDLB3NuKB01ZbsSy+QHcP29Zwmqt+EikqVDiESkK tqDGsCnsu10dJyUYsQoJSUiMxrVL3VY4ul2ilS5iJcIjjxlpSio/GqBo X-Gm-Gg: AR+sD11HnmX2tcr5lT0LAOpZH50f8e1ZCHl/ezpPIVcyHeKFZ22M2yxFrsv5C0CkkRT SNXysxYTbWuZ9FoGDzHleQS0O8IrJ8hsnejms46i+Vcy1h54r2ZhPSHCe/5Hh5DHLwF6dc/hMst Mt0jdRNlOcanlXjNt8+foOGiZ2iC8U2uvG0XqacuOoLzEIzjLVWbklwEdIuQ3UUiACUW0SwsvTP baVZoOnKcnEp/24c6lD0f0fiJzaHVLitQLOVMHvgcPwWQlVk+tU0WunTbTPWSjda+WdFsboYpyb UZqV3KdnW5k/NOgMiKDHJ7loM8lkOR3I6yOa3Bdw3CnHgE8oH9oTu1fwwlpxwGN5D6MZQPH4I6C 5x7OLGpkw4PsIW7CN4BJ4HO8yqPKXvduDu7ubNkLT4HdibXPKEyUpur5qZWzlsi/Pfql/Jydd X-Received: by 2002:a17:90b:3b4f:b0:387:e0bb:57f1 with SMTP id 98e67ed59e1d1-38ec6a7a591mr4120286a91.34.1784832429331; Thu, 23 Jul 2026 11:47:09 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:08 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alexandre Belloni Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH 29/36] rtc: pcf2127: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:31 +0900 Message-ID: <20260723184538.3888637-30-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/rtc/rtc-pcf2127.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 1995e9f2756d..ff2023908f5a 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -1184,12 +1184,7 @@ static int pcf2127_configure_interrupt_pins(struct device *dev) if (ret) return ret; - ret = regmap_write(pcf2127->regmap, - PCF2131_REG_INT_A_MASK2, 0); - if (ret) - return ret; - - return ret; + return regmap_write(pcf2127->regmap, PCF2131_REG_INT_A_MASK2, 0); } static int pcf2127_probe(struct device *dev, struct regmap *regmap, -- 2.43.0