From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E0848CD4B for ; Thu, 23 Jul 2026 18:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832439; cv=none; b=C4wlCNfwaUh/6h0kp1Ll2dweaF+nScrihzC73Knq6vxnZB2nn5o3gnfuHzM1tbBitzBFs4EQ8umnderYy4rAtYidt0RIsA0fmO46mc92aaKLAASV09grjrsMslveCNHE75Bh/b9aAOeTpE56pRg5ILAJcCEmnmxjNJsBTUaDXAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832439; c=relaxed/simple; bh=M9H1p6QdSNOybgbowtw6brrEl/02Mw1iKn1qBSJlFkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sqtfmw/+X5QP08mPFXA336L/lZTPEyZpRHn4TZChAtMw1Se7IQpe0a7ti0mAZ3vyGjmMC5b8GlBJ6kpM1zVFCwqv4h5IOgWmQaSIJDeLmFnN/QMuMudtM42p8bElO9b4FVj1Ae0bn/312Qwm+YJbPszjKrGUZ8nAFbRc6RSFtmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FlepFESJ; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FlepFESJ" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1066611a91.1 for ; Thu, 23 Jul 2026 11:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832432; x=1785437232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OMO2KRomBUijve5D7xBOqgHhJt3kPIgvFbAoFSgbWN8=; b=FlepFESJsWWL3mgLFlHMbrQvrwkligVKZxXTI6pQfH2p1U238kH8qVhIOlai3pHolK zBIgGNbT80Yq4lx5AmtWOr/bYISNNBbMHzGUSOmTd2K1iUhaYpjn7owAdjpgsGv3hZ7w M9Imt4zVIq0CKdMQTx1U9gUice8EUT9ZyWCIFegSCqNS2ik7Q0zx++/8tDmDCoptqOFi CjvPs8MYj50hwBCmt95agiIzsVGOoltf6UyePgNCBnkM+cePZh2/wF4aoD4AolHXtlqR 3Q9KYHLnsrUuthqKXna8shfkq7TUOlPhjrJjVlmkwtoUuUH8QjvxFAqqMYQJyYfZY5WQ 8wpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832432; x=1785437232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OMO2KRomBUijve5D7xBOqgHhJt3kPIgvFbAoFSgbWN8=; b=cBnITHvu0OzXplH1CwT6+H+crurOVA5/QV/dd0wbZgYom1s0y8UbHgBAWR2McJQzJY Wax6Ojl5h7sHH0aVo/9HCm6kwZkimRzqt69qvL+mfeBrJxKNtEmti/4FGe5fshQNi8QJ nxlAW2PsSXfHap3bsVI6u+ait9f4CdlNGyA5Nklkq3eEy5rFlUdPeOAChcNTe2N3aeqx s1SljLFG7TstvQk5bcLZkzWwN/CW1C2Yusm/toRXHJX7y0rnO3w6LGNYhM+PZ7swUtz4 FWMI/Tg+xnGGzhpLJkSXNz8ee1SgoWQfXOH3bRyDlg5KoTR/BmZ0drDtMPhIw1rGNQnh fryw== X-Forwarded-Encrypted: i=1; AHgh+RrZiEYPUI8bgmJlE3sOAF4Wrol/2xzbvYeYi5xCdJlawPjhBWsoB8oVqhzsxpcumz0aw6x2MSOHq2Y8pZc=@vger.kernel.org X-Gm-Message-State: AOJu0YyqfGzraLeUmRLi4uhbUHhgU2grzmwVF9820w2UCdTQ9i8SOKyt b0EFn6lHHNkTQo9tRFODZi236+vcpQOWpXznYYzOmKFQhkUOAZ1OUA9h X-Gm-Gg: AR+sD121z0S3c1gC+wC0DF4XRXrJL9zQV2SO9GCK2MF3EPd3njCHPMY86EctQHpSlzP GD4SR4DjbQ4KpVrzWKuRp2LYUbGyAPV6Ubbez5ATqm52xAn7G33ibdQcQJNfcQNMo58HUcVTNom CTsWTwlU3KDy/Yv9trrw/SQyCXUaA+AyCWmULUPOj8O+taoA9aABOiXRuIl3rfyijBOI34dr8PG 7PN0XhDYLECfsxd/Yi3EgrLz3LzpAao5ujgYSckO5WbFAhe/7CCMEeWeXgMcMenf5OmbZgmq7G/ z/ayJ5IoF0oldfwscTjyebUOKw7DKL3qoX19ljq34NX3jjlpbWwPFiuavmfSza5CuC2QBq3ty/D yRmk2WtdlrfQcplPM+gTsAEvhWmWTFYfBtKpGYGIvSXgoba+0NUytOmziNFn0Ac7VLNAcN5ys X-Received: by 2002:a17:90b:2ecd:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-38ec64dc738mr4624841a91.14.1784832431870; Thu, 23 Jul 2026 11:47:11 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:11 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Ranjan Kumar , "James E.J. Bottomley" , "Martin K. Petersen" Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 30/36] scsi: mpt3sas: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:32 +0900 Message-ID: <20260723184538.3888637-31-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 79052f2accbd..791a3c5fbf44 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -8369,11 +8369,7 @@ _base_make_ioc_operational(struct MPT3SAS_ADAPTER *ioc) return r; /* scan_start and scan_finished support */ } - r = _base_send_port_enable(ioc); - if (r) - return r; - - return r; + return _base_send_port_enable(ioc); } /** -- 2.43.0