From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A43048CD5D for ; Thu, 23 Jul 2026 18:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832448; cv=none; b=hSNNQxLYMUBaMLitHDBYZ+wJeNpB9060KqrqPe9bH3woLO1br2Z2IOnKEnhmi1pJ0nnCEOLnEC8W2IEPtt0ousE2ieKTHEmlrWYAA8Lm2e3M5ieeFCVi13LYkYLfbOz4p9mfbXlkJJQL2BykBLp5PRXkmh44VJrpFnd3t9t/SB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832448; c=relaxed/simple; bh=uYqyINOSIs4ZwGOEvHHuixscb0ZcxiQRCToDw0B3yuw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nMmYvQw7d0rHnUuOSZM/0Tmx/zlx1pYcPmxi5V59to7TQiNxPLvL4inB6IxVXpxi/oClgobXFkCp46DRht93pBO8Y2clSU8vAYhNuvl77c14F/6mKriGk1kCcz8k9cvmttcsGnOWRG3Rra9Gv7p8n7OMYygsRlVRTliKzZyxLvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NqweemoK; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NqweemoK" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38dc4553f62so1054797a91.0 for ; Thu, 23 Jul 2026 11:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832436; x=1785437236; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SiSOFKr0Kvems3WldMsj2qAd8XWvGaX93cSHCBNiZh0=; b=NqweemoKyNtknpypcRWlK+uEZxc/8ExfNlT7yP3H/rpladxpXMbLRiJtX7sfGQnhsA WRH8gE/fUz4Qrx8i9HcpYfrVTVpeV1ohdkdiRZP77SGHizEtV0sT3TEyp9DuW1DTAM+Y m4w78p+LGkofLqk4RKSzznPGhwO589Pkw06aF1uObvtorirP6g3KnNNOpx0w2/rnGmZK DRc1Z6l2bifjxR84cr6gywQ0N1q3jJ/IpFvWci2EvJQ+9Jm8ujlDmYZbQVE1LK5ryXSG CynqIV9f1BN4PgXkymN6XyU4JU45HjkF+HSQk7b1kdhVsfmTs6tJuNktWBNenzJwi6or t1BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832436; x=1785437236; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SiSOFKr0Kvems3WldMsj2qAd8XWvGaX93cSHCBNiZh0=; b=q4zIPmn8y24eGyZXQ2+cubYt2+Uai1xXDWR36j6aQlXGGO4JbytBpB42iMlMgG7GOX z2TZm7lWO5ESuQHT3gaS5RhVigpRVt0gah4XkXyEtgicQ9yNk3T6QaPMpre3jnJ7nnyB qkEKrx8uQqZ2qzt23VN+xQxU4Q08F+MJYFqpM971y7ZZZxKtT8nqXPPM7xNUS16wpFCZ dbN/YhUmuZjeGh/iYkdOPDb/qZC0fixPEFpKz6yNmoXmgUj/L5D8caGch6n+wCg2X/3A zGyAl9FX0C09UDzFH/WoAbuoj0aEci060yVXfkKVyJ/hzc5BJhTCdGmVfoS0Kk0sitxn B3zA== X-Forwarded-Encrypted: i=1; AHgh+RrdDzDjNSMRmPnpudpsDoGMgvqp2JkiY/lRzsMSK5khqJ3CQBzFfu29d1MzjT5ptZ5oCFyU8cN1ga0c5sg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj4a7+oiavn0ZvLoZTWjvVfZ5sdqQPYfI3pmECmYvMIm8CfvZo 8Zvt98nKzayazfNekGBljDtbrd4k24s10RSJvoS3Td0Yrx9FWlNLWGoM X-Gm-Gg: AR+sD10G1p8UOMpMBTuitbTQJP7rGgqks3ISr9ADJLnr52x6zfSRHmWkHXp0DycKWDs Xxtyk2Fa4yjHoKEcTVMZpQqewYotpSK3Rv5MjOuDknuuFLeH0KXJdqJ8IwLUH5pP1xeKUVNegkk z5RQQCQzpNWrZdbxI8DuI7WxjiNLFJ3OGBmJxvW5tIMLEsXo6F/UFcxi6SNlVlSkC4A6N37YrGb xOTlgwGDhwoMgZ2nZxK2jt14v8dUGP40Ug8W5KVSaGMvRO16XJCWhuVizmx1S0S8D9CNQVucEDa ILFDz+39NEQSkaoJkh/fbgiS3gAQWk96KRhYE000tszdRVMnsjDdEUTvWqnbPmJsE6HXKOyJhLG vfrFwJ3xSaXCjvT13WXMexOfzXZCfvmn2dmIIEyrSUFdjnAPb6CwExHly7ZkPwaQE7ndHUv95 X-Received: by 2002:a17:90b:5885:b0:38e:921a:5512 with SMTP id 98e67ed59e1d1-38ec64dd01emr5012020a91.10.1784832436164; Thu, 23 Jul 2026 11:47:16 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:15 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Johan Hovold , Greg Kroah-Hartman Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 32/36] USB: serial: ch341: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:34 +0900 Message-ID: <20260723184538.3888637-33-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/usb/serial/ch341.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 569f4aede215..3de317bde07b 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -279,12 +279,8 @@ static int ch341_set_baudrate_lcr(struct usb_device *dev, if (priv->version < 0x30) return 0; - r = ch341_control_out(dev, CH341_REQ_WRITE_REG, - CH341_REG_LCR2 << 8 | CH341_REG_LCR, lcr); - if (r) - return r; - - return r; + return ch341_control_out(dev, CH341_REQ_WRITE_REG, + CH341_REG_LCR2 << 8 | CH341_REG_LCR, lcr); } static int ch341_set_handshake(struct usb_device *dev, u8 control) -- 2.43.0