From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ECD848D878 for ; Thu, 23 Jul 2026 18:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832447; cv=none; b=CkYqwv3b3C6R9gEV0+T1WPRaf6ROKJYNcj1yrs2DTplJk+oUet+TPHCSiN1SuHDg1GFBaFCNAH90zWeg+aU2e5KMsrWK6lqxyOUFnuZfoyiOTuHwJGwu33jxS1FsOMMDoPxmsw3dHJ2V5CHqQxX/qkG0WqEoj8tQc2CXZTZP8Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832447; c=relaxed/simple; bh=dCC2It8t5ngYjhp2LUzJWM0HuvqaBLSMX1+wrSZKJ+s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgIYRkWXMo4W8+QoULwubUr6krECD4wi2PsXXCr4H1LgE3IFpTO1PiQbDdp8uNcnSIu8mG5j7LnJcer+CyLbAdKmFTY+jto9v3Pd/fmv7Uv47rGvJj0fMEJIC9N9rbrcuw5VWh80UZel8hB39xb4oflkdb0om/9fJ2CU3GHwPV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wpq9hLLH; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wpq9hLLH" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so945151a91.0 for ; Thu, 23 Jul 2026 11:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832438; x=1785437238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bbSTvhrvJVaWNbYcerAizGhExjCM7xuViLJbvyJxqsY=; b=Wpq9hLLH1vYJks3QmCuyFJkccrysLBesM+BZ+yNcWOqaY6PItW8BtoiHZh/QoegryT mYDQdP1QW8hqLnDno49eHJG1S/nJKQGZFT7p3SPVrur1IGXGypO15xNQOLXn91mLRKHk AoPXbJByrIhMbM6YetSupYoQLMJ2YQQrZruB8drHLVwBR3o7BBEN2SAmElBPyLNqABb2 rMCOBAflr4j5WCL+/HESN16zduHsxZKEwR1m3zxg+U46LbGtRfgF2PytN9euP3vk0Ra0 +r6AqKzPMB85CLrd22x6SBHqOkg7RRW/TsdLfAPN2Jy72i7ek2xpKv2uoI56QxNXZCYi 0z3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832438; x=1785437238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bbSTvhrvJVaWNbYcerAizGhExjCM7xuViLJbvyJxqsY=; b=DYti6bsGNLyhpu2FnTf0iwsOErqcmxOMEXQ76FrIjYGvDNSElDZ6e64OXEcZ7y/0sy 3IZfFE1iT0hWAfnm0q21f3GsxJILE0KaCA51iN5PD+Hdanz7LZaAFl/6YJTGyS8h+zoA hJRdnU/iqIkI1UFQ7279nVMP7k5W6fr2wuBhYpWwMLajUKBhoTYK4AugpSAd6ZLdzi/m wduY2WL4E4QLQV387NwkNjD0AWwEtuVdAOUhPEDdQMfBF+E2UunvAs2JOHShbC/fJPzh Ai+F6qFmCdh2aMPaYDBI8yNiWvTKRwmdDvpb/oJv69WJI5zNCINTQ2Jh4S+30nPAgMx6 y3uw== X-Forwarded-Encrypted: i=1; AHgh+Rpw398jch88x4v3e7b6lJTtxb5KUB6jLqKn709NKBt7ujCPEb93QDfcv36EPb1HRiaIgC2fdjA5wLwbC0E=@vger.kernel.org X-Gm-Message-State: AOJu0YyM149OjPclUJNdWDzDDVO1bl6IwKnvcVxI1xwcfCGZEddHaR8w F/xyFjZhytQAXgfT9h7VpovI6ewGTw2GYFaQfkQoO1HoiB040umUz1oM X-Gm-Gg: AR+sD11KXo7DVkGIIf46pZMSkmq/Ba8K7LjLCvrECWECP5U0uGRYq6LHdM0IMlRT6bM mTmZoiLmHPGtGdWBSzh2CXprC9Xk6iKehG13RdCJLjsmfG2+RzwcSgNOuhcZwk6LzJc5gJ6qz+U AikG5djpm+S/RpoFpcVflL6qsgNBYbhofxeZi5ZQaJzlrOpLF5/b8EXB/VVjyTTtVLwHGQqAbae bPVNwFIS02b788eH7hL7Vd6r/Wji64HdUwbKXgsr6iRpoNpkuN1RMThU5e2vhF/EJYR+pMMa79b 83cdARxHPnAzKV4qqv0r8m3vsBMaAcnmtdrySUUpLKuN0bD+uHLOzsE2qktN1KNZ+3l20/W5tL4 tiTdoB5eRk36/RXUsGniyLrLO50vN9tCyHzIVu461YVifnqynLthrWX3lB8Iq4xD9wdDw5Clus4 kAGERv6IU= X-Received: by 2002:a17:90b:1642:b0:37f:f4ae:5f25 with SMTP id 98e67ed59e1d1-38ec6a51c61mr3940118a91.20.1784832438557; Thu, 23 Jul 2026 11:47:18 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:17 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Heikki Krogerus , Greg Kroah-Hartman Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 33/36] usb: typec: fusb302: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:35 +0900 Message-ID: <20260723184538.3888637-34-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/usb/typec/tcpm/fusb302.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c index 3319f6a2b0c9..d0ab247b24bf 100644 --- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -314,11 +314,7 @@ static int fusb302_i2c_mask_write(struct fusb302_chip *chip, u8 address, return ret; data &= ~mask; data |= value; - ret = fusb302_i2c_write(chip, address, data); - if (ret < 0) - return ret; - - return ret; + return fusb302_i2c_write(chip, address, data); } static int fusb302_i2c_set_bits(struct fusb302_chip *chip, u8 address, @@ -375,12 +371,8 @@ static int fusb302_init_interrupt(struct fusb302_chip *chip) ret = fusb302_i2c_write(chip, FUSB_REG_MASKB, 0xFF); if (ret < 0) return ret; - ret = fusb302_i2c_clear_bits(chip, FUSB_REG_CONTROL0, - FUSB_REG_CONTROL0_INT_MASK); - if (ret < 0) - return ret; - - return ret; + return fusb302_i2c_clear_bits(chip, FUSB_REG_CONTROL0, + FUSB_REG_CONTROL0_INT_MASK); } static int fusb302_set_power_mode(struct fusb302_chip *chip, u8 power_mode) -- 2.43.0