From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF08448CD59 for ; Thu, 23 Jul 2026 18:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832454; cv=none; b=N8/KYomYt6tDjKEd+2LrpyIFaOGeSkyCtNsHH6CECb+PuQ1jcqrF7N0XZsRSrqVHMfrVU/vrEZEDiZNg0ALygKmF9aoisd65nHjfvu/bap5slXrOc5XcdJLrE0oyfYMrO5Z9fcYQUTph+4JzG8ty7fcxP70jNVheo0IGwjY6WzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832454; c=relaxed/simple; bh=0THJsAe0GGadOigqS9gjiJwezmjYYlE4GhLoiWCj6bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FOp8+2ocbGQ6AoeE6yiR5iZ2rmph/7AxLYUoMd9j+R2+kats8LGvH0qxoq/jK7ElkIxl6CdeeNyEMrl/ODZFZiMB8Jtt2BaEXj2sx9JYqoE4LLogdpULYShf3TbdzFcS6KFylbreh3oh+v/WFDqiaCed4rN7h67TijtlyiKgA4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EQEIVisM; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EQEIVisM" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so723446a91.0 for ; Thu, 23 Jul 2026 11:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832441; x=1785437241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iwiokRL+A5T31Uey5wDHfoo+mp6zGabrAoF65o28YUE=; b=EQEIVisMEVzEoxHf1rSoc70u3qlYJGbqv8TJewbswYbYTmccAoY3xOHDZZ32ILBD+r Da6RO4tS/8NqOobZZK4Yca4Ux66fFR/z6M6WA5tKHr/+iv7Pi2XN2SHaci3hDCdD2Njj m6cJVRLf2SfKZq8xyER6GKP4nKXQXk9UueWLylXDQkIPfLHfzvByGC1WoRNSwV0RiHA9 ARDlw1wijdnkIH03UiZK+MDgZ4CC1FRaI0qT/Bwu65BPQgsq0WxM8Y5Xx0PO4cvkBbjL LFWHluf0Hqr9x2vNKlFZa9RBOnEfvZEiIs5eH1iZtiZrVGDvM2m394FnPDahT+cmGiCf s2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832441; x=1785437241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iwiokRL+A5T31Uey5wDHfoo+mp6zGabrAoF65o28YUE=; b=lYdgobrXs1fMMahIXccfh3QB0ND3kPg+aK8dW6Zg1Kr2EpHJhESxKhxjJbEwzB4aOv 46fm9OfHN4qIEinlgMx173EbXTzZKOvDpKLfRwMI5d4lEA5IwWWLSlbXI+a6wBbwUIpO 5ZsTiZnQb4tuW5CyJmqtIrmIINT0GsIb/x3Eknr1FPUTX+se1rKErT7vKe/Oe+Nk/R5K tXZMb42GceaLk7laaVVAvZE8bUtO3G1OAhvrwQHvFSoee5J6yS4XYSOE5C57x+2U75WJ pKolBZtCMmOKo82WFtzpZ9u4NWKcTplP/spa38Nh4UXR/W8BtU6Ok/1OO9HqB2cv8h6Z HXJw== X-Forwarded-Encrypted: i=1; AHgh+Ro//f3hfQn40pJxRwzY/XewK4idyi+6xv/zIKYrYEzx9b3Vd1rMCBq0sb9Qj7tssgt4wo+wiu5VLwal8iA=@vger.kernel.org X-Gm-Message-State: AOJu0YwMG/unL7HX303Zp3Cz9D6tubzdw+ISfGU1oXC0+j7ML5sQ73Kg VFcooaYUCFd1SdMIpfuRdx7Qyvnj96qZPYpI/iACLibRYmmf1oeKOD3B X-Gm-Gg: AR+sD13vvTqyTFXPERXc4ai7FInQvhr4SqH9QME/4flLoYULV53EcT3m9XPlT32sv1T z618mxc6IYml/oChaPAdWdtAer6sxqnoXRIaj2Cr73TR9Myq75wZGMYKA1XNGyKNwXJlNAVBjMa DdGAo646TXpnI3bUOqMKzu4aCwQaGRaDsIxZ78PRC+5QKOEbjgMuVUmyUPyPQyhEe/hHs3IUyE9 HtbCZp6U66+HjoDYkiZVtweWRxx9RVno0CK7IleIPtWaWhPqubtds+Vfw/paqFPe6K8GE1muMmk ofzZBa6tfNX1mg4fzSfjCh3fODKL1dTcuQujZOv3HWNSA8hxoSZ+xR/+Q4ssJv3qRhqwAzxCrjE GbXG8JZm/ITmhPkREpqcz1Tm74A8tArDL4vgrMW0coWJdb8m2TkAA//ewqF0WA9ruozkA+ug2 X-Received: by 2002:a17:90b:52cd:b0:38e:5ce1:ae30 with SMTP id 98e67ed59e1d1-38ec8468567mr3576355a91.14.1784832441260; Thu, 23 Jul 2026 11:47:21 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:20 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Steve French Cc: cocci@inria.fr, Bharath SM , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Paulo Alcantara , Ronnie Sahlberg , samba-technical@lists.samba.org, Shyam Prasad N , Tom Talpey Subject: [PATCH 34/36] smb: client: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:36 +0900 Message-ID: <20260723184538.3888637-35-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- fs/smb/client/smb1maperror.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/smb/client/smb1maperror.c b/fs/smb/client/smb1maperror.c index ab3d09613c91..395299f9121b 100644 --- a/fs/smb/client/smb1maperror.c +++ b/fs/smb/client/smb1maperror.c @@ -234,11 +234,7 @@ int __init smb1_init_maperror(void) if (rc) return rc; - rc = mapping_table_ERRSRV_is_sorted(); - if (rc) - return rc; - - return rc; + return mapping_table_ERRSRV_is_sorted(); } #if IS_ENABLED(CONFIG_SMB1_KUNIT_TESTS) -- 2.43.0