From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5929353A8B for ; Thu, 23 Jul 2026 18:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; cv=none; b=FVtPuqnLRD8H9WE3me+o81jCDsnP1HTzBsJscm9JTEBmykmxlTy5kP/lVeSs+8/kvVw0IX34xg9JzUWFvSCSN9TbwupWUmzVPR/CsOav+Gyz78BS57z376oYOAQIPYbBCSTG+E7834d1eerH1t0qol+wpwh3dGV498hxZsx4wgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; c=relaxed/simple; bh=iCij80qbxvGV+a8hzW5WU4WAS5USF0l8tEZxags5rG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g0qu+rZHsRm5af1EiPOSvjp8v17ICtIz0G9/AcXAUYlgxw0Vqr7jXZNEGXWioypw+rrKjWKeDAWObuZnOkSwBp4kazLtPuVIYSedETIiDQMW8HoFFVCLEivQqc/aIJP/TfTUNtZUtrLu15RArJw1e/93/JvcUF6SeXaRfw8Lx+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JuChBKgT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JuChBKgT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso818706a91.1 for ; Thu, 23 Jul 2026 11:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832367; x=1785437167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6s5SzAkwTqv2cG0ZEuCiRJMYbGatFZIR2B9nCnRkYh8=; b=JuChBKgTldeds6XdmD/NHBFGzv0LXJ1smq7SWxpyJA2yimTK899kXO4C4gU3/sd6gK RXBJEUHrqvIWN3/3BtIxBzIWQjCUa/wSJEvI4rFAj7B6uQjR/5K1w7c6Oha9YaEvSamD UQ/Y/iRL/mQTvgKGUtTu2mQBc48wQiW5v4XKhSl+X7Wik50vaNeUesDKZafhrSkAoEpP fEV/4NYh9aJJCLUMETUisdg3t+ExOf67nBi9dChIMTV7HMZx4FheQlqnZjKtqPjSKccH ahkDWWLpXjbBea9DLwrV+gO+fKzzIAKZ0sx5M1d1wj3tl8Grqi1l/CoVDvuNsP/dz9dz ApVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832367; x=1785437167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6s5SzAkwTqv2cG0ZEuCiRJMYbGatFZIR2B9nCnRkYh8=; b=DSFfZIFcr1Xq3Ml6B1vj1p49YK5iJgTY3YzA/QXegvPN0DSckA9sBeYB3UwiWmtiue W7tDYaw4RUxQPulptQyRsS8ipztLImOgEYSZbbWqFssh7jCVqrtHxGAAQc9fQBSvtJYU ummgIEFwJBbswGpocVdir1BcehFyOGj/Xo8N1HWhk9/Tt+O2X5Nr7gJx3i1pcZNO5J7A shgLjjWh9B6QhyipUAoBKvVvfiejstjiKkU4rlbv0I4saMZchZiXig+NEA72c4tDSrBp PC8PFmJtqllsuhV51JbWsLPNww37v2XCmRFzd1PIXwYXFT31M+iSMtQqcKumki03Q2CF LsXQ== X-Forwarded-Encrypted: i=1; AHgh+RphJ4w/y7cGYmpHWIjmHWabo/P04hH9impceDfarQFeCZjJMoPAtG/9F9DxsuZv7ZPbSA8bPHhHXTZam+s=@vger.kernel.org X-Gm-Message-State: AOJu0YyOL3eLVeWqu4/6P9I4c4AkFmn7doY42WwdZs7m2hrrXIPv4ir1 euishsiV8RbCpU4ZpAG/xbgvk2j/MCmD5gs9WZix6Rfsv1z7Ot1tqr38 X-Gm-Gg: AR+sD12Bj8axguvIWPMZK66vTLdx5iAU2ltqWP7SpUSiTwO/m2sBbV0bejgvJeFKg+W D4L7okG6gMcL3IR+x2hPDhiz+6VoAHLA3HRN5enN7eSig7pzLlLkD1cmIpkZxL/JsmenJuqPqdH /h06nhMUKPtuQZjbAuG88AjVd1C3dKtkkm0x/vIIRKM4beATTQNpPO8mQy7/bH/e/+6U/nvO5LO tRds1rmZvElo+N6elsa99SNZSUeK8a41/tkhOK4XfYdRJdQ0c6y/KlVZW0HmI7VZuNOh9S3cORP 09DKxUHhKrh8ItoJZUSHqEJ2pjGYh49QIg63FojB4eaF0nGYte4OwE3M4wrtSbc/LUqo7rx+/b6 WgPqFnXOTzBr8NPDLqeNvTevLmJaHFtATaLNoLnJUHOemjhmxPNHbWwG9UXHhgVN9QjuWiAzb X-Received: by 2002:a17:90b:4b92:b0:37c:18e0:90dc with SMTP id 98e67ed59e1d1-38ec697d294mr3808455a91.16.1784832367424; Thu, 23 Jul 2026 11:46:07 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:06 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter Cc: cocci@inria.fr, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zhenyu Wang , Zhi Wang Subject: [PATCH 05/36] drm/i915: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:07 +0900 Message-ID: <20260723184538.3888637-6-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +------ drivers/gpu/drm/i915/gvt/gtt.c | 8 ++------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 8a019d3574df..90880be63a1e 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2658,13 +2658,8 @@ static int intel_hdmi_connector_register(struct drm_connector *_connector) { struct intel_connector *connector = to_intel_connector(_connector); - int ret; - ret = intel_connector_register(&connector->base); - if (ret) - return ret; - - return ret; + return intel_connector_register(&connector->base); } static void intel_hdmi_connector_unregister(struct drm_connector *_connector) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 5056a5887b31..6bca40128d99 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c @@ -725,15 +725,11 @@ static int ppgtt_write_protection_handler( { struct intel_vgpu_ppgtt_spt *spt = page_track->priv_data; - int ret; - if (bytes != 4 && bytes != 8) return -EINVAL; - ret = ppgtt_handle_guest_write_page_table_bytes(spt, gpa, data, bytes); - if (ret) - return ret; - return ret; + return ppgtt_handle_guest_write_page_table_bytes(spt, gpa, data, + bytes); } /* Find a spt by guest gfn. */ -- 2.43.0