From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2894D98EF for ; Thu, 23 Jul 2026 18:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; cv=none; b=vBkva6Km/xej0U/3/1GLTL/CAfGE6uX8P6d8IGdN/9KF10X0We/pH+xR6/UUQNOp41q9hLxbl+xOJAgvfNXbcR/bd+ii5zHqpwwun2L3BLrem/xDdKZkp96UMiCMPRcMgR7KloxEU/aNqsAGmNapvXj3Ix0k2boIw2tnOkLI034= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; c=relaxed/simple; bh=/V8mneptUPJ/q4aURKAyvm+FJuT8YJEma4JCKxUZvG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOHCxF0hXN6YZT9U4WLnvm+FGz6dWgx0OYpv9duDauwdI0LW5ZEun4rnSQf/6w6ytzVL687/VQB033mzvxHoTfURCWQBmbeY5dR6fLIQ9G/kB03N43kaKXTEsmd8JeQBZgpqkPE7fSS8XdqmsjxUtB9ltAml2NFOLz0fYfWVbmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccQdTDEO; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccQdTDEO" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso961345a91.2 for ; Thu, 23 Jul 2026 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832372; x=1785437172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lNzFXtDRL36sjfeetYaoRGkJ3BZXJkrvXWbUMZXEOzM=; b=ccQdTDEOdSllfqpdERsORnIZf3clgJc+zXrfBvAEpT8h5Qvih3+SRAwRmncZ5rFcqy zFErylOHtpYudSvl7XFEMLfuf1HsfQOqswC6bPvrcAqPrB0MGYQo9AqVscm0GW0MEf5u ZCC9uKhcFGTh4cH65BdlsAVJ4P3HQ3bXz83Lb/cicG282cdIAa/CUO98vC51MFYKk/PX BkNY/4DlXcbD4LQSfTIrgh9+xDNwo8fmkT8gtbIoOCjplKLX0p48iTA7Pst7ZuaxwMLV fa1FPmRv3iNsIiOBPo7hjcO1s8sifgEGtoubbUCQqntIW/AXf0jVQD/F8Qdt0O2/boQe +wWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832372; x=1785437172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lNzFXtDRL36sjfeetYaoRGkJ3BZXJkrvXWbUMZXEOzM=; b=aSSBuOXGu7vO+BnzsdiJerXygyRuWvHFdNOJYtHsz5VP5W7aQ3gKiWuYTe8vFJ6LM5 TDSgKJWJd4leqQQVzfS4TvN2H8K2IDCorsvuikd3gJgGn7/ffR8Y1D4yZjcbD8khIaSv 3g08rKex3XZ22W1YFhNidolU4wK48nTGORDT15EW+bA4OERqerNPybMqkIKzV9cQ6tZd JCJq78BkiPEC8KA6CWf+sjPgIVzwbmMmwWOv7O1S4wshao71zsqCmmI+uuhF5UmSW2hJ 5QR2tS6TtOn4I3Ga3cPrf8sgKW/my4IN4mvZCpMQdBaa4xMt9v7QS5Qni9RuzOBCMbza AV7g== X-Forwarded-Encrypted: i=1; AHgh+Rp5+mab+DTxs3j6t7SgxQlRy6jM42HUAG/LtohbMksVsWhP4KTz5LvLZruAribgMTbdMg/Iban0QSn3MGk=@vger.kernel.org X-Gm-Message-State: AOJu0YzDKSGGk4chxZN5GRrP5pJIWSPwWAOK2NP3MYnGhUKhfRxauiNv y3rbvR2Dko1bgF0FSY7u+UV3o9ohUh6K74UigIY4CVkTuqJK9ak0TLto X-Gm-Gg: AR+sD11lyEHXwHsqaFyGhK3fdfot+Huh0MqThWhUqPKF2yixfeARVEZQfmLTq/sUms5 PV4KSKDL05jUv0uHC8hCVDSP9tMIzskeHTyKAYMMsEtwm4op+Ui2HJj3/NpvUxa2Fzo0IjBzHF4 2wCltTRohgaGO0nusm31BEtVRvWHN82rQmkNPgfEWzN2a0uOaK9sl5gPn7QOCeaCgunaGVv+AUw 0honOjAOcjH3nfWXInYkzEvEec8QwY5jquxGQNzbSAoCWNM8Vrqwu+kFQW53bHK8OTK24bT3HGW ZNYaVzBqOLkv+UmvXtCyUPQM7tZAKbFQD7ZP7iwRIqzUbThliKX9nRQh3TBr0hPb3OE9kw0u3uC c2Ng5WV2QXVTQaxLcoTCnYPKHXgzpVyeEOG90YRKqUR/poRC1Ucaw+PCgwMfjbIy7YanHK2gp X-Received: by 2002:a17:90b:1d02:b0:38d:dfd1:7c1 with SMTP id 98e67ed59e1d1-38ec6499300mr4568453a91.2.1784832371666; Thu, 23 Jul 2026 11:46:11 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:11 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Lyude Paul , Danilo Krummrich , Neil Armstrong , Jyri Sarha , Tomi Valkeinen Cc: cocci@inria.fr, dri-devel@lists.freedesktop.org, Fabio Estevam , imx@lists.linux.dev, Jessica Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Pengutronix Kernel Team Subject: [PATCH 06/36] drm: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:08 +0900 Message-ID: <20260723184538.3888637-7-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 6 +----- drivers/gpu/drm/nouveau/dispnv50/disp.c | 14 +++++--------- drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 7 +------ drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +----- 4 files changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c index 51a0ec043248..52a2334be799 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c @@ -55,11 +55,7 @@ static int imx_drm_atomic_check(struct drm_device *dev, return ret; /* Assign PRG/PRE channels and check if all constrains are satisfied. */ - ret = ipu_planes_assign_pre(dev, state); - if (ret) - return ret; - - return ret; + return ipu_planes_assign_pre(dev, state); } static const struct drm_mode_config_funcs imx_drm_mode_config_funcs = { diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 364227f5456f..e8fde399acae 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -301,19 +301,15 @@ nv50_dmac_create(struct nouveau_drm *drm, if (ret) return ret; - ret = nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM, - NV_DMA_IN_MEMORY, - &(struct nv_dma_v0) { + return nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM, + NV_DMA_IN_MEMORY, + &(struct nv_dma_v0) { .target = NV_DMA_V0_TARGET_VRAM, .access = NV_DMA_V0_ACCESS_RDWR, .start = 0, .limit = device->info.ram_user - 1, - }, sizeof(struct nv_dma_v0), - &dmac->vram); - if (ret) - return ret; - - return ret; + }, sizeof(struct nv_dma_v0), + &dmac->vram); } /****************************************************************************** diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c index 2334b77f348c..16a02527285e 100644 --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c @@ -58,13 +58,8 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel) static int osd101t2587_panel_enable(struct drm_panel *panel) { struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel); - int ret; - ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi); - if (ret) - return ret; - - return ret; + return mipi_dsi_turn_on_peripheral(osd101t2587->dsi); } static const struct drm_display_mode default_mode_osd101t2587 = { diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 1d6c9a423a41..990805f1fea6 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -64,11 +64,7 @@ static int tilcdc_atomic_check(struct drm_device *dev, * tilcdc ->atomic_check can update ->mode_changed if pixel format * changes, hence will we check modeset changes again. */ - ret = drm_atomic_helper_check_modeset(dev, state); - if (ret) - return ret; - - return ret; + return drm_atomic_helper_check_modeset(dev, state); } static const struct drm_mode_config_funcs mode_config_funcs = { -- 2.43.0