From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D916148A8B7 for ; Thu, 23 Jul 2026 18:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832397; cv=none; b=tXSuA4MUkrB5TaAwqpOLo4XyUC7MJCuMPQZXCXSvJOmZ79P20VdvZYYTRlAtPcFUb1+j64KS2FxPc/vdBR2r8dlwAbChsJXlZZSVq2az4D8xB2vOSTzOckv5MQeLTAfhGtpLPbFc6gISKbyP+Wj+mpIJ0krspLgVb/QYLK6OWNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832397; c=relaxed/simple; bh=pXLTAUkjCgRFuHbdlrm9wPCFAoCGzZnJNnZvsbZon1Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4o9NWEuUvGgivzF2fXcvpDYRDEcAKDhoNRAIzOs7tXe+igCllkJIxPW0rRhghsYJNJSKwwe6BrZHV3taHIH3yPFw6SbBoG/3AzEjZgdOPIKecpxQXPdiPNIU8FY5LI7tX5Rg6mZQyW4nlPuzja458BhnB4PtgzauABddcKfDW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I2SybAu/; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I2SybAu/" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38dcbade417so1041261a91.1 for ; Thu, 23 Jul 2026 11:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832379; x=1785437179; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mTuJvAzG5mLe5AUB4aEimify+WXcEx2MLUBwrRB2paE=; b=I2SybAu/NbDXH3Ob+ZOTehOR3mWbaldDLvt3AnuUFR0g+clbZiHDKZ6XWlIb1aEfup g9YEjPIQProUmTUm86KaLeJjNIdrB/v17gdBA7wRsqu+nx7dM/gL3W97BAqtkZg9Caka HfOdyq8Bl7JXhGbNolima/104MJD8VXX+8Hu1bT8r6DQmzyNNf74VZSs5oplTgXUoUec /tjZG4cFyY6AhbnT2l55Drdw8f6L2xfmuI/1HmTpdF1v/6VUISBmGokBAiddviP9n/n4 ozG5mxSJc6w16FvPgpg5qw0Ql8jq5J2nJb7G0wu9BRr2EWyY2mvWDRNTpdetldk2obNX nGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832379; x=1785437179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mTuJvAzG5mLe5AUB4aEimify+WXcEx2MLUBwrRB2paE=; b=AI/SRQ+/suRItIjMipFB90Ztd8BtA8BSdh8G+fyWBXR/AxWLmFJE20qfc5Pdo4xYmu yl3RzSWENmc6UP7oAbS8likbMHw3r7XeeAbepVHRo4KhrORE2D/9F5TmApNSYEJf6I// 6tMO6nBrTpHFy8SfEWxtXS6ZHYIrNjSvoiU/hwva9YcbuyAbGLem7ETI0IXAahfi/HNq tA/oDcDRlh6K57as2zQDgewMei9hJrn8C2/twh7nUCr0v4Pjv5sVCu4HDKxkJWywVGJK tAM8NAHbSqCZxmsrdDDG4EBL0nYApKl6eVgATaL/1tfIDKUXsj635NqJatg7bis7qMG5 IIPQ== X-Forwarded-Encrypted: i=1; AHgh+RqyV6mO9eXZ4L4uPAxQlknCYD5OrHftbJ0wi2M3rVsTMN5g7t1Vg0c8N9oiXla6okot6IEkiws2JIWwLnA=@vger.kernel.org X-Gm-Message-State: AOJu0YzoTmrptDpbYuiMgWZA94eBMXxRN7zA1cqAjCANIzQjn6v8z42v zvPY2wpTsgwf2o3D2pBqU2+hvYy/gjDMSVHNcAZH2V77WBuNB8Jyi5Kv5l8fPCGlZik= X-Gm-Gg: AR+sD13XDEPFPvT+RuMNGzywIxvxjHgAcvvBOyTUuC5WLC/WV3CBJiIOdopncVPMHEf vLXwY+2WynLjqHzjjQiCaV5M4XFlvkRfVZeqjT4N4VV4ZuF/g1HD1KX0OsdSSVDN2aBNzLlxMpa JghFC3BproZrf6yrr78+SYruYwWAgmr0cOm650fYaQBN07kG84XxIAWlpJ0ZiHlOLSiL1LUybbq ovNMxTJs8hwSl0FWaxzc0ohg00PsIobTKEsLSbasfnVbSDd/vOr+iy+jKF+V2hK0/TaHzOpImGL VJVqzIByLCcaawRHrjooYv4lnfeZl+YaaOIb5saOeboJOMu4omhU8ESRnWDT41GHQobQyFi304Y i8ElJsMsHLaU2uERvVH4PDvq2G/FrgO5L+tsAyqUVdGF71/zilbAh5ryy7ZvSChxVz8135bZg X-Received: by 2002:a17:90b:50:b0:37e:a09:2640 with SMTP id 98e67ed59e1d1-38ec64958fcmr4523372a91.7.1784832379247; Thu, 23 Jul 2026 11:46:19 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:18 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Arun Ramadoss , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , Kory Maincent Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , UNGLinuxDriver@microchip.com Subject: [PATCH 08/36] net: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:10 +0900 Message-ID: <20260723184538.3888637-9-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/net/phy/microchip_t1.c | 6 +----- drivers/net/pse-pd/tps23881.c | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index 62b36a318100..3292b2235c8f 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -1028,11 +1028,7 @@ static int lan87xx_read_status(struct phy_device *phydev) if (rc < 0) return rc; - rc = genphy_read_status_fixed(phydev); - if (rc < 0) - return rc; - - return rc; + return genphy_read_status_fixed(phydev); } static int lan87xx_config_aneg(struct phy_device *phydev) diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c index 49d6389da067..8a3bbd623412 100644 --- a/drivers/net/pse-pd/tps23881.c +++ b/drivers/net/pse-pd/tps23881.c @@ -1520,11 +1520,7 @@ static int tps23881_i2c_probe(struct i2c_client *client) "failed to register PSE controller\n"); } - ret = tps23881_setup_irq(priv, client->irq); - if (ret) - return ret; - - return ret; + return tps23881_setup_irq(priv, client->irq); } static const struct i2c_device_id tps23881_id[] = { -- 2.43.0