From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2980933E37A for ; Thu, 23 Jul 2026 20:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784838974; cv=none; b=gU9G9Vvj3LbdWVrMOify/1RYU5AfA9WQ+tUqGECMGLyXOe7Uulwo0x0oSjLrOiFu3zffPZA/jOczlmf+Llyy5/8v9FggPGm7/+lFtyYCO5m6PMmImr1x/thqel94fRGH6TsbIRyoWics/LFdV6iOW4jPJIOxNMU7yUzsoeTsZgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784838974; c=relaxed/simple; bh=SWocx1zV+cyb7BRIUwblLWB3TOFqoHLH0eZrzF7gFiM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XMH0+g5XTKm8vlyzmwAy8NcRMa/FWYw2F3h/g57qSKIa1sGExlJlU711AsnFBVOV1R5axS8XqrX+d0GMT2VbW207AtW5XMGcmZMbsYXKIIeJxZ9vPlkybY4+P38+TvOaNg9MgajjMpVJCebO6Uwdc/Vt888BO6OKKY3QBTbtZtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j00RILez; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j00RILez" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-495635a85d2so9239275e9.0 for ; Thu, 23 Jul 2026 13:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784838968; x=1785443768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=j00RILezY/+iZMU3Rrt4eBou9jfvvMn9V/+G1QghpNTeHzIzBAEQQde50h1YHI8oIy XVt/ZkaI2KvlQ03v4kvIVUgRt1Pjz35lG+RM1dkBFOiOyMNFmPfjiXFi27V6zyyXriyY UV4oPj5sQLg242vdyff6K41/UFdHJk3t1UEFyp2dnGJf6Xzi13brJMICFx75/O/cAPmV X7H3R7NeV7WwXG0sV2xrjGXpnm4wP2j4IqOaodPeH9TWRTikzBybNEtKDEAAbFc+weu3 LdSVz4Pu+bdbMToUgGGeJBzWNm32lf8qAfKo0sv6jiBAn+ej2ox40Q+uY7DwDJXGpeS0 7dHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784838968; x=1785443768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=NxjXrh4uoRrvNO7xpccNBonOUCK+d55zNKI+hHl98IaGa3TttjoUDUMtdWKcuzseaq kZR6NT25tHEXmbFRFJAERfyg3LiOSIy/FsLI2cerVSbSwGZE/ewvitFxxkBXcKrqWCIz xhcp5RjgR4d77wB8lplYoNqLhXfwkf/t6tLVORJLz29ioiN45rCFsEd/5QGpVr4KXDSX hi+v+YPLHFPEDOD7tCQb2MAePPKS4JGw3z9dY/6SfwidcRRCuxsFzdWu7pTK/fuOgHGU wKje3apwuZ+uvcr6TKpeOHZOWZNu1PXHAA0K6SBMuDwY7PTgaS+AZw3WblXRkM/Z8ayT ZYmA== X-Forwarded-Encrypted: i=1; AHgh+RrqkH1XHEkcsvx5iAS5HXX3kF7gTuz65RPKvZi6xzJpSgjBleSwJByyr3AliHWePrNUUyquYuWcL19nWUw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+W5VE5yxNvTyxgpKS85xzB3V6iK87OiVvpRplCy2wyvx0Kk4s g9+gKXpx/Eb1mlbX2aQ76n6K6QYC+jIRo4fAe3wN03byUJKD5pvZCJSd X-Gm-Gg: AR+sD13Zf31FHKbRdcsgh64091esgS7JhMB5adGJLRu4Sbr9E+J2sWsGwv85UNUmWHv 2OPzv9HAeq3TAcOnQxIhng7tjzhStX75S7e3wwJTbYua5mb+zx+/MGhHePoq4yZHYm7y0sV7Ag3 M02aMt+NFhV5hGm5ipnlwf5VkG1RhAahtQzcCoEpBeIAIdtD7w8jBdWWEi8nAgzOtCA01GN17PM Uv84xbGoRbZp7wIpNRyA9nmPTFQg5mRyi7Vg9JSdcUq1OIEfVPLY1Z5f6sYVn4Fgg06pCNIKiD8 tBGI+PJsvy06tyCRh3T8WQy/NPnhH7pKWDEONUThvmJTJ6PPxlEa3HrtiFPknNdVnlgJXe0yGN0 Ia+xlO47fMmcuM3udA8WQ/H0jvzaYKT/3ya6GXXfNtrGkJu4DwLB9N1hThRLMQT4WXDevq3xXFC DEfwChh/6BGZjISDcop3QpTeRZsIMQUgTNhgjqMdfi3waVmXqp X-Received: by 2002:a05:600c:4ec8:b0:495:4aff:5fdf with SMTP id 5b1f17b1804b1-49573d0cb53mr49825425e9.28.1784838968069; Thu, 23 Jul 2026 13:36:08 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957af78a02sm15384335e9.7.2026.07.23.13.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 13:36:07 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v4 1/3] drm/panel: ilitek-ili9805: Use _multi variants Date: Thu, 23 Jul 2026 23:35:59 +0300 Message-ID: <20260723203601.806697-2-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723203601.806697-1-michail.tatas@gmail.com> References: <20260723203601.806697-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file. The multi variant of these functions include improved error handling. Signed-off-by: Michail Tatas Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c index e6c483851f1f..7e9587afebbe 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) static int ili9805_activate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int i, ret; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; + int i; for (i = 0; i < ctx->desc->init_length; i++) { const struct ili9805_instr *instr = &ctx->desc->init[i]; - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); - if (ret < 0) - return ret; + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); if (instr->delay > 0) - msleep(instr->delay); - } - - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); - return ret; + mipi_dsi_msleep(&dsi_ctx, instr->delay); } - usleep_range(5000, 6000); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to set display ON (%d)\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } static int ili9805_prepare(struct drm_panel *panel) @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) static int ili9805_deactivate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int ret; - - ret = mipi_dsi_dcs_set_display_off(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display OFF (%d)\n", ret); - return ret; - } + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; - usleep_range(5000, 10000); - - ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - return 0; + return dsi_ctx.accum_err; } static int ili9805_unprepare(struct drm_panel *panel) -- 2.43.0