From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DEA04823D6 for ; Thu, 23 Jul 2026 20:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839400; cv=none; b=A4F9fVoNMgusvDAs68Jlnw81hjdHfMXhswAGD8PwWfACNlPADJEEUJ0+PwXbZqF/NUiG9bsysdr2WNqL7NEMrGSlVAVY/B+feYWaX6yVMxKV/A6d9h0RFpFyu9oisEcbG3KNi/+w9/LzKSSEKbqk1I/0OsedopaB4qBO1no31ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839400; c=relaxed/simple; bh=5VbqgoxnpZ25+DAS/Bu8wOeDLmqQ+TGKyYgc7R7RYZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KE+pKe0WrNZifTL2JLqn9QegAQKWwXnw/GYUeoztuPWeGD0dZ1tB41UByV+VEIZCpwuPG+sDpwEQjvvc48ApNRnOpbTiknGUe0wq/z7D8fMOS35re96gjj4wQEAXFAr75YCUlurkq5CFSHWhZkfnHfw/DMvMCP6JTwPdXHzaPB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meshstor.io; spf=pass smtp.mailfrom=meshstor.io; dkim=pass (2048-bit key) header.d=meshstor.io header.i=@meshstor.io header.b=pWUtozAa; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meshstor.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meshstor.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meshstor.io header.i=@meshstor.io header.b="pWUtozAa" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso7501035e9.0 for ; Thu, 23 Jul 2026 13:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meshstor.io; s=google; t=1784839391; x=1785444191; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LVDrwHOShpJST2v1XpPaKOLt9RN1zMUNY9kPyJb4mps=; b=pWUtozAaJSTecCwJDXbOMORoINDMoqgo9Qoopb+fRZGbZ+1dCa8zKImQRbnzXgwtS0 4bxSTGZ+KB3kbLh8dqXEI6NqPkrJ7dpV3qr0Uhy9JLv6EOyCFQ0M7hmPKIX5uGzEwLJu WAjRRQS3RtP+TuPh9cC6966bVDVMFSZoQpJk/xLxg7RN7MSzwL9Xz3zp4XNk5qxbTPVa Ij7eQdCt2J9dRmBSjFvR0XePkWBYixyUSYzKKC3gd3hdtkBHQgGXcsohxJs9UXrqalVi bZytFv3qu5xQpBMWwy/WkbvtM7H6Yoe0LOjSNcckFsOaOnNOdz7TS0TrRWgJa7+N9MT9 8NkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784839391; x=1785444191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LVDrwHOShpJST2v1XpPaKOLt9RN1zMUNY9kPyJb4mps=; b=MejpkDpUXahv0vg9kmvqCH7G70wdVEnD4kaxNksdG4Xm271u+izslvX0kIy0YHdDg0 pkwCLLJhYQoTQnlMJnMH/Aerw5UbDqKWmXSJQsDW9h8Y+hM109gQQnRLNmIH4wcknEXT tbHHMV9xMVsBRkzF5brpue1kmLSpN4omFIQrFR4guk7FuRpQwCIiEr41U4pCM7EzU7pA GOvUH8TmwbTSquCZsovHP+lxX+iSLWWGz/tL/48rD1A9E2qTEpUnvvgskNIOUL4XWYzH TCUiAUrVfQCk3EO489twddyGi8Mp6Lullcson4DTZY+NW28DVnkrvAkZ2feJ3PQFvvM5 FVcw== X-Forwarded-Encrypted: i=1; AHgh+RqqIoHxcsA0jbiuAfQAHEFALfLjBwYWz74JaWb10emW13QmxVR3rbGA5DdAz6d7dOIuzMGNLA379dia45E=@vger.kernel.org X-Gm-Message-State: AOJu0YxvPaM4wwgYIpONBPNFcwe/Ziwr4ih62M1NVDDm6Bvd2/k2vynD C1RZ6frZtQCzzbdn/PlUWLl0f8a/DyS5SsP0wh3telJu7eLPjBk3cw9FDF2GmViI4g== X-Gm-Gg: AR+sD1234OytxjS80CCsTAewMezST/hAtFK847ezRBJ0X3ake/8SgerrU2tTNgK5qqJ d86ri0bgvM+v6PrLreIiFN0LxlRf2bc/w8b8UST0FeVSkJ6Nq7q01I+4omUqp6a7ElgLLlmUD9g +rAT5RbtNPFa4l6XasrcpDQtfGMNETLbOxVeDxDSyvYEGntIssSW8/rcF4LPVP5fMiLDrQH7uAd daEiZB9fF/HDnFV+dQiqybytFcXL5a7AgvTR0g1S8oWlLosrIvtZj720CuoRBSMTqMRDoRkAX3t mc0FQt/BkkZZ3qxj3MTtB8lVOPVXrlJO0BiSu3TlJAZypfetJn690MEwd0GHDaAIQOx/RAgu1TP A3RbMaj5iyQj1iXcJdQ0YYyqYosivavrN2500jrutof1FVClgpC/p2daJ4VWOYdYYtgZf4rwwy6 +ASGLxobkTgv1bEK5wjKtIYynOsPVO3Wx4rLPyrw5xyQrC/qmY2GTKMm6U2qAhKgp/FqdRtPO4n MRSX4084ctFMb9rD/wj45Kyro2QSGScewuhbJloKw== X-Received: by 2002:a05:600c:6a07:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-49573c8d700mr36854855e9.8.1784839390786; Thu, 23 Jul 2026 13:43:10 -0700 (PDT) Received: from meshstor-pc ([185.87.42.56]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c52fc0sm18268192f8f.23.2026.07.23.13.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 13:43:10 -0700 (PDT) From: Mykola Marzhan To: Jens Axboe , Song Liu , Yu Kuai , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Li Nan , Xiao Ni , Guoqing Jiang , Leon Romanovsky , Jason Gunthorpe , Kiran Kumar Modukuri , Chaitanya Kulkarni , Logan Gunthorpe , Bjorn Helgaas , Shivaji Kant , Pranjal Shrivastava , Henrique Carvalho , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v5 08/10] md/raid1,raid10: set IO_BLOCKED in case of BLK_STS_P2PDMA Date: Thu, 23 Jul 2026 22:42:04 +0200 Message-ID: <20260723204206.76930-9-mykola@meshstor.io> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260723204206.76930-1-mykola@meshstor.io> References: <20260723204206.76930-1-mykola@meshstor.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A read that fails with BLK_STS_P2PDMA cannot succeed against that member, so mark the leg IO_BLOCKED and let the retry redirect elsewhere. Skip the read-error machinery: there is nothing on the medium to fix, fix_read_error()'s probe reads into host pages and would "succeed", and charging the read-error budget would evict a healthy member under a P2P read workload. FailFast eviction is skipped for the same reason -- the request never reached the wire. Fixes: 02666132403a ("md: propagate BLK_FEAT_PCI_P2PDMA from member devices to RAID device") Assisted-by: Claude:claude-fable-5 Co-developed-by: Logan Gunthorpe Signed-off-by: Logan Gunthorpe Signed-off-by: Mykola Marzhan --- drivers/md/raid1.c | 4 +++- drivers/md/raid10.c | 7 ++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 83ebf40237d5..16a47568679f 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2657,6 +2657,8 @@ static void handle_read_error(struct r1conf *conf, struct r1bio *r1_bio) { struct md_rdev *rdev = conf->mirrors[r1_bio->read_disk].rdev; struct bio *bio = r1_bio->bios[r1_bio->read_disk]; + /* evaluate before the bio_put() below */ + blk_status_t status = bio->bi_status; struct mddev *mddev = conf->mddev; sector_t sector; @@ -2674,7 +2676,7 @@ static void handle_read_error(struct r1conf *conf, struct r1bio *r1_bio) * read error. This is all done synchronously while the array is * frozen. */ - if (mddev->ro) { + if (mddev->ro || status == BLK_STS_P2PDMA) { r1_bio->bios[r1_bio->read_disk] = IO_BLOCKED; } else if (test_bit(FailFast, &rdev->flags)) { md_error(mddev, rdev); diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 77c7d8a59916..462f622556ed 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -2847,7 +2847,9 @@ static void narrow_write_error(struct r10bio *r10_bio, int i) static void handle_read_error(struct mddev *mddev, struct r10bio *r10_bio) { int slot = r10_bio->read_slot; - struct bio *bio; + struct bio *bio = r10_bio->devs[slot].bio; + /* evaluate before the bio_put() below */ + blk_status_t status = bio->bi_status; struct r10conf *conf = mddev->private; struct md_rdev *rdev = r10_bio->devs[slot].rdev; @@ -2859,11 +2861,10 @@ static void handle_read_error(struct mddev *mddev, struct r10bio *r10_bio) * This is all done synchronously while the array is * frozen. */ - bio = r10_bio->devs[slot].bio; bio_put(bio); r10_bio->devs[slot].bio = NULL; - if (mddev->ro) + if (mddev->ro || status == BLK_STS_P2PDMA) r10_bio->devs[slot].bio = IO_BLOCKED; else if (!test_bit(FailFast, &rdev->flags)) { freeze_array(conf, 1); -- 2.52.0