From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
linux@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] iio: adc: ad4080: add backend data size configuration
Date: Thu, 23 Jul 2026 23:55:57 +0100 [thread overview]
Message-ID: <20260723235557.59e283c6@jic23-huawei> (raw)
In-Reply-To: <20260713084043.10856-1-antoniu.miclaus@analog.com>
On Mon, 13 Jul 2026 11:40:41 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> The AD408X AXI core can pack sample data on the bus using different word
> widths (20-bit, 16-bit and 14-bit), selected through the packet format
> field of the CNTRL_3 register. Until now this was left at its default,
> which only matched the AD4080 20-bit resolution.
>
> This series exposes the packet format through a new data_size_set backend
> operation and has the ad4080 driver program it during channel setup based
> on the channel resolution, so the bus packing always matches the device
> realbits.
>
> Patch 1 adds the data_size_set operation to the adi-axi-adc backend.
> Patch 2 calls iio_backend_data_size_set() from the ad4080 channel setup.
>
> Link: https://analogdevicesinc.github.io/hdl/library/axi_ad408x/index.html
Hi Antoniu
B4 noticed you'd missed David's tag for this version. So all worked out
fine in the end but please make sure to carry those forward.
I've applied this to the fixes-togreg branch of iio.git.
Thanks
Jonathan
>
> Changes since v1:
> - Patch 2: expand the commit message to describe which parts were
> affected by the wrong packet format, and added a Fixes tag.
>
> Antoniu Miclaus (2):
> iio: adc: adi-axi-adc: add data size support for AD408X backend
> iio: adc: ad4080: configure backend data size
>
> drivers/iio/adc/ad4080.c | 5 +++++
> drivers/iio/adc/adi-axi-adc.c | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
prev parent reply other threads:[~2026-07-23 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:40 Antoniu Miclaus
2026-07-13 8:40 ` [PATCH v2 1/2] iio: adc: adi-axi-adc: add data size support for AD408X backend Antoniu Miclaus
2026-07-13 8:40 ` [PATCH v2 2/2] iio: adc: ad4080: configure backend data size Antoniu Miclaus
2026-07-23 22:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723235557.59e283c6@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®