From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2BCC3F9F32 for ; Fri, 24 Jul 2026 09:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884168; cv=none; b=uECgNFnJvPZN2AU8YPrrrW1QktNCrFoHSYMR5tVum9BWMHz+zHjc6benMhuhypfFX0GxpyYPzlQy3GS7PrTiH6u7gT33w2TKpklt/ex5SPdI0ju2zdETSlLeyin/dSnVlME036ZkGpFUF8iGOevgn7VAOQAHbUMOXi4ThEzgDpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884168; c=relaxed/simple; bh=zSsQTGU3yBodb3nqyOJi46T+bw48KjoVmqMOtg0C99M=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=C0ARJABb4mhtOfV1/quEYf6W5rZZ/JoVSGlpydhjtPPwqx5skvz/vaSZ+C1pNYDlXQqPZvQnu52aO+SYFxqtVAVySAb70G08lxt3+NVe6Em/kroJq8+kwyx+fz9T1TdmYwfEbswcinoKgrXF6u0sqBoUgHyKM3+htCRIaCrAiCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YewQwwuW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KwsHIvfj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YewQwwuW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KwsHIvfj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4m2Qe2099816 for ; Fri, 24 Jul 2026 09:09:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=RFJcZaDEe4JHD73fI4XNB5 eSQ+x00a0vAOBqLtx2CUA=; b=YewQwwuWzvP7xpEMMOzGyqPWi7BwQ/zRJTDuh9 WrmBihcWpxaEjMTpJELc1m/7/LIbeT4BI1Rrp+402I5pvfVGBvpqCyZU1YK/bmQw OILxk/yOWjZ/76Q8rO2lWuyofxMMzgEP9eVBVOtnwb4qXd+iDZAgVk7L7TX+1ZMh Qpa82sQ4IWvKmxBPlaqLgzErzpc5Md84UHHbRFGPN5LMvPmSxPNlmVrvuubiKsmd x8oKhxeiFucDfyJDSzn7a00x2ZCoiQPc4cbK7WpKlzwm25pybUH3e9jqiTY80YzI 2ijetQsjwbcFHYMbdDYMexjDdIvhwBI51RodUbuZPIFWFkvg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fktaht79u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:24 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so415086a12.3 for ; Fri, 24 Jul 2026 02:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884163; x=1785488963; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=RFJcZaDEe4JHD73fI4XNB5eSQ+x00a0vAOBqLtx2CUA=; b=KwsHIvfjQt1myMaSKun2MdkOWetLBxfJCU/01QrpOUVJI8POPEOqTLmHnZQ38elCOV zkMcJl/+pOQoSPIjCkktKXn0AiJMsq+sAvAjUxd6vFwaN7hYX/umqd5XvRqtWICKrwj9 ttpWutZNQk5OwAdqmZMmCvvEfNP162MaK44PDeHL02oMZrsDsDQuGi+ocxLQoJYPFUYa xdthhFIrttU1m4YQvfPBoT5dpHs/HQwITd3dtf2uEP82wSYJin14mBCuf/Rf6/Kyw6v3 cxcMTGimLopmRmkZVfVMow6jjKTLwKDbZGc/ajBQGSxwqHt/j/spcqsqgAfbZvMDejBH +Cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884163; x=1785488963; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RFJcZaDEe4JHD73fI4XNB5eSQ+x00a0vAOBqLtx2CUA=; b=LxTagpj3SaHDKj0r3VJtt8678FVrTDUp8krTMux2NKqQbHADBEruCyJrk2wrXAoZ76 nv75+kGPBhOvxFQluq+Hw31eWerZCLXCPWvibge9SpNdB+G9LXhZEdcbnARsZ5EqcJ2Y a84aofnM+OJ/jLBYC3QLz9BAikCeumwoWmRtUwXJry2Vjev5DLRoRHsC9WB731CglsoP dwRRreV1n51q1RFmuj9PbbCuY6sV+Qa3e3Bn9AF4uN9BJFZ9L44VO/b1CezfI6OadQrh lHbdJIHHH45aEmNbxwunkvkrxJQQcmeyatwlwDYYOtXAPklDP1Pr9MpztC/Rx4PHt45L Ho0A== X-Forwarded-Encrypted: i=1; AHgh+RqCyat+HYWnzsGve8pMHPHIsGbI9ID0YLOlma9A9CQ20L9pw3b0uQeyylr+2ZjJ74SKfkGT4i7e6cLFchk=@vger.kernel.org X-Gm-Message-State: AOJu0YzozFGv7xNxa+akmzX9TxUPwoQtODCRg5GcnEFzNmXFwZ5wtlVT Pwkaakp4XryGgVUdofUoadmRGioWYy9hdrt0ZCp3Z5vKHZ16z/7DfuXQnN8NqrbI5H7rnGb+Xae URmUdez7pMsYeoJs47/LHPZwcjXYmYay9lO8h+nbjpNnC8eiotyv9NA4SUG+rCHCYpGk6gDWI0z 8= X-Gm-Gg: AR+sD11kM5G6m2ogmgOFPismHsWOa3H/gmXs2UITz452DyW+o44pnKBR7BkTtxIrsp1 IoVRM44U9COqlG/oRzzQGU1cNMTblMCAlOGn3XW3OvqT1HyA13TyNO9JzqhNbJ56/kC5qv3ySwK DhgZqFHXOf5QBzlgRqXDamWcpZmSL25PN3qKpJqlapQ6mgpAx71B84nAGVogJlyOaSU1sqMXiKv 7HjVGiEoaG4WhuDfMcKN7k35qUtKXLme4rAsj52L1ArPaxjKWQL/U4KhCnsMyB0aFRuOTJGFM6k oDtPtK3UYjaWguLG62wXFW19tqZpk/0sKd5Dy/7TFdueO1Ms2Z7at55VHJ5S+subHahrlDZR/7r nG2HRURun85jOewLl7/ydGyQS+z83gtc= X-Received: by 2002:a05:6a21:3383:b0:3bf:983d:e9b4 with SMTP id adf61e73a8af0-3c44b05d00dmr8034943637.33.1784884163467; Fri, 24 Jul 2026 02:09:23 -0700 (PDT) X-Received: by 2002:a05:6a21:3383:b0:3bf:983d:e9b4 with SMTP id adf61e73a8af0-3c44b05d00dmr8034899637.33.1784884163003; Fri, 24 Jul 2026 02:09:23 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:22 -0700 (PDT) From: Sachin Kumar Garg Subject: [PATCH v5 0/3] media: qcom: iris: add multi slice support Date: Fri, 24 Jul 2026 14:38:56 +0530 Message-Id: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAKgrY2oC/3XO3YrCMBAF4FeRXG8k/2m82vcQkTROtgOtcZNad pG+u6kgK9i9GTgX851zIwUyQiG7zY1kmLBgOtegPzYkdP78BRRPNRPBhGGWG4oZy3G49iMeS48 BqDbKisZ6p40k9e2SIeLPg9wfao45DXTsMvg/SInmHZo45dSJIIU13EEbP1Mp2++r70Mahm09C 99hGVP+fQyexFLy3GZXSEEZdVqzlkdopWvfyWXiJF8cwVccWR1/CoZ701iw8I+jXh254qjqKB2 ZlxFsDGvOPM93wUqww5YBAAA= X-Change-ID: 20260716-iris_multi_slice-5647287a9563 To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=4567; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=zSsQTGU3yBodb3nqyOJi46T+bw48KjoVmqMOtg0C99M=; b=T5VDqpRsmHoVA4l4hjQTZjJrm9cq922wNPrUryrycDO+B08Wm6ooGCKku3ndNwKF3orkJ2P2k qyNOtqrvbOGDrCl2lI0tVfDIDQBaLc4gL9pYHomIM5aOWNuTs+a3Pas X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX6xuYXw2Ks91z QKMEC+nvUb0Bt+zjaY2QJj/LVlgkoDK2JNaXcEUzR7b8c1y7jw4Ynimqg/Cb9Q+mhKm3jTICD+E u3DxFyd4zHS3Jef2+Fdes6zPPYljKfM= X-Authority-Analysis: v=2.4 cv=TvrWQjXh c=1 sm=1 tr=0 ts=6a632bc4 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7Z090XU5ozNHmVG9x8gA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: msAdk5I05Gp5ygnjFnMb6Tce4J_st395 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX2OXiIKMIB679 zcVgLS8/+46xVOGn8KBTEsZQcZgczK3f9e0WFsDcZ1WJAYpZjNUI6adnV0MspcZp6PNTNiLZTco 0OnyfpRUlTR0C1xrjbGQXE2reZT6OxLDX4zARa7IBO+HejdxrTuTHZDuSeuxb2ziXRUZAlAoDQp cYzi4w9+cr0jCtlkjSFlw91+8EHfnr6tdJ10GYLKuPbXtFSjKTMelqiGdwPydbTFi3ZbiNuiwj6 xXeB+EX0Ls/DIDNriOTVKd2uDu3ghDoNXsWIPAmYSXRYTNeLr+Wnd3Z6A8sUjGObDSvic+BK0dH E+n76a8BvARmp6u5sf4qDgmdxm267JoATV/mNpEYU6SAT0u9vc1TkAZh0t0yJamHePyi4Ue4MKh 1rhTuFlXGO93FuLpxQuC6qizq0JpoZ/cSQI8+b32BEhidz1nwuyca/wVk+Dnu+LJI86IwaOTJTU RjPfujiVIybKi9WcDPA== X-Proofpoint-ORIG-GUID: msAdk5I05Gp5ygnjFnMb6Tce4J_st395 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 This series adds support for multi-slice encoding in the Qualcomm Iris driver. Multi-slice mode allows encoding a single frame into multiple slices, which can improve error resilience and enable parallel processing. The feature supports two slice modes: - MAX_MB mode: slices are created based on macroblock count, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB - MAX_BYTES mode: slices are created based on byte size, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES Clients can enable slice mode using the V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control. Patch 1 is a prerequisite fix: iris_set_stage() computes a work_mode but never caches it back into inst->fw_caps[STAGE].value, leaving buffer-size and clock-frequency calculations based on a stale value. Patch 2 is another prerequisite fix: iris_set_stage() currently always selects STAGE_2 work mode for encoder sessions, but CBR rate control requires STAGE_1. This is fixed by forcing STAGE_1 when BITRATE_MODE is set to CBR. Patch 3 adds the multi-slice support itself for Iris HFI Gen2 based targets (qcs8300, sm8550 and other SM8550-derived targets). Support for HFI Gen1 targets will be added in a follow-up series. This series has been verified with GST level testing. Command used: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12, \ width=1280,height=720,framerate=30/1 ! v4l2h264enc output-io-mode=4 | capture-io-mode=4 extra-controls="controls,video_bitrate_mode=1, \ slice_partitioning_method=1,number_of_mbs_in_a_slice=460;" \ ! filesink location=/opt/test_enc.h264 Changes in v5: - Fixed unbounded slice count under RC_OFF in iris_set_slice_count() for the MAX_BYTES use case. - Addressed remaining coding-style review comments. - Link to v4: https://lore.kernel.org/r/20260723-iris_multi_slice-v4-0-45f0a3fe7fce@oss.qualcomm.com Changes in v4: - Split out a new prerequisite patch (patch 1) to cache the computed work_mode into inst->fw_caps[STAGE].value in iris_set_stage(), since this fixes a pre-existing bug independent of the CBR change and needed its own Fixes tag. - Deduplicated the per-target slice capability limits that were previously repeated identically across platform_inst_cap_qcs8300 and platform_inst_cap_sm8550. Introduced struct platform_inst_slice_caps and moved it to iris_platform_data (one level up from platform_inst_caps), since all Iris HFI Gen2 targets share the same encoder capability table and hence the same slice limits; a single default_slice_caps_vpu3x instance is now referenced by all Gen2 platforms. - Link to v3: https://lore.kernel.org/r/20260721-iris_multi_slice-v3-0-adc61a687e7e@oss.qualcomm.com Changes in v3: - Patch 1 (force stage 1 work mode for CBR RC): cache the computed work_mode into inst->fw_caps[STAGE].value so buffer-size and clock-frequency calculations stay consistent with what is actually configured on firmware. - Patch 2 (multi-slice support): - Use inst->hfi_rc_type instead of the raw V4L2 BITRATE_MODE value when validating/deriving slice parameters, avoiding a mismatch between V4L2 and firmware rate-control enums. - Round up (instead of truncate) when computing the minimum MAX_MB and MAX_BYTES slice size floors, so the hardware's max-slices-per-frame limit is never exceeded. Changes in v2: - Added a prerequisite patch to force STAGE_1 work mode for CBR rate control on the encoder, required for multi-slice encoding to work correctly. - Addressed review comments on the multi-slice patch (updated commit subject and description). Signed-off-by: Sachin Kumar Garg --- Sachin Kumar Garg (3): media: iris: cache work mode after computing it in iris_set_stage media: iris: force stage 1 work mode for CBR RC on encoder media: iris: add support for multi_slice in iris encoder drivers/media/platform/qcom/iris/iris_ctrls.c | 91 ++++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 33 +++++++- .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 16 ++++ .../media/platform/qcom/iris/iris_platform_vpu3x.c | 17 ++++ 6 files changed, 159 insertions(+), 1 deletion(-) --- base-commit: 42f83a32259a82c4481d3cccf560c3bfeb32c892 change-id: 20260716-iris_multi_slice-5647287a9563 Best regards, -- Sachin Kumar Garg