From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5B03DFC80 for ; Fri, 24 Jul 2026 09:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884171; cv=none; b=emLTB3SJyRkbyOjtXyUNZoNqNniYhW3eaI0alTvXS17go4fN40yt0UtbnrayEvQk0Nbrs/iQZQV077PH4yKH2huFeW+k+d1WBl58h81EhWpe8qG7xNjut09uI1EKk72dVnWbi4+HBE3XmEaSqcXVUaT68d5Z4prkDVgg4GBwNJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884171; c=relaxed/simple; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XH8YptWz+YV4rgRoR5RHP3zyCGHE4hR74oicIfKPeU3MvWlD8NCEl+IgmKWj9xQv53Huc4um72QXwAifiymuxgvygCdD/cxgi6U5iQOdEPqxcccrn1tQmHrkePOn6+A2DRiHq0Nbc8s2ma27cOMBFvn+LQPHMj9fUvwrgG1//vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B0IoIC6l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BBEZYlIn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B0IoIC6l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BBEZYlIn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4smuM1897512 for ; Fri, 24 Jul 2026 09:09:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=B0IoIC6lgEhlhw60 Xnw+SEktqDWDKXlxpBR8PwZ5mhrK1S6/VuS9CDOll1S67Gu4DbvkzAi/o2NFGbvf /ED63SaaRzsFbfa+osJ+S8VfbDvOfBJpVySihohr1tvyBnqMpfU3U1Lt+h5Yusnm Fo3azfJ0TP0VFIMPwGpyjtmmvswSXWkjz4xErEPt86Il585e3mR0AHuPWDJSYrjP LDFh8mSKercQuBE5ODhNvAlFeZKw8uHE2V9PFklJHUEXJH88+uS4in28o9yjyFk5 IkNqtMRzf+DrEPxMXFd5m2cCcjevnPslN00kfTbwbLuyQ7GFtZCSyFpcKjOEIWpr WlJvHw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm1em8v7n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:28 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cc7e86e7c5so4695365ad.3 for ; Fri, 24 Jul 2026 02:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884168; x=1785488968; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=BBEZYlIngEzspFiZdEXLpF+YxtN+YsLjWclKWlGk3KEezQf04icVL/DPgBiYMUZeLB WQWbzfrm/VWMcFLiVB9VArYLUVW9fLUsDQYepaQXN4+G8UfPktMA3w8z8G88rhIrg3ev gzdYhUzGgqJoNg5EiCGCeQDNYmhoY3+I5t8rTGDU7n/VQsw/JWqNM04X44Zx89PPauNp +XekOZQBt98N8DET+ybW3/l8T+4jTD79fx21nBLGxLY5fwj5S6zrPv1QRVX6e+DZQOVv TIchdhKd5blNUleb2W6CQqBJaYDuM3DcQnKBmZ8sBLlZWHiyU7wR2BZ3i7dhZ3HIqFbu n5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884168; x=1785488968; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=gVxKIDKvzZCAbualgVx1LY+AFJGG/famgbqHxa+5xb455oUAItiP9W6R5h5TQp9599 lfd2ZS6Q6qafeSyYVRf6YAFulI7er0qutF+2yGYMfdrdZc98uygr1NFr8bSdq33A/hh7 xlJzLT7v7/mmEP3ovFi05l0ZyaIlIJ+hvAEdafVz2INBBKbpQtHzZKqZHrBkH26JoSJo IOges0BS7AxXPt6vEb/0zKqbR+t85/Yff36sGwIb6QFyQg+IUZF7DizF9UGjATNjsMJH u2Ae4oj9woL21bThI3YyroEUnrxX+Ku39+8Q+2ZGSvTWUsth+fn7oSSU33zvqlBVx2bq G8dQ== X-Forwarded-Encrypted: i=1; AHgh+Rppa5YRsxjHbDZ9q4LR9bxmQ1XUSUaSlDUiUyWxSqSFb0jDpuH1bywRwzxik3wEMOI46LJ6Kzf8WfcyNeY=@vger.kernel.org X-Gm-Message-State: AOJu0YyyEdQINdii94tGZK3n57k3TS1KTaE9DD0UGCVFtlDT6WXFoIVG wMeRFdh3/y5rQjBEgaM67ZhE01uD4nMXFD5950NhoQNkN/cuC+XSOgJWqzOSVvwMIfMtZU+UTFl Z0+hNQAAMM8WD/i0yM/q5nYkAOPagvfdPjtW55VSNRdsFz/RuYogDEB69DZ4bwKQaKjrfYVqKxN 4= X-Gm-Gg: AR+sD103z772m9Hk6PifIuh30rHlV/XxC73uPSp2q0/o8MvYSfofN/ySSc2PQj/tFa7 fBq+nmelIXbKe/nc1NMmrxWrXP/mkp4Dxc4ZrxBUap2U8y8KiYmvgHqRJtiKL7XpEzOBKMUxlxR qhrO34F7clPQ+mEviyCnHFVLjutHHhKZYup/rEoBfZBm23dEhWdG4J1LjgGZnqOEs1fjMVFax4t oCbeYukmdZ50WlLbkwjexLOodmB6qIsaq3P8ZaFrcoNfZUeYf1x7IgM8MrX2FJTArrnWbbzq+ar XQonrtssHmVQ1higNBS3jXENrXJChuXkpeBAMfzMFe0FaBZmUduL+dLQPT8kNgff6JLIG4Js8r8 ygu/WNAhgMLPCuM+qAg5GVZsjDIYVreE= X-Received: by 2002:a17:902:ecc4:b0:2cc:9473:97c8 with SMTP id d9443c01a7336-2cfa6b7dbbemr74746625ad.15.1784884168127; Fri, 24 Jul 2026 02:09:28 -0700 (PDT) X-Received: by 2002:a17:902:ecc4:b0:2cc:9473:97c8 with SMTP id d9443c01a7336-2cfa6b7dbbemr74746225ad.15.1784884167706; Fri, 24 Jul 2026 02:09:27 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:27 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 14:38:57 +0530 Subject: [PATCH v5 1/3] media: iris: cache work mode after computing it in iris_set_stage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-iris_multi_slice-v5-1-4fb593d29b44@oss.qualcomm.com> References: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=1459; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; b=paK2wn9a4zqJTDaD8uutynnzBibpF639fws5USR7tyf4j3CuICrhETPTaAIUgaAzLue2jH2iT 3EbOlJocLp4Ckrj37ucYxxCAL/xHdRyCT0jD87qmlo6i1bzt5Hs1iBM X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX6FDUjZF2L4WA 1ETl7vc/li+PfC2sM2OTjQYC3Zeo6UaacjZSL5gDnZk69zM34IHUpQzJi3QCOObCM77FCc+O5Rc bWeBlLIUc/93DY830s8Eg+3WKYmVhCE= X-Authority-Analysis: v=2.4 cv=BIODalQG c=1 sm=1 tr=0 ts=6a632bc8 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=DQE9uWRhMQBL0dtU3VIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 0Aq3muZMEh4OKiJ1pCkMSUBxUDxqr00e X-Proofpoint-GUID: 0Aq3muZMEh4OKiJ1pCkMSUBxUDxqr00e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfXxhwtDXkYRvI4 PZSzxrxRiSumuAiq1ozGdFMvrfEBaKn5RwoM7mf344MiVOeRrUxoohgISs3RbE7PCjrIvPiQ4Ur ncof062yDgvHs2GoTg3xaiuhzyCZWiCF6Y8dUjUnhiUEcGpVV1NLGPb7LtEVyAgpt9tGlKAZbHR zm7gsNC5228CzWuj05xWrPFuCue6ZSFlSaAJkfBsi7cQFE/79nSMdumtNrlZVVZrI2sn85Uva8T yN03Zt3PnW8e500AnmWkRhRElQ/+NbWFQ8fcpjNRTwIV//wRLBotwQVzwURSFurKftbXO8zMo72 XwX7G9PugSWKCbmv99KYj7cxZyrRsVJG4P64ZXmsCbEGtqgCPjAMHip0+rJc5OFYzuiX7r07cvt gpAVHxUAZf9nfuFqvyTbDbccwx6vJCCv/FDdg2ZsrkIc4xAM/p4QEWqw8OBNNJPVqrXp6ppgl42 imirnsjMVg9Lb0IlpnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 iris_set_stage() computes work_mode and sends it to firmware but never updates inst->fw_caps[STAGE].value, leaving the cached STAGE value stale. iris_vpu_enc_bin_size() and iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a stale default causes them to miscalculate buffer size and clock frequency for sessions actually running in a different stage than the cached one. Update inst->fw_caps[cap_id].value with the computed work_mode before sending it to firmware, keeping the cache consistent with what is actually configured. Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 10e33b8a73f6..58d195d2ab87 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -521,6 +521,8 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id work_mode = STAGE_1; } + inst->fw_caps[cap_id].value = work_mode; + return hfi_ops->session_set_property(inst, hfi_id, HFI_HOST_FLAGS_NONE, iris_get_port_info(inst, cap_id), -- 2.34.1