From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97AC23FA5FC for ; Fri, 24 Jul 2026 09:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884178; cv=none; b=mPQd8FMhhAYTKameyLEP+khwL35zOlwS0iy35ZHvAsGSns8cSyMRMJ2PftbWqhP003Dh7YpUxNTmykbkdkLiYF55L30lTUoos0vTrR3L8geEY/L7461GzIzZ+6Ht2sdyLnsluqBTUZ5kfe9YqcDrRFR0EbI/+/mqU5edpEpNDks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884178; c=relaxed/simple; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YX7DfZprcnxVCq9ljbOR3Wqb5tz0OPqfNa9iYJe+PfFFBR4HvVqlaC5Y5233jY1YJvKHmsdcjXCnrsDF1vATatmXwmVSngFmQg8MgpkUt1gF5AzXwGTDeDhVnczlkEzE/hj+txA2iGyb8lhnB2P6J+pKOyn5qgm5F5gvfC+dJMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=odxVt0rC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RnBnWmFS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="odxVt0rC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RnBnWmFS" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4lD5Q2275940 for ; Fri, 24 Jul 2026 09:09:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=odxVt0rC9XiA6XLj U0BPseDfJUzEWM5ryKsqnOPDGr91/PBDwpZH5ryJ9b8l5IrZmXwoFiWGJAono3vu 2IGTnuYTIAB1ctE3FZndxMMM+RwSHmGcy86WeDMdPE7H1NLEoLxWrq9rKoHsdKmR S+YzEIUkCLBgxinyXMafreCNYWKu2ioZ41QXgpoOynS4e5ReMCh137yWBLPKxXYd rxHMlwrGhEB8yWBxaO3/FpUvca0W0GaKT9iD4aMRDylFya0B2WHqxzU9VDq/7OkV SmvBYl4l/EyWroNp9QvPAmNu1xcIS/zw2oJe9W8nT5yi7zaxo9dzsDDr0ggyHTko JNCvgg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkqa0b0c0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:33 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cf1c86963bso14153015ad.0 for ; Fri, 24 Jul 2026 02:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884173; x=1785488973; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=RnBnWmFShwyP4I7wNiJLVmPHru75QBG0/P5O3Ccadp/m4IFijCak0A7iIvMGcEp3LP v/ITL3M2nrsRgB1Y4EUccrVYw8drIfgUQD5fyAxvWAQQrcG9iKmcAVxcqBSV+D9PTS9p /kmnpfkoixlj0jeuposqHvCMWCznlKbAYoK/otvSwKqjINs2r2fN+JztNuNB843PSpIs PZOr3JwJvHFDtwULJWt4ilDmYe0RsJmAyy4MOYtqCwSaUP/6R4CB81fNDOIsCUnJsRoI wahsErcnUuX5ZAVqJQ4aqUYfGKd1B/qpDIN6O88IWSXsK3b+/X8LvKfglDt2vfCphqIR psEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884173; x=1785488973; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=aXEhbQNWQVVX1wGuVJvYkwrKQmjVLXBavUKvjQcAl98yNuIlfu7SoNClHrMAi2gjNq /jV8HWnLhJtttFBZTpTlvfOttrd1NZ5zF29mASMaSYHCDSw4aj4/vicAykRv7Q6zMjti IvTT7gWPl/WPRIWkWZFtOh5dDtSA6Bo8KABvHjrLTOPw2STsP3LjFI4X5g7/f1LZW2YA kdA010gpnW72QZQOCWX9+l4hKi83L7jttC7T82d8zdjX+vGHzFDBXwBAkPiAmB11sETT P0h9x2kjuo+XIVsB5pNukZX7UY9SXn71f+KG4fKHlEaRZjlnISVDVslh2TIcmYMQM+KS RyLA== X-Forwarded-Encrypted: i=1; AHgh+RoEQ/VWvZA0M0ACgNTAbciQ+BhEc4DVx/HQB9TyzYNFzspO1ZAHMMxgngcrKtf/xKAEjJxBa5TMlBcBMLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxBaVRcB/hYP3tsMCN0Ewviz5WMwVTrEvcWE0jVRQI5OpQhaX1t VU21AaiZNLU4ady+O5SH6CZ8XznJRuQCTLSX/SnTc/jDHe+GJG3yaqKCKVnu25dqK6o8BxYtxPD fg6xXecFtrSaorkataYKaWNRE22LbbfvOVSxVNqFoW0rsD8b+7mg9fEbXaN+C+n5oXKbvGBHJcA E= X-Gm-Gg: AR+sD12/tlbMZprHhbaAxguFi32ELx+Cr3tfrvwgCvpa6noRn7eyHpSPMye6Y+HU1TW FHuYWohkE5Fnjfc+3KUJdHaaZPXgdnRg5eOW0RND0cdifgG16rvYdYFGl3NiuAn2Z4UJetoi4UH 4pG9hQr96esrmTP1ythSFUBIoI51b+Re1Fcd5lFOYIj+UNChRFSB2Pd2Al7TDMlAlgeyqTw0FBe K0LPF+1/vG2vTsGTOFR7U3wVC9fUCgCdkkLsv2tiTspX/Pvg3EcmmFfxpqqAq8+mC07WRySdKsi SRaczAwtHsLwyX2ydHLqU7lvBf6cDEcPmJLlWMzXKCgsN6N3gF0g+ADFsuUrc3qbTQz8iKoa7xX 43R2394fKoi83vzETBfIBgukS/FiqOKg= X-Received: by 2002:a17:903:2306:b0:2c9:994c:9a5 with SMTP id d9443c01a7336-2cfa9588d7emr73332745ad.30.1784884173198; Fri, 24 Jul 2026 02:09:33 -0700 (PDT) X-Received: by 2002:a17:903:2306:b0:2c9:994c:9a5 with SMTP id d9443c01a7336-2cfa9588d7emr73332485ad.30.1784884172772; Fri, 24 Jul 2026 02:09:32 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:32 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 14:38:58 +0530 Subject: [PATCH v5 2/3] media: iris: force stage 1 work mode for CBR RC on encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-iris_multi_slice-v5-2-4fb593d29b44@oss.qualcomm.com> References: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=1399; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; b=Lw02srcT7XO5HNtAvaGhOh3qrJRtqG8UHr/PCbWs9/xeH6CaEsu+nx7z+nuQHY/kCbvzw/Q1T 5Kz1ATrrEJADoOTil2HoErvE1RZ6Mt/4M6m8EEDITQpm2yZhUKgqOBy X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: 07D_-uatrOeYp4tkV3fKN98L0nfqtSdT X-Proofpoint-GUID: 07D_-uatrOeYp4tkV3fKN98L0nfqtSdT X-Authority-Analysis: v=2.4 cv=e/k2j6p/ c=1 sm=1 tr=0 ts=6a632bcd cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=LMK2Ni0dcLaqO0rVonUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX2HEF+5z64nYw DWu3xV4J2Pa2u/dMs0m1nmp8Hqz/4Sd/EZ7cNbFRpJvpb2QulkX2EEbLBSjFXF2PER3f3GAaCvu mkTTewz4/7ia9fYRG22Cr737ykjdQRtxap1eAbuG8ar3sj/NiKcjb7ScsMXySwzWHmgWYbdArmw 0DlEnFacu8q7zO4A2ADg26Y1gTqSn60j7MaaH/E7ZWPnJ5ZEAf6cKXRCq8IUx7ugZ0FGw0M/cZe UM3LKP3cwrO99hDknRMjmm28+Z8fGfSAMj57NdEAW15hdS5uDCEaArNuMqKFUkC2GFqXlmWPnE6 pTFz//IPl5LXb7cQRl587wMm7p/aD3KZ+chosXcdtgQObCBimaMdHdRoKspaIB+LT614Rcsl0Lu /DTQwajOc7m8xp6C0q8mbkZ+3lassE3EuApLafvxhTDpZXFUTZ0oFmEPN1AVBh/SRTSmi1mjsQb ceEHRohEutZfQ6EB5nw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfXyamvX0s05y7D 2ZIdx86dWSp6biEdS9nKSwlASeJa2y1S1o6UDUglQoPd2iDsecWkYVtwPlE8x0xiQ71zUX1V29E I/4WhPUmqCt4GLV8kXVgNl12kMbggbc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 iris_set_stage() currently always picks STAGE_2 for encoder sessions. CBR rate control requires stage 1 operation, so force STAGE_1 when BITRATE_MODE is set to CBR. The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, so iris_set_properties() would still see the previous hfi_rc_type when iris_set_stage() runs during initial config Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 58d195d2ab87..d7cbf6c3614a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -519,6 +519,9 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id if (inst->domain == DECODER) { if (iris_res_is_less_than(width, height, 1280, 720)) work_mode = STAGE_1; + } else if (inst->domain == ENCODER) { + if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) + work_mode = STAGE_1; } inst->fw_caps[cap_id].value = work_mode; -- 2.34.1