From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE053421239 for ; Fri, 24 Jul 2026 10:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889365; cv=none; b=rgcc33B23oSuCS75Rkw4KnhQCBDMv4x7Foe9jTN+ZFH9bqhofPzSMTYwdthqgPUWoRyYKfaoKlR5vkLxEgOeuWjen2W/TDJUZfoQ3H5VD3ixjWFRNoU7qDmGDFq/f2ZYYDrkmVZYrFTW6LK8YIl+wjDmmxrqroQsgxNeTRx6LuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889365; c=relaxed/simple; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RYp45gCf95nuueBSCY44CZbprSDBSXjxJVwCC9PGMc0CcNYQC33pmoN2N7IgLmCIPhKtW5oZMxPJS/Uhjxa/82SfxM3YdT2FOwPuIs38GihrDjW4IRbQucMb0+qFEg+bces08F3xzVo4w0iC3bHY3pKvMUeGCA1+bhl3DoIO2Yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DBwJi0nq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yh/Les1j; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DBwJi0nq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yh/Les1j" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OADrV82742615 for ; Fri, 24 Jul 2026 10:36:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=DBwJi0nq+e0fEKVk HaIPfq9OxPG4QENN1e8F5GYFjFXfwXc0ebC4+7Fr+WXpFtmyUNVtK8EOMAL/Pq/+ IHHth/tl5NeO6WsHzKM8sSVS5P2KNkmlXfk0GgHRz3y27MHvph6ssdvQzjGn/ptr 9nzZ7BZA2zzzfF22V9s3YteVAzah7FLGvp9oI64yT7NpYjrQUzztgIisFraC+0gc YOriQs03jvZ52ODwUmuqx9oPgM3FjIRsXJH6v+lggSA5R/0/e7HeNDbjcO9X/paV 9BxfS4kByt7deyW2lho/Y/uJiGMe8pby0BdhdUi7V1xT3uZHhXusYVBbhCgFtEGs mppKPA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm0p51c9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 10:36:02 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ce8a76df2dso5372645ad.2 for ; Fri, 24 Jul 2026 03:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784889362; x=1785494162; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=Yh/Les1jP2Gk0srBRrmbEoKYTaH3epq0I7UnPhrN4YYQ3Q+CM9KIbGFxlUZnaLXwEs nePYJaKNtT8RUoAf/v37KFe9dJ0f65xore1hVkwLPho6H42j9ZPiqifcXwMsqKIv08fo ffo8dDH4FbOHVlk2B95dfSyDl6A7f2+f+/nG6e2mJ5kStiD8kfI7rb7OOXbMHC0qSucE h5Fz7JFF7H7pnSuccNGCJVkhP4T0oUyI95wZxsM4Gy7fqJrCFNBM90iK7viy3bAp0DWP xfYsHZylfgebN98wi/6xmKfa6QsaFttOznEd1fSC9QtNWuoDpmIyXJGUbMTgQpfiCEgy ba5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784889362; x=1785494162; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=NSbr6UPtPR1C/WsC+jsCyq42hYdcJsTqE1rTB2TWGteT3oN5ffIG7YDQwV8pThUscU tiCkx/S6SySSxtRhhORhL0vL59BF8QKKhuYnDICKo/Tud2zScQv2Tei/N1QjFCDFYjWZ w/cEifbpwGCVsq67OXSgyhALgum/V4JN6/rpBYETXx1u13xv2OnGatJIDPnV1hI7tUB2 MpQaqfUkDpzdPCi4Q3ByV72rfu6dm7oMemm5y7ClS7FM16GHS0ckdbSctV8rjriEymaK RHc0+WDtvUjsR9CgccHCuHP1QbRHE8o+vUGaXYd1qshPBeM5J4ISjQqDvayGIzJ0RwJq judA== X-Forwarded-Encrypted: i=1; AHgh+RqsUaVC7QPJtZcWg26EHaf4unL+E7vbtKC0Mh0QtHLdwdAjWGKimz1MGQ4LI0KMuM7mvPk2cb/ZHEmv9nA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4WPeunoaYWe1RJvwPbe9/Ydt5gOYyVUfpiiNP4Nvvl7L6eZpN ckqREQx49Mcx/5IRSyM2xQL6ZzMlHFfc9ZNiKzvlRXwHYPLPHOPdG/bBuf3kwS6qFUVkr78O7CB 1nv9MZuhUzXqjPXSahvIaQGuFmerA7aEI9GFdqVZm43mAk6d0x+lbLyDGvdxlLku0kJg= X-Gm-Gg: AR+sD12Yacbk2x0HK9ReEn79d0ZtKH6z1DPkQGEN0rsnO5TUm87Sv1JVueMsOzKvaQI xLoqGzOfWdH3vemLzkRhXJz1rA6twdrF6kFEguXc7c6Lsr/cbcVyd7GDdT20QhQvtbocEWweaXf fsw1kpUqZqvkyTaQ12spOHfQvI3guErUSPQrvuQwRNB/cRjgW9NVmTLXCrTBQS1LA7Ai8e9vRkg LnL1Oe3SkiHVmBwzYLXTcwTK+d80uETK7XrrVnCMKJTj+Ji8IgbthjfbzhaQTa2wSNNVDAkM3OS 9ydHJOh2/5MKx2/EdH6gRYVcKTzdQ7i1+2bwTYQPLtLKTTpkSaFMU9vWjVy8x/FRBItVb5Ic/Sl LZ9JK6xS4+JkJzh0sw6E250YG+PM8lRw= X-Received: by 2002:a17:90b:4c0e:b0:38e:8050:e63a with SMTP id 98e67ed59e1d1-38ec648af5bmr6238216a91.6.1784889361643; Fri, 24 Jul 2026 03:36:01 -0700 (PDT) X-Received: by 2002:a17:90b:4c0e:b0:38e:8050:e63a with SMTP id 98e67ed59e1d1-38ec648af5bmr6238187a91.6.1784889361209; Fri, 24 Jul 2026 03:36:01 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03b0e976sm1228657a91.5.2026.07.24.03.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 03:36:00 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 16:05:50 +0530 Subject: [PATCH v6 1/3] media: iris: cache work mode after computing it in iris_set_stage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-iris_multi_slice-v6-1-a99d160cb42a@oss.qualcomm.com> References: <20260724-iris_multi_slice-v6-0-a99d160cb42a@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v6-0-a99d160cb42a@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784889352; l=1459; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; b=VNRdqHUXVV/dn2bCzZkN2nv6+aQrFjmZYsgSIns/bCndJwNxmoTNXQkA3NtNbFLHK7StokB5H mlXIesa53ItBNQ8JDZLK5fbGV+GtisLtZY3jETf0QolifEpCG92flq8 X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Authority-Analysis: v=2.4 cv=Pq6jqQM3 c=1 sm=1 tr=0 ts=6a634012 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=DQE9uWRhMQBL0dtU3VIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: bziuj732REJwrvg6PAcrRLH8PDwBgh2V X-Proofpoint-ORIG-GUID: bziuj732REJwrvg6PAcrRLH8PDwBgh2V X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA5NiBTYWx0ZWRfX2DCLji7po0Fy /M5qiXNL2ducDPMwbRcfihgG/6lj0/jRBeSXd3/2e2oOnEnGh8yl9QZJE6wyOjKmbm7XrptFeya mSALNzFXzxJrj2jJ8dKHmGsmlstpFhs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA5NiBTYWx0ZWRfXykkOUBdwRTMq 1PQwPzRNjVqolJKKQWNSeFtzgaQrx4ONrpoNfS8g3kkuvNi+aaM38E8/A+8I9Y45raeUqgsa+4D 4a9QUPOpZD8DitMl6CB349lToWnefQFDcnTludQxjbfloMlCwfCIRE+CK4VXVTnAjrbPrn2OC1w 06cz3pu0cYkUxE5xS4YcxeEEpvVDkP3nlvPiMkjoOXWzv12dSbm62XTacsvDjowe3j59vjUsOSJ +N9Swc5LGiNy8kcPcHc5NC9tl2FhUhxt4SVCaq2krlnx951Y0ZB1OYi5VHDKpJ3r41+ZPZPGg/o Wp12PaXptO410xQsU/NphP4pmi2zPvMBk0EeWWyAFQ8eOD26hwP0hjxs73yVVCmgQzXY5tT2vjT n0DaqjsctvNMPhN6zjfDC7rohht3imcch/6FCxcnQu7j4kfGmLL1k0VJmkQ2Ir0ZoHMX5qdyVjp XtJgnKsGfVdTur/BkKg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_02,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240096 iris_set_stage() computes work_mode and sends it to firmware but never updates inst->fw_caps[STAGE].value, leaving the cached STAGE value stale. iris_vpu_enc_bin_size() and iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a stale default causes them to miscalculate buffer size and clock frequency for sessions actually running in a different stage than the cached one. Update inst->fw_caps[cap_id].value with the computed work_mode before sending it to firmware, keeping the cache consistent with what is actually configured. Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 10e33b8a73f6..58d195d2ab87 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -521,6 +521,8 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id work_mode = STAGE_1; } + inst->fw_caps[cap_id].value = work_mode; + return hfi_ops->session_set_property(inst, hfi_id, HFI_HOST_FLAGS_NONE, iris_get_port_info(inst, cap_id), -- 2.34.1