From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05391424D73 for ; Fri, 24 Jul 2026 10:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889369; cv=none; b=uOG+QFvnIVsfTHm8Pm5Aoo4TVJo3iBHivEdv41pu5sV5DQNG+TKrQSasd3OU+v7kqHtASRG0yHMyOTBkEqVy5IYAe4u8IQer8nXWT94pHB/QV3tmUsVAKoMRDsZifXvwV5zCV18dX9HkIu8SeLGxEVABps98fJZWjqxxJYVuHKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889369; c=relaxed/simple; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nWihpp+8tXGgOeZ9xCh7zKN7rj8ZOAW4UgjC3w6IOKFYRUnZEvmGgNoTd2f1pMnM00MEkPS/zkExzOLgxVxXjPGg+KdrAfRloKhxdZ7CbFF23TOX44ezARMZzUfJLSmJS93JUt0W6bK3R2cR2FYx8srCDvHBHQ3lC8m56Up+bGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fKtvT5Yz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iDhZ/1kc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fKtvT5Yz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iDhZ/1kc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OADxSh2917051 for ; Fri, 24 Jul 2026 10:36:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=fKtvT5YzyjkVJW0f sGgMI3kkwGtP7hzyiBnE30SLJ0RpWFdGj6fI91spwbbQN3cGaN0wCJWdvciI7a3o ZQJFoKU0i/xnR+xhhshIFy+2x3UeKpX7cS3M0MKHzztd3FSveW6t6HFlZBDJ033X WJPQE37MuIr5pxStxOBI4OSVXialdCcD18kawiM1ueRim5+Fm3GdDJf4Wm3whG2w rFU2H7SXDyoJ9FN+zgwBDfe+PxdR9rXBvIF7AHZLjbrmInw1bH6UsM4hV3mLZ37V Gls2ilvGUMoldZW51dbXPmMbunCQG4HDr9HdxwCYWW+RBbdb9ftGVGUfU/EqGaBy LleecQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkp5vks1k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 10:36:06 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e7b87ce77so604249a91.0 for ; Fri, 24 Jul 2026 03:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784889366; x=1785494166; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=iDhZ/1kcfNBFQhkqhZW2m6A/HQEJL6XKgybOSLcg0Wl18AzBzf2xbXBrQxgIQuuTK+ V3FCY3GSPVhoHHfqFseOHLT4swYUKhqJkJOGILzT+q3S86R1Pn34Ovqh81GwHdK1T5zS TO2QhfMw7StCgkSjR+swvfR0HSmnHjn1gv3lu/DN2ZRpOx1sfxzdnWpg/UgJ2WCivWNQ lUblw+X1wTcBtjfmgxHEfFsb5+xv+UEtWWc0lwGddLn1/HuscPr+cv7WxMJQwPfkXg3c tdAZzuU4OIyueIrAhN/sK0ZkmEACxfbi+z2sJqZjSnyH+vNLVakFd64CB0ww4QqIMH3X pmLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784889366; x=1785494166; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=VhdwxOrjM33QT+Fe6l4uPAwFUXrhHIKZ1EtcABqI0n1nNRZj4G9TTR2t61QmPdsUno I/jVItAsKOKS9Q5jv3eMhQLQ7O6ewadcUU7FOQ9ZmhyFbqxb0aIDsB9VRLbdtO1jlKkk bh6uOJD+cPyzuyVM+jmET+fQh3Rgn/giMD5IO1KvuoEQ/5iYbqn4+HlNWpqClrSFVvPv MzUI93XpjBgF7Enzm2B7wbgdIrs1up4eF9dZWJ87Pw/WigG5/VTFy+i0jLWdFff0GLVW gotqa51DVLUzJCLbEGxFiraa6JNQo5mZxCt2gufs7LDkrTpK1SkWlKYv7Is0AFLSYoxM Hj9Q== X-Forwarded-Encrypted: i=1; AHgh+Ro6s6xycv9Al0VL2HuOnVNilKQdlNKMirdZ4KQvHJ3wbkLE0nCwKq49843n3ocpl09KpEvl1HZm5WPXfb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9INOuJeRvL0ovu+l+6C5QJQLk2Wdg9RSNui3tsrsy2aTFXXHD vfS2r95s4QPfCYe/qtu6JoqgD7lumPvifz26gigC7qqXrtnIo7jCTnJM7GLacAkO3d3MbobWSum MiOD1f+3PaS7Ikl6OcJCIouXa8sdTKYko2zkzR8bfhhM4jZmWFFhmjiTRk4zJHQYCIu8= X-Gm-Gg: AR+sD133FnmgRniTOfwLS3/z0iZM7L5GJeAO/51bkMH4lY6eNEf2yfxIx70IuSEwJHX quF6F0hWvmYeG5zkFxvMGE9Q7zWeJ6UzbxSs9xTGWwUUdyvUD/0U9J7fDlFJCvJ6IfphLQWfdoc tOAhB+VcLTrYJ40OqcyomAvDqd9soO/PakhrwnLDR21Or7BqMcNhAAiwCqUs839Jj6YNIF5cbAw ZDBaN4gBZ3ns140MuKNT9T/yp+5Z0OovenEHZP9TENkLjdSc1tGV6bqqTZgetgP9stumVjoynVH QjYl/AeTQiFhIctaJxD81E5esw1TTb9eNhEHN/pjMz5HwWIizw6aTlA7Zf8fLM4/Zeo1SKFpRl1 eIbJpOKyw6pnLs2WZ8SY6BIb/s3bPs38= X-Received: by 2002:a17:90b:2b44:b0:38e:2f21:3bb5 with SMTP id 98e67ed59e1d1-38ec66594e6mr7039765a91.21.1784889365963; Fri, 24 Jul 2026 03:36:05 -0700 (PDT) X-Received: by 2002:a17:90b:2b44:b0:38e:2f21:3bb5 with SMTP id 98e67ed59e1d1-38ec66594e6mr7039751a91.21.1784889365635; Fri, 24 Jul 2026 03:36:05 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03b0e976sm1228657a91.5.2026.07.24.03.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 03:36:05 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 16:05:51 +0530 Subject: [PATCH v6 2/3] media: iris: force stage 1 work mode for CBR RC on encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-iris_multi_slice-v6-2-a99d160cb42a@oss.qualcomm.com> References: <20260724-iris_multi_slice-v6-0-a99d160cb42a@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v6-0-a99d160cb42a@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784889352; l=1399; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; b=a+jfX+gHztN/XVjFY2OVsYTMHJNU4SfNw5F/lLT5W6oI8fhZIo686bkoOrhvRVYGmsD45O6Q4 OZPjRcVsqGXC6aXttqtFVUBWp3x1h/KAigzaXLEGLTFiwEoHGvSPbJH X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA5NiBTYWx0ZWRfX0ROpmFE0RHr8 YgLnLTrbwkQtWq1WyInZSa1SPx4dlmi70P+0hBnhx++g2XLaYCXPLlQUeYnj6tYeJPbobsU9gf2 LU4+jRxRsq2dvQjkd41W8loWEMBJDrI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA5NiBTYWx0ZWRfX/4VqGQBA2zTY QnfTJYV4Dv+3LrtWbv6Tx6UONhAnjTdsV0jkHVXTjzq5mzziVVGH2lw0hljfwEyNjJJEQXYd99x svObhbifuSASzwSOml51dj5k3asUaWNZ1CoDiO1y+9Gnw7Wz3o/QdXF0WGf9zMAJ0IQmnvufVfs TbEs7GMq+s2Fg1g8grdVPWimVYhpIveKRQIbWFSGBXxZOHGmfRosD+6XVN9OElXpOXPoPbBZ9R2 Yf7klqNDYWbO2HBmsjqzjLUFVQUg4S67EzNquy2W4STR7NaCyV5QG+uuK/Y83BH+d0TycNubDY8 z1cbPVK1qMLZGqQQEIzwxWtjY9Vn1S1QTQB2BilYf8NL3st2LyPB53bb2v2wvpgA6o+cGmNdJyC 5VE/4OpeTdaFEiSvPVXlPSdpqjmPRrSs5Fg1PxLRHIPKfyMDAmlmTHk+Hkj0VGMclBBASAoj2X3 AtuXJGOczd7fOQPkBSA== X-Authority-Analysis: v=2.4 cv=Z9Dc2nRA c=1 sm=1 tr=0 ts=6a634016 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=LMK2Ni0dcLaqO0rVonUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: z6g0g-wuOYemus1v_QI83RSUFtNA3CKs X-Proofpoint-ORIG-GUID: z6g0g-wuOYemus1v_QI83RSUFtNA3CKs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_02,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240096 iris_set_stage() currently always picks STAGE_2 for encoder sessions. CBR rate control requires stage 1 operation, so force STAGE_1 when BITRATE_MODE is set to CBR. The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, so iris_set_properties() would still see the previous hfi_rc_type when iris_set_stage() runs during initial config Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 58d195d2ab87..d7cbf6c3614a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -519,6 +519,9 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id if (inst->domain == DECODER) { if (iris_res_is_less_than(width, height, 1280, 720)) work_mode = STAGE_1; + } else if (inst->domain == ENCODER) { + if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) + work_mode = STAGE_1; } inst->fw_caps[cap_id].value = work_mode; -- 2.34.1