From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974B9480947 for ; Fri, 24 Jul 2026 23:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784936782; cv=none; b=plBPebSKipTtWYbDJ3himkBntyRnMdFXLSrlKh9v77/sczrCyGD1jt6XPsVj5tYMKOfS6j5Ef5K3ntrZ7pG1/lzPq9/Ldat0hlfICjOYF/lxwagOiIqyzmY2HdtEH+cc82QfgDpaF0n6pX8DWQ6V3DHtVoxXKlF9DZt9B5D8I40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784936782; c=relaxed/simple; bh=HYodwXLgKJemsWjlWqYe0putlTEDSsZ3W5gad2+sPq0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=cF9kVk2UNOm0h+IM6xZTioA9P+Nj8+GYSlT9zB0pWY/YSIaoF2ImCTiNr7OFLwNa6vyIKynD5oYn3Tf7IHCDJDN3gpOC4C1eVhfz0oO2JLjbNwKkZy8ToEP0/dg9R7sZIWZlixEBInq8QumGy7tiyMrhA7EDmd2l7MPkLG7/m+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SmvRRaK/; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SmvRRaK/" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-51c08df8513so7449461cf.3 for ; Fri, 24 Jul 2026 16:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784936779; x=1785541579; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gI8goOI5GAfMgkrajbg39zO5GSoNhCTqBmbPaqQ9j9c=; b=SmvRRaK/28GqU1kbroWC7koNm0HmCD0ipEE2afH8MCbr/poSF7EhNIkWpRKMP1tH+y HXwXl2667mWvJi8Php0l6Spe9xZ9jfJo7HE57Ac3MruzigfYJ5TNgthyzNpemYE1mQbh SWT9irzi0a0ZEhCEmO0RqqnWMbPPJYycw7ATG0ZR2Avqc832fq0OPf4rKnJD4WXB0gdB JdHrEy8JP6geisyrNomuGpcvevWzgaV+4hUVtuITqWr4kNUHCBUXPYfgABp8vvhJDjNy 8YeaAMnDkxztuu2r+RB1SYUmTf/nd8CfWG1IuF6ucqcOHj0eWJU+wH5aTbXxKLfCNg8d EJvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784936779; x=1785541579; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gI8goOI5GAfMgkrajbg39zO5GSoNhCTqBmbPaqQ9j9c=; b=foL49+hIIgdcG6HukaITMqOZ1d8U9FqEFW7hERF/+gxhFH2tH0RoaF7L2+hW1zvhbQ jhBqrMhr6Q1+ObUJq0W1uYFmN2Rg0hM90Pd1LD8/CcIPFUb/CzxuS5pTxhqQO9AcE+Qc 3j8AEByGYLYjjmQsQad44xAmheFRMUOAI3NPcNRSQ/BY7Pbnnz39Scmbwcgcru6MN6Gt QSd6MoMuHu7bzh6Kai8qF4JydVDlZBHaJf9nvJXw5APdkd3iWkZ7f17gH5FianGOATcr yTOKQ4iPBu4nW9p+pDf6xiUKiPYnNbF8lV7y8QxtkBiI3Gi5f0tgwKY6MNqL9hbSCaJr WFWQ== X-Forwarded-Encrypted: i=1; AHgh+RrK27RVZnefbUoz/QhqGz55GhXBghWz39dzG9bttFg0CMsLxiQiPoD9jrQaD91ABXYrwfvBfv/zkm67UOI=@vger.kernel.org X-Gm-Message-State: AOJu0YzkFwHd4X8mzfGpTJMDoZ83XjW1LXbzDSR5tAaaP3G7i61MzelO X1uhXiaQFbnKeRmW0A9qfEWfJ1XSUXq1/fv2chjcKEU6C1EgTJgNHOIR X-Gm-Gg: AR+sD1288BXATfyhEVno7Nh39JhL2cuzvzaLUzvrou4PqGolXe7W3UjkRMzfMXclM8q YDGU43/9hS34QKqmU77PA18iYy1EZTiCAbZUvZTVR6NPyv7coirX+vSxS99/pAfwWn3sf4w/Jyf m0W5zRzETzMOokAi5dcLpGtb+wRwo8DyzU8BEH237Lhcdh1GgG3fvUi/WGPHgNEcTLBTVrhpZK2 5Uhl8o3M5cGuxuptNObZKurJS2je9OMdl8quX3pIUGzpGp2dlPlL7I2TVClfIRPwU12v2Mj5Jde aFUMJG4Q+NcA7kjzoJkLJBs8nn5w4Zk8MA9GV3QHET1QFqHgfBCyDjvInEn7bXsRhvbq1P8xKdi 9W669Grcb6pHU5H1emFXUo7mu2V0fdDIXg1BZcuPJtAOSWRnoDJOcyMWChEqUj1dDMMozYdB2Sq EDGHU= X-Received: by 2002:ac8:5e4b:0:b0:528:583:a6c6 with SMTP id d75a77b69052e-529a8382417mr5322591cf.6.1784936779469; Fri, 24 Jul 2026 16:46:19 -0700 (PDT) Received: from [172.17.0.2] ([138.28.231.64]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907e871ef16sm8957836d6.48.2026.07.24.16.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 16:46:19 -0700 (PDT) From: Yuanshen Cao Date: Fri, 24 Jul 2026 23:46:01 +0000 Subject: [PATCH] iio: light: tsl2772: fix ALS calibscale readback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260724-tsl2772-calibscale-fix-v1-1-00a7789f4deb@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yWMQQqDQAxFryJZNzAGdUqvIl1ojBoRKxNbBPHup u3mw/vw3gEmScXgkR2Q5KOmr8Uhv2XAY7MMgto5AwWqQqQCN5spRkJuZm3NV7DXHQNzQWV+78q eweU1id+/cP38s73bSXj71uA8L1pvVj16AAAA X-Change-ID: 20260724-tsl2772-calibscale-fix-0cc42518d5fc To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Yuanshen Cao X-Mailer: b4 0.15.2 The read_raw() implementation uses IIO_LIGHT to distinguish between the ambient light and proximity channels when handling IIO_CHAN_INFO_CALIBSCALE. However, the ALS channel is registered as IIO_INTENSITY, while write_raw() correctly writes to IIO_INTENSITY. As a result, reading in_intensity0_calibscale incorrectly returns the proximity gain instead of the ALS gain. This causes the following user-visible behavior: - Writing in_intensity0_calibscale appears to have no effect because the readback reports the proximity gain. - Writing in_proximity0_calibscale causes both in_proximity0_calibscale and in_intensity0_calibscale to report the same value. Fix this by checking for IIO_INTENSITY in read_raw(), matching the channel definition and the existing write_raw() implementation. Signed-off-by: Yuanshen Cao --- drivers/iio/light/tsl2772.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c index 244f44379c36..2287585711c6 100644 --- a/drivers/iio/light/tsl2772.c +++ b/drivers/iio/light/tsl2772.c @@ -1274,7 +1274,7 @@ static int tsl2772_read_raw(struct iio_dev *indio_dev, } break; case IIO_CHAN_INFO_CALIBSCALE: - if (chan->type == IIO_LIGHT) + if (chan->type == IIO_INTENSITY) *val = tsl2772_als_gain[chip->settings.als_gain]; else *val = tsl2772_prox_gain[chip->settings.prox_gain]; --- base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f change-id: 20260724-tsl2772-calibscale-fix-0cc42518d5fc Best regards, -- Yuanshen Cao