From: Fushuai Wang <fushuai.wang@linux.dev>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
john.ogness@linutronix.de, osama.abdelkader@gmail.com,
jackzxcui1989@163.com, asrinivasan@oss.tenstorrent.com,
andy.shevchenko@gmail.com, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Fushuai Wang <wangfushuai@baidu.com>
Subject: [PATCH] Revert "serial: 8250: Clear CON_PRINTBUFFER on port re-registration"
Date: Fri, 24 Jul 2026 15:24:52 +0800 [thread overview]
Message-ID: <20260724072452.40455-1-fushuai.wang@linux.dev> (raw)
From: Fushuai Wang <wangfushuai@baidu.com>
This reverts commit d338ab1d90603f875c4f7ed223406535378173a5.
This may cause some boot logs to be lost on some platforms.
Reported-by: Mark Brown <broonie@kernel.org>
Reported-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Link: https://lore.kernel.org/all/20260522101042.21976-1-fushuai.wang@linux.dev/
Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
drivers/tty/serial/8250/8250_core.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index c0e8a4efbdcc..f49862d90eeb 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -720,12 +720,8 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
/* Preserve specified console flow control. */
cons_flow = uart_cons_flow_enabled(&uart->port);
- if (uart->port.dev) {
- if (uart_console(&uart->port))
- uart->port.cons->flags &= ~CON_PRINTBUFFER;
-
+ if (uart->port.dev)
uart_remove_one_port(&serial8250_reg, &uart->port);
- }
uart->port.ctrl_id = up->port.ctrl_id;
uart->port.port_id = up->port.port_id;
--
2.36.1
next reply other threads:[~2026-07-24 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:24 Fushuai Wang [this message]
2026-07-24 8:32 ` John Ogness
2026-07-24 8:36 ` Greg KH
2026-07-24 9:01 ` John Ogness
2026-07-24 11:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724072452.40455-1-fushuai.wang@linux.dev \
--to=fushuai.wang@linux.dev \
--cc=andy.shevchenko@gmail.com \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackzxcui1989@163.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=osama.abdelkader@gmail.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®