From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881993DAAD8 for ; Fri, 24 Jul 2026 08:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882666; cv=none; b=Ml5W2WvVH1gZASZyevTIXr8onVrBDkmKgx4JTJynOEUdBnFS68Z7bjf46Nr1oVGB9YR2CSAb7z1enxIQAJmQw+JTLQmNIs6LqO6UmSBxC1ClI02aJ0ocPF660vmDOzvvrtKEfjBWBhKpKW2eHLJlgH8mpm3doGrNh73DbHQhNe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882666; c=relaxed/simple; bh=nDUhaI/csnrSHq2VN8yN7twClkIbPM+mTJRxHI6rupU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mkSv1qt+hca5M/W1uzFL/0LrUdrnkeqUKa3b6g0QTH8VI/bcoydvkmFxhRLa7w6ECtsN+hOwoIkGaYUUZzl9fQbr5p2LQbrpZUwGrCHMJCHkmHfudZrY0xXzvP+vIMUrhiv6/m2J2PQn+donubxYeewfHdijmxTbydX2la1EVs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CmKpXFIY; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CmKpXFIY" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso139475a91.0 for ; Fri, 24 Jul 2026 01:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882664; x=1785487464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=CmKpXFIY2fz0FEh1sBN5K1MITqW6gA3deUByIwLLyRKlpL8Y/MaJytDIqBrNa0/Tt5 ljLVkmAIQRnPQNpfB1hDuG2LnAC1j9Wk0fUFM/xkU2F9OIbB7PGkSYRFhJtLRzc2cNrR NGBFe4Ii44lPSM+VRSDegxZtWTEppi/5ci6vA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882664; x=1785487464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=JpvyZYweOiKNL7H7fhQ7QkIKzMeXPLoFA0lF4pB2ElyCJg0StH3rF4q5RzcycdFYsg kcQNzlo+J66YgzimWT5pGBTIGZNarn9gPD8F/ICU+hMErHF6GqBFGe5VEbwC+t4KePkU pPXkSpzFLukwBs6e6Cg6Ej/6lBVmsLPZSqiZpCsQZjFNFhUilgNMQDMcAu5x5RcCvuza JiAxQ+GgcUY+4TrxAs2xKjJby8oE5S1dsbbe4W5K7+ma+dH6b7WZqWzt6C7Y+YrgtoCq vio62UhjXmWVSIzGvNDEv2mtrrTsw4X0ZfkmFHDDaKUTaGhHVoJJAcdOydnYVCyRQ19v waNQ== X-Forwarded-Encrypted: i=1; AHgh+RrwQ5fyUwFpy5kpUl0yO07UMb9np1Kl9s7UgoDh+7XdcsUvjMshd772MrGbqXNiVjK9nnrNtpK/mZ+sC4U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6uonmE8zkVIKjxwSepq8s9YyBtxx2SGGKJaiLysqHI2UmKtPM VVNAZ974jgJB1vuiWs7WyFeWlYNDRmP3WRCqU7BrMDiOhQGhQyTdh2wqeQz7/jnBow== X-Gm-Gg: AR+sD13SMhPwRB4XWyS+YpQhgiubHer6TBKTMsCZwITUJ9QHqivK4Qvrf0we28FTSg7 uDcck42EtsxTEGDwcz9Sl7mTdITOBL+l2KQgFqaX8fEB1zDjP/+IAlhWW054PALX6Soc56fuqTI uPesXrdzHwoErQEWG8lHyRzVHkfjRdCUquaM9LDNcolmlraybTLUCyFzKAAubjlqpTJTl4xWLY3 QnBRJ7Kr6ni17ulzP73m7hy/pzqy4AuZnNxodqtj9pRpgAnY7mkCHSUf5SVXhKoh9I1VZ4Ahcge yFMICT9sM/vBKV9Nq1swLo7NcXAQe5V3QyxP0gZtC+En91SRbpzYtnM2o8nDnCmHANgtONOvKaM uc51G7zArLnd6j20h8/9UIHI79SkOD0wlsWE+IZ/vPxgWduKJ4krVuvPoJ8vhAq4Xt04sZvhsgx 1orxOIGavCywAXKgeb6Vo0qwwfv/zhFfGuaP0Yr7r9cmhiWvvslibrceyEiJrZjj8sOsVsFQ== X-Received: by 2002:a17:90b:314a:b0:381:23d5:693f with SMTP id 98e67ed59e1d1-38ec65f9916mr6632501a91.28.1784882663919; Fri, 24 Jul 2026 01:44:23 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:23 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Date: Fri, 24 Jul 2026 16:43:13 +0800 Message-ID: <20260724084328.3943997-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_hub_set_port_power() open-codes assign_bit(). Just use the assign_bit() macro instead. This makes subsequent additions to usb_hub_set_port_power() easier to read. This change does not introduce any functional changes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Bartosz Golaszewski Signed-off-by: Chen-Yu Tsai --- Attributing suggestion to Andy, since the change was originally requested as part of a review. Changes since v4: - New patch (split out from "usb: hub: Power on connected M.2 E-key connectors with power sequencing API") (Andy) --- drivers/usb/core/hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 2cfe09a141d8..715f26f05a31 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -10,6 +10,7 @@ * Released under the GPLv2 only. */ +#include #include #include #include @@ -899,10 +900,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, if (ret) return ret; - if (set) - set_bit(port1, hub->power_bits); - else - clear_bit(port1, hub->power_bits); + assign_bit(port1, hub->power_bits, set); return 0; } -- 2.55.0.229.g6434b31f56-goog