From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011026.outbound.protection.outlook.com [40.93.194.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC463F8ED3 for ; Fri, 24 Jul 2026 09:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.26 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886860; cv=fail; b=s3DHYG06JeWSvJ5B9SZOAP2VkoqPcnB1yU2KmC9VwtuuLWRn2+v0xodcPsF2fpIvGuNGsEG1JMJGEg0X4VMkUKJFFcLRDoD5+ozarXKYHRoyOzhcnvGDERx/bP4nxKCIDZZY/VYT9JOS5W215Ec1lD5wqRkixKdFjNNNAumDvzY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886860; c=relaxed/simple; bh=2vlOVY9jLpY3jaC2TVVPuGG/sp+xuGbfvCyUnFbGk6Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TLte/wTCF9Tk2gTlKy1u4jgK6bkTf8bQ+PruZGimy76i/6g2kF75uxlJ3tyGSY3VuDsTm6Zyii/fhEssYIGr+AyYjxuyLY/HUtk0x7JQd9pchDOTN9OZ78+ETMSZgR4o+8gp55fm01GLKSCMeb529PPRMMm0Obp7Wfjgh7NS7Lg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Bj7f8rtP; arc=fail smtp.client-ip=40.93.194.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Bj7f8rtP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n95fnm4D1Y5nZZ1PA89TIccQ/mIBtfZ1IZ8xjOb+T4nn0ma51gw7Q40me5Qk1nP5XDhx6OLJ1ok71iMmQ5HxFUu/4phJJAMo1nG+zfUXz5pgv9Vv2spisln64KWTLhclSt52fulk+aHPOPXoZiXTHEFCoz0/4q0LbUEXwj++9U9ojkGlZIMaNkJ625Stu3xvyX9jWaeVi0syl0n2rNuHjPJozeZEkbJ92ExMMtqX1bHo9UiffahYUXT/vDw4A5xdjULc7akDzlaGcfQhFzPP1dTCArZ0an60yF4t9r5ODjiP6jTSfEW91KsEtfW6HoFeUbmGLCvFw55DsWDr5aAtjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dROjr8zLdOCauGvKoO4mZTShfegNdWTh+1C7b7Lfur0=; b=Rh/DIqR3sXgIWn3uZXZZ3cWMSsmD5epzROdZsDPx2jbVkXhlSk0YnpCy3jEsggz9hVfxybpI5Me2hU7teTF96E6d0qryja3gLx6PGQQoKWFbYSF3L/eiGAeo0D+F7Y4VZZaU9GM/z1eQcPjrCEPvSAid70ibMT1X07eSPpDSHr591kAY/mSTKlW20cSx8Bne2u5CijawdgorfKAyMePakzQaDWLn4sMyZ6GG4Umrc4NzuwnBF8diuIoLyc19VKdHJc7JMOqko1SRACc815niG1rj60olhV85OaCty/zq29drGHSfIK2rA9MbjP0MB8v0jGZCuHoKiPLN5IxtFHAPMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dROjr8zLdOCauGvKoO4mZTShfegNdWTh+1C7b7Lfur0=; b=Bj7f8rtPKkMYoBuLZG6TtdCxUroNpuNgMhf5+p1BAg9ly5xNAvWEhk83Bg7QH2ECzWCyI/mfhaOd+QT+MpHHHghmkxBf3nGJ+Nl93NfdOaNktvOjwnLPunTZ5N364Ilwhjay3gpeCYJGx1LKblRY1J6wIexjG8lFa5fVTAMUOfI= Received: from BN8PR04CA0053.namprd04.prod.outlook.com (2603:10b6:408:d4::27) by CYXPR12MB9278.namprd12.prod.outlook.com (2603:10b6:930:e5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 09:54:12 +0000 Received: from BN3PEPF0000B075.namprd04.prod.outlook.com (2603:10b6:408:d4:cafe::39) by BN8PR04CA0053.outlook.office365.com (2603:10b6:408:d4::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 09:54:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B075.mail.protection.outlook.com (10.167.243.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 09:54:12 +0000 Received: from xsjarunbala50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 04:54:11 -0500 From: Jay Buddhabhatti To: CC: , , , , Jay Buddhabhatti Subject: [PATCH 2/2] firmware: xilinx: Propagate actual error from feature check Date: Fri, 24 Jul 2026 02:53:52 -0700 Message-ID: <20260724095352.2890326-3-jay.buddhabhatti@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724095352.2890326-1-jay.buddhabhatti@amd.com> References: <20260724095352.2890326-1-jay.buddhabhatti@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B075:EE_|CYXPR12MB9278:EE_ X-MS-Office365-Filtering-Correlation-Id: e68b2bb3-2375-4f7b-39e6-08dee96983b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|376014|23010399003|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: g3GYxab/rKLE442ISrlVaPQUQ1MCxde0tyoALSCCOqT35OD0fLl+hJhhaPShFikiewyowyed4l6lCwEpRbcOGKee3sx4TKvAZrBJH/8zLdJT+juzQ83YoxSSO8hQxjv+dgy6MkERwRk+6rCAc5wqmRz80GY6LxI2UD3R3PPrBzYoglr99o5+sayg69dwyRe5yb9EH5AtsrYnIUZB5fw1eBXxDdTqhQhZ4Hlz65/TFzbk466sHlkchKXphBAipUJu3mUnwu69f4Uqbb1nEfcuwDphl34GDTKSCJLCdJyGtvm9lBgFhMr7NEHMF0JocePCuO9FOpwKd2FKScb4zYCzsNkam7cGfNPdiJPFWkgkBP+jFISORHoHcWjVwJvTI9TNcGh2CRyeWDvIQxutMcVmFOvQu+cCABYZluKnzLAsxiU75PBfbAPFZ6jeLoXNblgOSrFYTiJvkTl0QHxWZMQQi2Zn+fwPGeMhh4GqTIO/GD1Pn2wA/ey85Ied8LVRAH5npRrB4clpxdz6QQgRDm/gfr/H+bDeexiZz8KoP3EruThv3TzxVI+m1ik4DvNWduIUIlhE8uXE3mv2941ek7PkkCxtMXrR52ii7fgqrG3cNuxovyQUsdeune7G2rbML1tMD2nah4+aW0Qit65CpgmwTMt5oYUF93VAZq3dMn7zWkglCvykn4PFFJiXoDvBVVlUvHCLeTpEAgOOwI09/DV17Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(23010399003)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PzBQLsnva/m2ZtYEQ9wiqHfaRjd8x4z02BFj1geloQJPUJDJYb5GNwSrmLoQRA9B4cYzbcUF48oOyhYgti576V998dCXxmV5TmyVilkch4hp9r+PTgv2oJ2OxDuLrD2kWhjmdiZarO93SqZvrqkqS2oHVLflNT+oByXgec156yVGCJoulJr06Hgd1h/rG8Qsne4k7EwnKHsViOIMfvKtZzwrKCM8XSNX7YfGnFimxPaL/M99yOSPEso+8B/UnEs3uGxTZxO4wT/K4c0zFqp+HG6fsLFhfSbWB0A+24M0xL/ICEGLIMA02cGUkkggULE1IAPKMdXfG97um6KjGQYNDhC4nDlYjQAT/3fEzIgsZeYDb8Q2pFX+TOfyRMxl0Ae56aDZ5z0YPlPwxrl0eEEoH3VDiJQGUeId80Mue3eXGxKkN6sugG7K6uhh44xagoTz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 09:54:12.2941 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e68b2bb3-2375-4f7b-39e6-08dee96983b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B075.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9278 When do_fw_call() fails in __do_feature_check_call(), propagate the actual errno from zynqmp_pm_ret_code() instead of always returning -EOPNOTSUPP. This gives callers more precise error information. Existing callers only test ret < 0 and are unchanged by this. Signed-off-by: Jay Buddhabhatti Reviewed-by: Radhey Shyam Pandey Reviewed-by: Prasanna Kumar T S M --- drivers/firmware/xilinx/zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index 95f5941c5ca8..0b6c20a1d8be 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -252,11 +252,9 @@ static int __do_feature_check_call(const u32 api_id, u32 *ret_payload) } if (ret) - ret = -EOPNOTSUPP; - else - ret = ret_payload[1]; + return ret; - return ret; + return ret_payload[1]; } static int do_feature_check_call(const u32 api_id) -- 2.34.1