From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B654423E81 for ; Fri, 24 Jul 2026 10:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784888829; cv=none; b=pxkwgKiBlbNK02aVPcTltkNGc+GPu7MtNPVLV60kPG1vFsnbbndITT8oVPhGyWLozaNX0z8uAPZpfIV6rbUSYSRM2EOrKIRlcLPAvFTuNEiLku3x++cVwANjlRElphQ3LddB0Gi9aLvWJZC7eKRLcN6BA4sbIt0+FuQwdf6M/is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784888829; c=relaxed/simple; bh=6L5ZcMNuc7sXOAGr2CduHgADABtuFFqyC3eEUsM9JL4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WJmyVeGdScCqB6beM7YG50gi/dQ/7bRffce8WKifswYPsDLkM3zn0j9H4HhhZb5LNw8ZDjkiXGDfYkpLcIW7WGA7hBJMV09hkYztYfansqcZv0alLTmKPRgUk2a1yXL7wcpEl3NjmehfDV111zv0ErNalGidOJVzJaLa8cVrWFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XiHbwdiz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XiHbwdiz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso2182115e9.1 for ; Fri, 24 Jul 2026 03:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784888825; x=1785493625; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FZFatenffFm3vC4s23tbMEfT4od/v+X+Ee+06x8W0s8=; b=XiHbwdizey+bIoCUw1/FbdcbHjBzGTq+VblY0pz/OALmzxADXomfMMF1SRuxUHsy0n J/GWSV1IQLY0BAVYHUM9miJlYEMT59NK/td6iLXI1v83cGPAk0Si7DPVMQynZZtWoc31 +Sm8b2cAl81uq1QX8GH/TUQHZtAaojdcSXunO8Ef0heMf6Nj3P0m2klXsVbY12yr/sIu 7bWrcFdjCSwgZg42q2Ldib4U5IpGVLJeKPLYIH2e0sdCHqDvCbw/tUCKEBNqd/Wf4Ez/ spJrcTzia/f///4dhNvjE4Rn3eNxA+UpGgsngiAwB3Zm0sIFnyUCC5yT7JUtEZrnoutv h1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784888825; x=1785493625; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FZFatenffFm3vC4s23tbMEfT4od/v+X+Ee+06x8W0s8=; b=Uwat2gNbum+HOdWXUUWwyRzmIYJ9nGHR+CtPfo4+Cmat3xCHTO42cROpUb84t3tcWQ cEjsAw8TG5s99tMwT91wh0PWp/jd3I6iGpoRIxG8k8VjVgZJL2yMbC/qOwShaNfNd9e4 2YKVR73S7W70BcQhx1UsVyJl1klMG10W67+iLA7zR6LrvYWe4P27sy2xNSoSoM+Xg0T5 BVRew8rpQ3R706LSO8bOv/PUPV1O46MP3idLzOk2JHrc0P1p35m8yvDkxlWIty/bMe0E Bsn1fqH04iGCAm3cgRRuZp4Js1rQDV2sTUYLinUbYaHPWIKtp+IgDCjY6sDkwn2TbjM4 rthg== X-Forwarded-Encrypted: i=1; AHgh+RqaLQkSFJwwXSe2clu1awtsMuh+Exbv8/GtvXBpWXJR0AKDpUOuuKvycj35M6cP+tJHC4dYSWDApOw6uJU=@vger.kernel.org X-Gm-Message-State: AOJu0YxGkoRw/GTFsqIyZ3z+PavbjByoTVy05xAGByZ19f5FnU1qXd99 AZAYar54HIB0KuEAW0MoU/Q7lusI948q0sUzYfQpRYF06szdKkON/wh+ X-Gm-Gg: AR+sD13CBqGi/27QRm7WH9UQ4nmP20/xmZmZAVtJkLRA8yE8p+/7WSPtT3T3Ji2Kh9H 2lbC/qCHUdERGy0Y9E6SGfbFRGASVAj3Tn3RSkwgJRE80yOkYsQzSgtgnTjnC0iTTYRjro6SzRF Rc84pFxa1c0+4erjO5/nvpDRtUnd8/uZajaThd9hm734dP5up3U8dzcN2RnPm2aPybtU//2jSuc +o6sFdDuZeG2T9dqddqwS/XhsOcQEdZtRzbw/lY8JzCF/VPUM3xvcD6ottykudvomhf2tOdDMb6 vUwfJ6bOObDe1OAsAK053yofDsUMgCUqu/2NrnIubzw76qE7Kf11vvBmghImU3Vw0oVaEtTyp27 8kNonixvqqb1WXLq2NGuAprD0r03hHhAX45JB9NVEylOX3CyNSBXSzKGPzSAV8aYVugxyGvdw7J DYZM9NsmZjvfZX5/NjODu/pugVgiklrMzl2nsfzPoydSWt0sAaR5m56ws2BsUq1rRiGm6AEOgeK 7no2ecqZYgzfgJbz+WlocCNHPPbvLg1/Mi4LFYhXPw426EzDLHbjrMBQPt8VyJOfX8sitgmG0Xb BJ/bv4qW6J44ptfBLYtabLgIF/Na9kss3nEaUxAC2UWjPY+caqo3OMKzg8vVUP4TIGh/S4/7RAt ofxbYTYdd6O7X X-Received: by 2002:a05:600c:35d5:b0:493:c601:3e23 with SMTP id 5b1f17b1804b1-49573c8c8c4mr71049715e9.5.1784888825131; Fri, 24 Jul 2026 03:27:05 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bfa79d3sm46154535e9.2.2026.07.24.03.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 03:27:04 -0700 (PDT) Date: Fri, 24 Jul 2026 12:27:01 +0200 From: Joshua Crofts To: Pan Chuang Cc: Puranjay Mohan , Nuno =?ISO-8859-1?Q?S=E1?= , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Marcelo Schmitt , Petre Rodan , Dan Robertson , Matti Vaittinen , Gustavo Silva , Maxwell Doose , Tomasz Duszynski , Nishant Malpani , Javier Carrasco , Li peiyu <579lpy@gmail.com>, Lorenzo Bianconi , Alex Lanzano , Jagath Jog J , Mikael Gonella-Bolduc , Subhajit Ghosh , Mudit Sharma , Kevin Tsai , Linus Walleij , Anshul Dalal , Song Qiang , Andreas Klinger , "Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= (The Capable Hub)" , Siratul Islam , Sebastian Andrzej Siewior , Bjorn Helgaas , Danilo Krummrich , Takashi Sakamoto , Xichao Zhao , Waqar Hameed , Sakari Ailus , Marcus Folkesson , Miao Li , Dixit Parmar , Andrew Davis , Kurt Borja , Shrikant Raskar , Chu Guangqing , Antoniu Miclaus , Srinivas Pandruvada , "Rafael G. Dias" , Svyatoslav Ryhel , Shi Hao , Colin Ian King , Salah Triki , Yury Norov , Greg Kroah-Hartman , Yash Suthar , Achim Gratz , Yasin Lee , linux-iio@vger.kernel.org (open list:ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER), linux@analog.com (open list:ANALOG DEVICES INC IIO DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2 00/13] iio: Remove redundant error messages on IRQ request failure Message-ID: <20260724122701.0000156f@gmail.com> In-Reply-To: <20260724030524.607185-1-panchuang@vivo.com> References: <20260724030524.607185-1-panchuang@vivo.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Jul 2026 11:03:35 +0800 Pan Chuang wrote: > Commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()") > added automatic error logging to devm_request_threaded_irq() and > devm_request_any_context_irq() via the new devm_request_result() helper, > which prints device name, IRQ number, handler functions, and error code > on failure. > > Since devm_request_irq() is a static inline wrapper around > devm_request_threaded_irq(), it also benefits from this > automatic logging. > > Remove the now-redundant dev_err() and dev_err_probe() calls > in iio drivers that follow these devm_request_*_irq() > functions, as the core now provides more detailed diagnostic > information on failure. > > v2: > - Rewrap commit description to one line. > - Drop redundant "!= 0" and "< 0" comparisons. > Okay, code-wise it's fine, but rewrap your commit messages to 72 characters per line. Feel free to apply my tag for the whole series: Reviewed-by: Joshua Crofts Also, I was scratching my head at how enormous the To: list is, given these changes are only in IIO, but I assume you also added emails of the people who authored the latest changes on a file that get_maintainer outputs - there is no need to do this. Tools like b4 can automatically add (correct) recipients based on get_maintainer.pl -- Kind regards, Joshua Crofts