From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5773430D416 for ; Fri, 24 Jul 2026 13:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899253; cv=none; b=Tt7LNShUonU1k0MmU/Ldalj98UfHVecH1yazFUmMWNClUmvoZIc5fAzO2Q34SNHo0GoY+ZV63XBLea7iMoik7E7jBOjnuhEPRMWiCtLHj9eUofp1zdmUGQ2PrwmZcDIcTgwHVgdQhwc0LWXiYp1+QAG9eZ0ruvSWudIo2TRvoYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899253; c=relaxed/simple; bh=SYjqXWv4bZr6dvi/XqTCd4hnAHLximFwk8qJHz6Za3Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l5wDDrRUx8X8KrTxPw/JohZyDfQ7xeVWlS0Qp64olQuv6Nu3vvfI47f2PkiCDyHqIUfiGCZM/e+SMMjZ3LKs6dNCEV3PdQef73rPFiFsCrh0USdkVDXEQXsKvZCXWwRuVXtszrHRJK0+fhF5gjHC4wwHa946yvJED6hfjpvnVwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i5LVM5uB; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i5LVM5uB" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49553515a8bso4875545e9.1 for ; Fri, 24 Jul 2026 06:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784899251; x=1785504051; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=U75754n2io1Ko0ra9ou19wuxflGdkNj7nt1DvCD1HlI=; b=i5LVM5uB4jG/z/P7DC16WFU7DHNO7uzF1Gx99BABpytUbNEtRJdnzg0ooinD6hQi6b 3GRn3naSB5gPnYjul8jAaMURdiwMTYffL09ybvFc5IaEt6mWokPHyHvU6wPRWwMscr+s 5JnvsZ9aLt8/GC5BsNpvpwtJVvh7RR9a+LbKP+mgdvjFnvHm6fu/onK6y+t2zsKErZZl iZ8k6BiBHd/LSOJzvNHD/d1P/zrGE1eO4QlWq7XBPppwe9RT14QfG8/ODaxfH6WPCO8M j/3nriwDfmAxv1AW4Th3+APxZpJmZDNJnssVb9svJgHV44FJ8f+QQx+Ia3B9CSixzqcl S+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784899251; x=1785504051; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U75754n2io1Ko0ra9ou19wuxflGdkNj7nt1DvCD1HlI=; b=Kb9IKG7cZ7pfRdPpK57Ob+9A7OXVuhW7aIaTLwHSJIUzu3gH+Gnmmb+YT+zwNncTBL aamay599Z4klIIOvg0X01ThXbxgrjGv1bdON9NRZCNz7RtQ8it2bymZwoF6ZGWjhQX6E OQT5vL09tL4zpw5mgZVPWfzCMZenM3JZ5zaeMdD0d/3wGPDAXkx/jJ1RXYmgnOo8llvb eCCHYZNl2BvIBSvruKGRVVgX0tG+JkNLXXjjI07souv2Pa9u+oVyMRPMpDH5hz2dNrE0 p7xehaebU65BI/WrNo0weOOcGp72U8RJj8PpkX8a78go8zLK1zRVHOksDibvIRUrexcJ yGRg== X-Forwarded-Encrypted: i=1; AHgh+RqHGOlExu61h9ue07dl4ItpTGduH+1zEM6TFnszchYPOCC60y+4EB5JsP6RLVun0uOj+SZiPbdk+FvMX6c=@vger.kernel.org X-Gm-Message-State: AOJu0YxC8zWPpLHqNVCcqUllGraPED5itTDIQ1uaOn6W0XVLYSjC/IRM hKfJnbwEYYMLR48fIdZBdRZmGDgQVheXGxibO2YSqaWn/o7/5fLHw1OI X-Gm-Gg: AR+sD13htkg3cPEIneymaUJgu1b2baNmD0eG9ULIwZkvtYAUng3U0MlFyPHEuap3tV2 uBtLd4gQgLGQse1TosB/2YveJGV+hONSOIpWCpjAzWunR8qK/g0+8Tsb0X2pRBG+0BhcHHpferl 5eiFeH+mz3JgFJqKJqPiYg1QuG0od+JAOsv1YdppVBJ9Qh6wSaRhCL6fGnX5o1X0xys835pq5vX IXqvzS8GGnC9/5Zwgvor/Uug6+GH4OzYd2bynLmuCX6smdtEeOAofJUWUtfjQxnNq9ClRc1UI2o dKJsTSieJMLPgKoZ831Fi5d7YV6UbV2m/rAc6pKf6/8I2wXEjdAz73vN/5W2wH89ti9fyp493O9 GSEx3bz4TZwTexeP5h+8Xgsg0LrOitkm7gFVRN+O11AAuu4d4IKhrzVFNF/+5p2ud7PCAsEBWNg MOW142xk5kzX5MDOtD8m6PVeRblOtshKOgnmI+rU2VAP+lb0Nd+w== X-Received: by 2002:a05:600c:350c:b0:495:7293:4fe2 with SMTP id 5b1f17b1804b1-49573ce4275mr86077405e9.17.1784899250250; Fri, 24 Jul 2026 06:20:50 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957af6a15bsm78002565e9.4.2026.07.24.06.20.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 06:20:49 -0700 (PDT) Date: Fri, 24 Jul 2026 14:20:48 +0100 From: David Laight To: Zqiang Cc: paulmck@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com, urezki@gmail.com, boqun@kernel.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: Reduce stack usage in show_rcu_gp_kthreads() Message-ID: <20260724142048.53e392a9@pumpkin> In-Reply-To: <20260723100430.17813-1-qiang.zhang@linux.dev> References: <20260723100430.17813-1-qiang.zhang@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 Jul 2026 18:04:30 +0800 Zqiang wrote: > When CONFIG_KASAN=y and CONFIG_KASAN_STACK=y builds, the > show_rcu_gp_kthreads() exceeds the 1024-byte frame-size limit: > ... > rcu_for_each_node_breadth_first(rnp) { > if (ULONG_CMP_GE(READ_ONCE(rcu_state.gp_seq), READ_ONCE(rnp->gp_seq_needed)) && > !data_race(READ_ONCE(rnp->qsmask)) && !data_race(READ_ONCE(rnp->boost_tasks)) && > !data_race(READ_ONCE(rnp->exp_tasks)) && !data_race(READ_ONCE(rnp->gp_tasks))) > continue; > - pr_info("\trcu_node %d:%d ->gp_seq %ld ->gp_seq_needed %ld ->qsmask %#lx %c%c%c%c ->n_boosts %ld\n", > - rnp->grplo, rnp->grphi, > - (long)data_race(READ_ONCE(rnp->gp_seq)), > - (long)data_race(READ_ONCE(rnp->gp_seq_needed)), > - data_race(READ_ONCE(rnp->qsmask)), > - ".b"[!!data_race(READ_ONCE(rnp->boost_kthread_task))], > - ".B"[!!data_race(READ_ONCE(rnp->boost_tasks))], > - ".E"[!!data_race(READ_ONCE(rnp->exp_tasks))], > - ".G"[!!data_race(READ_ONCE(rnp->gp_tasks))], > - data_race(READ_ONCE(rnp->n_boosts))); Isn't that code carefully reading all the values twice? Also the "ab"[!!val] generates far worse code than the more obvious (val ? 'a' : 'b'). For the former gcc indexes a constant string, the latter is done using arithmetic. I'm sure there is a good reason for data_race(READ_ONCE(xxx)) ... David