From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f98.google.com (mail-oo1-f98.google.com [209.85.161.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FAF43CE74 for ; Fri, 24 Jul 2026 14:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903436; cv=none; b=fVOiQXe4E8pXcKla5jXxBXGi/mzlNqghUIAIPTZIHEcCeRqrwSm+3LQHwOFJwsLlWoy788YcniMixkEk4g/DD3llVL/7G11JRzqD+3Ye/yF1ux1bL37li1J/lS1CMR353CrP6iKwm1zocCIhMbl0rHjfnJNDaIRIT55+X5qHC3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903436; c=relaxed/simple; bh=4T3TGrPOmCcuyK6wQdLMcII19a6AyfhLY97Res9looE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rLRWliboSTb29tD99cA3sNg14a6Ei2Q4qtrlR6gf0WAzg+H7CMFmrrb7VdY7XPd73bYHc3a02wdOAOX5uZn5fPthRXJJ4ynbY3XcKyhSNvND839szbWWHZxBV65+jSGJ27VwXltZr0ouhsUktB+wyL+IWQSKvRvmOsH/QQ3oE/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=C03TPZf6; arc=none smtp.client-ip=209.85.161.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="C03TPZf6" Received: by mail-oo1-f98.google.com with SMTP id 006d021491bc7-6aade290804so239048eaf.0 for ; Fri, 24 Jul 2026 07:30:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903433; x=1785508233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TSV0sSSXYSyAmLjxbnCOORhk+yB6Zbd6HUBS6OIrdiQ=; b=VsveSgtutOSaN15BZPInD68TrfUK8sDPB/d6R7mPJ50v2M1ygbeoZ9cX6apTE182AW zsoHb7mZIyWk5Y+AwdYI0QFmQCtbFP5yqCdtYsd0Tuqv9XJ0ZYQlwKQFavzTe942ncde JwVAcJmR82OI93LCVgk6VT5PFuhTSC5DkIMYxH5HTUQ9FV6/8DFuKHwFek99tX/0J3SL 06vG+/6nkAPjmdMGwNbrmq2nMF4EwIWAtRoB0QHTXKgHA1oLv7X4oZWJ/Gn8qzcI01qR pJjsfMOjO8AXOWtMTpbFbPhdmEt9tB+PE2uZcv3ve41HWIaJLXsV1zZbdcvc9CeVNfwn 2arg== X-Forwarded-Encrypted: i=1; AHgh+RrypRhmeLPkK1ukITaJE0O8KtVxKqCNCnnHJt33hshF2uDjx4Iy/ttj9pR/4n8Cp6L41irqvqQzLchHM90=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2o/rEr3E3mHd1zxWydJ7QjIlIIJbWkvpcCzW9hBhK0UlKMIzG 3kBKgDbEFgQlS7iHGa6KXd4WHXKg5Tcd5jImWOYNp9HS+ihZ/Vky2NhB7PObU+HKwFym4WCIwlW 70+ywSeQb/aEvqX7Baf3UKazU8KxTgs372Ht8NjhszL4th0PQqPr/gj8ttINSZKfOgqjIIHWYuM +nGyPQoRHDjkbxrmYSlONX08GVOHkPqOqpgdDJsuUuixWl9GChN3W5RjVKXoCBwhu4VaXEJotty hkPKs+JioGRm24FyA== X-Gm-Gg: AR+sD10NDBkqFEPmdouGMSwCzvRkPJZ2D9MaRGzPveAPeBtTLAnVXyyeb3QNRjv3EL+ GHK7/ShTEyPmYJtumiRgzwP1GV4bWJPqyfy49h0FcHjD1W/I8FGUPLKRsJMFwxdh3Pr/cuRoTdT 6pMk2yYjmhbPvxGJ0I4UPA6EwzQ2zNzmLa5AsLXdLKIL1wsHJQh79Z1tRuIHTO50vRtOREIghzT dpB1ZEteUCTP7eReVKwqQyKiHnREZ09o6PWa24pD+UCo7bxXQXOoUizZCVc4Vd7m4pFtAqMWvhh kqzn3+JpqYfYoAtHUoWSRsh+MJxKwBPevNsnSJ2E+J+ftIOwsizir+630DBonONRUOfNv9i79s5 mxrALJbEYsMXwR31RHHK6cPsN6PMRSIcFaM49rOO3/Gnn8ie5SVgxnE3LZ3qt+VqDiz1FGQIaS0 ISMSk8hZyNCSCkTqKvfWw+kq5Z8L0fgT/t+Q== X-Received: by 2002:a4a:e849:0:b0:6a4:7afa:aed9 with SMTP id 006d021491bc7-6aad415dc1amr4039377eaf.52.1784903433371; Fri, 24 Jul 2026 07:30:33 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-6aae0460d92sm201265eaf.24.2026.07.24.07.30.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:33 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb5ea36f969so553649a12.2 for ; Fri, 24 Jul 2026 07:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903432; x=1785508232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TSV0sSSXYSyAmLjxbnCOORhk+yB6Zbd6HUBS6OIrdiQ=; b=C03TPZf6cGw7y791sMQSyNWDE/1RhbxZ2lXe9LVi2XtySOCQITMcxtoYsIFyygwuvq JXelc1CgKMPGxIcF4nfsONbtY7U4NedpzPT973r7NHWcDT0qHsGbVN6/wrj1Qg/QVZlY lBbrCm2/9T52N3GZVgcjZo6zcJ9iMWDt6kGcA= X-Forwarded-Encrypted: i=1; AHgh+RqSaDW08isRy9t4AOxoruU59C3GWYNTJKj3wC5qvO3Z0Rzwy1OpaR5bPqO1pzuFGKzle/SvYzFCPOEx++Q=@vger.kernel.org X-Received: by 2002:a05:6a21:7317:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c44afcf8b1mr7850182637.20.1784903431661; Fri, 24 Jul 2026 07:30:31 -0700 (PDT) X-Received: by 2002:a05:6a21:7317:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c44afcf8b1mr7850146637.20.1784903431100; Fri, 24 Jul 2026 07:30:31 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:30 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 1/4] bnge: add steps in bnge_shutdown() Date: Fri, 24 Jul 2026 19:59:51 +0530 Message-ID: <20260724142954.3101980-2-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Since the driver now implements ndo_open and ndo_close with full link management, the shutdown callback must mirror the close sequence to ensure the device is brought down cleanly. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_core.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/ethernet/broadcom/bnge/bnge_core.c index 68b74eb2c3a2..9846d29b4fe3 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c @@ -5,12 +5,14 @@ #include #include #include +#include #include "bnge.h" #include "bnge_devlink.h" #include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_link.h" +#include "bnge_resc.h" MODULE_LICENSE("GPL"); MODULE_DESCRIPTION(DRV_SUMMARY); @@ -406,12 +408,34 @@ static void bnge_remove_one(struct pci_dev *pdev) static void bnge_shutdown(struct pci_dev *pdev) { + struct bnge_dev *bd = pci_get_drvdata(pdev); + struct net_device *dev; + + dev = bd ? bd->netdev : NULL; + if (!dev) + return; + + rtnl_lock(); + netdev_lock(dev); + + if (netif_running(dev)) + netif_close(dev); + + if (bnge_hwrm_func_drv_unrgtr(bd)) { + pcie_flr(pdev); + goto shutdown_exit; + } + bnge_free_irqs(bd); pci_disable_device(pdev); if (system_state == SYSTEM_POWER_OFF) { pci_wake_from_d3(pdev, 0); pci_set_power_state(pdev, PCI_D3hot); } + +shutdown_exit: + netdev_unlock(dev); + rtnl_unlock(); } static struct pci_driver bnge_driver = { -- 2.47.1