From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DD243E9FB for ; Fri, 24 Jul 2026 14:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903445; cv=none; b=bjh1XtXXEZfs/hsFub6GX9F12s53rrPLJfimfVZCA7Fh/kG9hmhNFL59jJBVvZ2QHd1uSoquptJ+imwK7UbUaHpSIoCFn5sE6c7ULmHwlrYgNMFlpp8xOP/UCRyjy79fmqeaH6evksPCxqwd3yEIxxLoBwIo3M/jrcq3PtyIvLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903445; c=relaxed/simple; bh=T6+4uWno3qiPu42lbh3caCYCt+l5+8vX7oK0bCAiq8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TcG2mR0T5kTBn8AoTe9bcvODeMM2ABg6uBeeI/dj0LLt32mj4YT3K6SNXmnUUnXZ4EaajYM8RHR/ss/l7pfZUsejLdKOy1DIJk5gmtUWxe4+yX+RngVCEaObiZh+N7G4uQ0neVHdyv12EdmvljdRrZMk0iNANViRjxU/M4jKkE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hWcQHXpT; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hWcQHXpT" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2cc61541f8cso17490465ad.0 for ; Fri, 24 Jul 2026 07:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903443; x=1785508243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6yRI+9u7xmeJWs4rtpYpBl5JFmjWKLMn+METPdpZP8k=; b=I0I8yfw7Izi6R04kAT8fEsuLoVb1KXVzPbtabEd6gho2TKOw28FBg3/+weE2sa0eAT Qmsbj5NGK5fr0/WOKs15iPqvDiI7aslVhfOr1u9b9XmCQRJ/aahTMEYkyV6h1y7UI3sQ DcTFjC5zJdz3TfpAYJ5cem+7kJXEbVzUqvemo8tXhxdY2oerqPsch0FFNLU0Ll7C+kLF JFKwQpY2KzlQNrI5HVbYr8/Z/DzqkHebGboW4kOF472qmet4KJhdqFhDOSZ4CUjUE47W p+YUHwF2pw9/LEfGBHu4ujPTpE+4iwXrchNIxgtfkvJrOUGFZjHjWfX30UPWVc6D2fQ4 zQ3Q== X-Forwarded-Encrypted: i=1; AHgh+RpA6Xjuo+bAzbU1vfbxWxEnyXf8BDroE6EPvlUDTFcXfSXBSTzOauYVuWUYsLOqTqt36Ndv7/yxc9dEgog=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy4wkTg1/lPZz3CDQDBMdfN8CUtAi7GeNcAu9/la5cNSbLLIP2 mj1RzPkjEOK3nOZmT5O4EBhwcS/okle7HcPocRyZVnVOMavkPOj7INeB9sVTorRBKzokddZSnlL tXz4P9F3n7W+6ZnGX/+cQ7ghA9Bcsslg78Y1gJ8qVY/wyhYRFBrWpUCtMys61+M8jo32jL2R39t MS+opLOgT6Rub2k5RabNOj6PIyAWSKjATpcGYS6ZkphMMZS1uwg+HUowbvxlAiwiub+iVy3PAeb IYJ4qfKuvkVZBtMXA== X-Gm-Gg: AR+sD106i3OCfN1jV6J1JK5z3sjSDGN1HB1hDqKXdV+WpAf3sxhLCgCZpbZRWwyjd4T gAxSkAH/2lzB0pM8wOd3z/Eq2usz14czWePrjTjsOqAxSLZK6vXbQn2uOHpgwq8AkYim3iwMwJ5 YBWjIvKNO91jFujrgEovw9l4s4rTnhHGYqGOXE28djGrV10YAgQcjNqC4bW8ip0CE3Lx6Er9QQC 2y5rqdtFZmSXHYMjtNZroL5cWYSVvcEkHcD+cAlpxJCp0CCWFnw7hwXga351mDAoa2LYT1qfJkB M0m6j2SU4Tm729GP9PADXmvorPOg/iuxtlAeQPvcTiTRYBXlhGlGWIVO3mIeMqcewAmsg+y1fjt 49nTFcIF+IqRLKk8DKVfgOThpa447IWA1xNboQzmJocCZ9uURhmWMLCPXi7H0ZZ5ldizKyYBylu m5Zx+1de2gNNP+qEfBjPNh8gkVmgyAgl79Rw== X-Received: by 2002:a17:902:e545:b0:2cc:db7a:251 with SMTP id d9443c01a7336-2cfd70bf070mr6963425ad.2.1784903443326; Fri, 24 Jul 2026 07:30:43 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2cf8f2b1947sm8112765ad.33.2026.07.24.07.30.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:43 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb6ef846b33so396222a12.1 for ; Fri, 24 Jul 2026 07:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903442; x=1785508242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6yRI+9u7xmeJWs4rtpYpBl5JFmjWKLMn+METPdpZP8k=; b=hWcQHXpTT9W5h8PZtbTzbJFuSCf5r4RbbHnfyOmCm9fzyuC7qz77vE4vfIiLbGpvMC 5NRg9o9B0taUcu3UaUdDkcdUKf/RbCFqJerclHZEHpOaFjXQJfuHwsWVhxDpgq1bzYJ0 DTMRYJSjzQvCvY54nMwOIhfRCpIsn4EA9Ffh4= X-Forwarded-Encrypted: i=1; AHgh+RpBWj+vijB3Rj7KQDH5hpHNlmDs2P2CRJb67O7M5gCrzu9oU6C1rtn8LYN1CShxFOVCnYJXg2ziRz27pE8=@vger.kernel.org X-Received: by 2002:a05:6a21:6494:b0:398:76d4:c7e9 with SMTP id adf61e73a8af0-3c6726d21c0mr802989637.35.1784903441771; Fri, 24 Jul 2026 07:30:41 -0700 (PDT) X-Received: by 2002:a05:6a21:6494:b0:398:76d4:c7e9 with SMTP id adf61e73a8af0-3c6726d21c0mr802944637.35.1784903441316; Fri, 24 Jul 2026 07:30:41 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:40 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 3/4] bnge: add ndo_set_rx_mode_async support Date: Fri, 24 Jul 2026 19:59:53 +0530 Message-ID: <20260724142954.3101980-4-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Register bnge_set_rx_mode() as ndo_set_rx_mode_async to handle unicast, multicast, broadcast, and promiscuous filter updates via CFA_L2_SET_RX_MASK. The async variant receives pre-snapshotted address lists from the kernel, allowing the driver to issue sleepable HWRM firmware commands without holding the addr lock. Move uc_update detection to the caller so the async path can compute it directly from the snapshotted UC list before calling bnge_cfg_rx_mode(). Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 50 +++++++++++++++++-- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 1e3cdaeaa03d..e67536a8c430 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2202,16 +2202,13 @@ static bool bnge_promisc_ok(struct bnge_net *bn) } static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_list *uc, - bool snapshot) + bool uc_update, bool snapshot) { struct bnge_vnic_info *vnic = &bn->vnic_info[BNGE_VNIC_DEFAULT]; struct net_device *dev = bn->netdev; struct bnge_dev *bd = bn->bd; struct netdev_hw_addr *ha; int i, off = 0, rc; - bool uc_update; - - uc_update = bnge_uc_list_updated(bn, uc); if (!uc_update) goto skip_uc; @@ -2272,6 +2269,48 @@ static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_list *uc, return rc; } +static int bnge_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) +{ + struct bnge_net *bn = netdev_priv(dev); + struct bnge_vnic_info *vnic; + bool mc_update = false; + bool uc_update; + u32 mask; + + if (!test_bit(BNGE_STATE_OPEN, &bn->bd->state)) + return 0; + + vnic = &bn->vnic_info[BNGE_VNIC_DEFAULT]; + mask = vnic->rx_mask; + mask &= ~(CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS | + CFA_L2_SET_RX_MASK_REQ_MASK_MCAST | + CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST | + CFA_L2_SET_RX_MASK_REQ_MASK_BCAST); + + if (dev->flags & IFF_PROMISC) + mask |= CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; + + uc_update = bnge_uc_list_updated(bn, uc); + + if (dev->flags & IFF_BROADCAST) + mask |= CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; + if (dev->flags & IFF_ALLMULTI) { + mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; + vnic->mc_list_count = 0; + } else if (dev->flags & IFF_MULTICAST) { + mc_update = bnge_mc_list_updated(bn, &mask, mc); + } + + if (mask != vnic->rx_mask || uc_update || mc_update) { + vnic->rx_mask = mask; + return bnge_cfg_rx_mode(bn, uc, uc_update, true); + } + + return 0; +} + static void bnge_disable_int(struct bnge_net *bn) { struct bnge_dev *bd = bn->bd; @@ -2704,7 +2743,7 @@ static int bnge_init_chip(struct bnge_net *bn) vnic->rx_mask |= mask; } - rc = bnge_cfg_rx_mode(bn, &bn->netdev->uc, false); + rc = bnge_cfg_rx_mode(bn, &bn->netdev->uc, true, false); if (rc == -EAGAIN) { netif_rx_mode_schedule_retry(bn->netdev); rc = 0; @@ -3204,6 +3243,7 @@ static const struct net_device_ops bnge_netdev_ops = { .ndo_stop = bnge_close, .ndo_start_xmit = bnge_start_xmit, .ndo_get_stats64 = bnge_get_stats64, + .ndo_set_rx_mode_async = bnge_set_rx_mode, .ndo_features_check = bnge_features_check, }; -- 2.47.1