From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F9DC44C64C for ; Fri, 24 Jul 2026 18:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784917756; cv=none; b=aTAKy2WT86qSeH9m10vJrFtgNoXkdlNY5QhDR+Zohn187m7wJ9PAzRO2FWPI0UPuq6ilqcqvyoOI/gPzUH5j/ZPDg9OoACKoUG3fFbqBk9HEoNvvK/kAusUTsC29nRkzddagWdS6bANb+EYnNMfBdLCii/wADWp3P9t5T065s4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784917756; c=relaxed/simple; bh=ajG7LgiJ5p3r9yao4QqzF9RmZZWT6brpGmFfsQNfxWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ft+63LVGYzXm9cZ0ZKWc1PSIrkpl2vXNVRbeyT43Wns4QhND85ARg0MjoelEwcqEQzHsMND3Qtr439YG7eSwWMVv6w8EDmYCBN2dpPlvlPEKy6xbUX4DASvo+621rom6xz4qQyPFi1X2Q6YBpSrebIN+mP9BeBnao5FHIV9cw74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BOTE5QyC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ix1VgX+4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BOTE5QyC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ix1VgX+4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OGqXgf3936441 for ; Fri, 24 Jul 2026 18:29:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hOd800wfgL3 J2dUjIr9lnlGMjGoYy/8xteok0hcXWEE=; b=BOTE5QyCBoeUppA9+TKtky1YGW6 +KfYL+yaF8Qp9QXl9Sq4fNBf8P351K+bFyt+GRGRVNGIkkn/3xZQOu3utgnb1l+0 7KoX9eDhW8B+582evm5rznDNiyMcELPL2aNyucgzYs/1u3OAb+yBPmchJbW8hyBX h9Obf7OGSHNEl1fLrpr+5HP1CqCovXtsRbczeu31K4Q63cTITqWAudP2ezsrHCzS lLH/9PKP+2Z90ozOCSu1Zk2WInWHZreG7OJKD3dN+MisFBApKvclpm/G8EWXNtBv MJzZW6z6taLjLjzkUGvyuEkvV5oCZt4brvk21nwmz3eCbuDAvJ0Y8Yh5uWw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmb6p8h3t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 18:29:13 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbb6433e9d4so908502a12.3 for ; Fri, 24 Jul 2026 11:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784917752; x=1785522552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hOd800wfgL3J2dUjIr9lnlGMjGoYy/8xteok0hcXWEE=; b=ix1VgX+4EYJ2nKGmGuiHooOJbL5RxuLLGyhgo2ttamezeQbUpFsn0hYj6J9RJhbi1C qPyD1GadpTaPAiR8B3T2uxMG7+6v9d/LTDHRtfunkEQCyl/G2Pd8Jo2eBUbNHJ/L8uNW M2XIJmYWmO64ELkv+wF5/w9cWIJBzWr75mNYmxFxF5WayyThrUus1CC15w/7SYa4J+h4 8+1CL7un7xd8aR4al8ofbSQv5tuqS9b8vCAXLUOPO35GZe+ObOoHP9wjo7WizcmPwUKt kRd0Yiov7RJ7AlLEGDWYsbZirCKkwjr79L24ETIOyhiFvKHrtxlQy6MIZBlE7UrSZrvG v3/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784917752; x=1785522552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hOd800wfgL3J2dUjIr9lnlGMjGoYy/8xteok0hcXWEE=; b=Hkpr7216wOAEbEEj5b6/nsORRdLff3vJXgs0Z9ZdTN3ogjXx1Q5hsEnzP6FVKya2OT nn67ybyOVPPkHVaWmxC3oWH+uqxwmDre0JNrt/gyWguXWDEnNUJwS7MMHJdK60W3JPcE 6BsrDa60wgSbkCGrb7lfQswugWMBNLYOnJlelfJ0ruq2G/+ZYOT5YT9iYiyLhkjbV9rE RptBNdeseXruHOCGI72Vp5JXYlk21Ustfr9/Rqb+BDHnTasyIRMqO+RoeAg5gAM3epzy /i6n3cTg8UAeR316TGl7aF+aHXlzb9j2wzec9YtHbnFmrfSrt+F6wndC4M82byVukIkP X/5g== X-Forwarded-Encrypted: i=1; AHgh+RolVRtsrhfz3J4/84Mi0E2/cGAWsHJ1hNuyh7yPCR8fHe5PxU0N2L8cd4x+oHw0g786iOUI1ODDCNDX1f0=@vger.kernel.org X-Gm-Message-State: AOJu0YwDD5hapunzgvrO4QbpKek0sCVSp7KJheZCUZY9q2niEb0dh4m4 dKVGOJWGVjWd5jcLoGMboJbADYfp4E9vLR7zXsj5NLjDSISaU2fPx9aJsy5y5x8AMc+UuwjCIdT f44qW7zDQjkFSFZsn2f/Ti5OHkpAxlXDFX8ZsOikRH+1u8Us7MdciRws1/4IfbzjSyPA= X-Gm-Gg: AR+sD12UkFjnV8B3v8sj6NOVUBFzk++UFYcNJ5N2gupRq+4qsfU69X3KX6JLDOLduwm ZPM+noROeQPCRN1PztgqgYxvzLZLW8v5OO8dEBwyw98BMvsYOsXoJ6v2coVjZ+xlhFvP4EZbe3s 5j0hD1kMdlX6AzRxLCbCGZSvCqKPReCFjqpiU3AQ80XgpMpkNIKBIuOsnpG01VpVQ2RCwuJhBYT suRbt3RlX/b3AJ91rqeI7RxoR1PSINdMP0hbMf89Nic51mk3wscbUCy9AtrjnalIz1/gmuCrLri qbppmkPmWlJmswcbZ4/86uGfrIecBlKGcbF9KK2KsE+naMfD2ebbFDyC9fYbOyNM/xQfw+CpzGT 0fj6+7g6kEOHXn9VZ7geb2/Jr+Mw= X-Received: by 2002:a05:6a21:1405:b0:3c3:a08d:5b44 with SMTP id adf61e73a8af0-3c44affc62dmr9515485637.23.1784917752332; Fri, 24 Jul 2026 11:29:12 -0700 (PDT) X-Received: by 2002:a05:6a21:1405:b0:3c3:a08d:5b44 with SMTP id adf61e73a8af0-3c44affc62dmr9515460637.23.1784917751862; Fri, 24 Jul 2026 11:29:11 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5c53f3sm1341510eec.30.2026.07.24.11.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 11:29:11 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Sumit Garg , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Mukesh Ojha Subject: [PATCH v5 1/6] remoteproc: qcom: annotate mem_region fields with __iomem Date: Fri, 24 Jul 2026 23:58:53 +0530 Message-ID: <20260724182858.1868271-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724182858.1868271-1-mukesh.ojha@oss.qualcomm.com> References: <20260724182858.1868271-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=AureGu9P c=1 sm=1 tr=0 ts=6a63aef9 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ctNy7iMIxOgxZ4Gl-TwA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDE2NiBTYWx0ZWRfX15RzRpI0TncJ RwBXuSYQYSLExxebCjh3OXJ7W2fE45Gpg/rLEvotitDir4exvNhndc3PiRPuel63SLqvAVFaCeh R/zPvFyQDxxnVLvO0JKLcqs388arsl8= X-Proofpoint-GUID: 4777ioiNpZa0NAYj_rfuPnQt7bMw4BBv X-Proofpoint-ORIG-GUID: 4777ioiNpZa0NAYj_rfuPnQt7bMw4BBv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDE2NiBTYWx0ZWRfX92QPujLwiqhc XX3aFJC0DrU9jS4taXZr2xAhsujQ9E6A0RswNM4w/LfK5xqrbqSzI0pXsEHEaraHeDJemJoN5CQ W2qd8f/MtqAzoGV784nEzMIgXh47BOYEgjlmeJcQulLRskhhCsex6KxPgrlrOWBaJRxtluP+BoO zLi8rWq551elU+W94z37WUxwBmeDWdFYnPj35Y5mn2Oguh91I8efAzanZsLuZ85h2eqJTlNjQ9g drSJBKKD4ILgmVotACHDILcIqrRgldhCE7mQh22/PSJTvh8kjdvUu+wmdus/RWRIoen4Wo9sTL+ Q8Pk/BoQ/8hfgtfUoO4Ck4OHU5Dd2KE0IzoIrW4XfhBRxjNEjRcZul4fkaGQoDR2gVqOMjn5BVl EWLIoDulSVPgTxwVqXZad2jgSoK1PJxdm9QeCznnlwKy6DQ7T6U3wlvfzcs5TOYd0al1WvpBD6P YkcVzsHtCImLxLy5PfA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_04,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240166 The firmware memory regions in qcom_adsp, qcom_pas and qcom_wcnss are mapped using devm_ioremap_wc() / devm_ioremap_resource_wc(), which return void __iomem *. However, the mem_region (and dtb_mem_region) fields in the respective driver structs were declared as plain void *, causing sparse to flag address space mismatches: qcom_q6v5_adsp.c:639:26: warning: incorrect type in assignment (different address spaces) qcom_q6v5_adsp.c:639:26: expected void *mem_region qcom_q6v5_adsp.c:639:26: got void [noderef] __iomem * qcom_q6v5_pas.c:141:45: warning: incorrect type in argument 2 (different address spaces) qcom_q6v5_pas.c:141:45: expected void const volatile [noderef] __iomem *src qcom_q6v5_pas.c:141:45: got void * qcom_q6v5_pas.c:637:25: warning: incorrect type in assignment (different address spaces) qcom_q6v5_pas.c:637:25: expected void *mem_region qcom_q6v5_pas.c:637:25: got void [noderef] __iomem * qcom_q6v5_pas.c:654:29: warning: incorrect type in assignment (different address spaces) qcom_q6v5_pas.c:654:29: expected void *dtb_mem_region qcom_q6v5_pas.c:654:29: got void [noderef] __iomem * qcom_wcnss.c:540:27: warning: incorrect type in assignment (different address spaces) qcom_wcnss.c:540:27: expected void *mem_region qcom_wcnss.c:540:27: got void [noderef] __iomem * Fix this by annotating the struct fields with __iomem to correctly reflect the address space of the underlying mapping. These regions are subsequently passed to qcom_mdt_load(), qcom_mdt_load_no_init() and qcom_mdt_pas_load(), all of which take void * and use plain memcpy()/memset() internally to write firmware segments into the region. This is intentional and safe: the mappings are write-combining (WC), which on arm64 permits bulk CPU stores without requiring the memcpy_toio()/memset_io() accessors. Changing the MDT loader API to accept void __iomem * would be a more invasive change and would affect callers. Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_q6v5_adsp.c | 6 +++--- drivers/remoteproc/qcom_q6v5_pas.c | 10 +++++----- drivers/remoteproc/qcom_wcnss.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index c81e6c33c747..39654206781d 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -105,7 +105,7 @@ struct qcom_adsp { phys_addr_t mem_phys; phys_addr_t mem_reloc; - void *mem_region; + void __iomem *mem_region; size_t mem_size; bool has_iommu; @@ -318,7 +318,7 @@ static int adsp_load(struct rproc *rproc, const struct firmware *fw) int ret; ret = qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, - adsp->mem_region, adsp->mem_phys, + (__force void *)adsp->mem_region, adsp->mem_phys, adsp->mem_size, &adsp->mem_reloc); if (ret) return ret; @@ -492,7 +492,7 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is_iom if (offset < 0 || offset + len > adsp->mem_size) return NULL; - return adsp->mem_region + offset; + return (__force void *)adsp->mem_region + offset; } static int adsp_parse_firmware(struct rproc *rproc, const struct firmware *fw) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 25599d728208..9076c82ac878 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -101,8 +101,8 @@ struct qcom_pas { phys_addr_t mem_reloc; phys_addr_t dtb_mem_reloc; phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT]; - void *mem_region; - void *dtb_mem_region; + void __iomem *mem_region; + void __iomem *dtb_mem_region; size_t mem_size; size_t dtb_mem_size; size_t region_assign_size[MAX_ASSIGN_COUNT]; @@ -243,7 +243,7 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) } ret = qcom_mdt_pas_load(pas->dtb_pas_ctx, pas->dtb_firmware, - pas->dtb_firmware_name, pas->dtb_mem_region, + pas->dtb_firmware_name, (__force void *)pas->dtb_mem_region, &pas->dtb_mem_reloc); if (ret) goto release_dtb_metadata; @@ -321,7 +321,7 @@ static int qcom_pas_start(struct rproc *rproc) } ret = qcom_mdt_pas_load(pas->pas_ctx, pas->firmware, rproc->firmware, - pas->mem_region, &pas->mem_reloc); + (__force void *)pas->mem_region, &pas->mem_reloc); if (ret) goto release_pas_metadata; @@ -447,7 +447,7 @@ static void *qcom_pas_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is if (is_iomem) *is_iomem = true; - return pas->mem_region + offset; + return (__force void *)pas->mem_region + offset; } static int qcom_pas_parse_firmware(struct rproc *rproc, const struct firmware *fw) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index e9a00efe97f6..c856a92af43c 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -94,7 +94,7 @@ struct qcom_wcnss { phys_addr_t mem_phys; phys_addr_t mem_reloc; - void *mem_region; + void __iomem *mem_region; size_t mem_size; struct qcom_rproc_subdev smd_subdev; @@ -158,7 +158,7 @@ static int wcnss_load(struct rproc *rproc, const struct firmware *fw) int ret; ret = qcom_mdt_load(wcnss->dev, fw, rproc->firmware, WCNSS_PAS_ID, - wcnss->mem_region, wcnss->mem_phys, + (__force void *)wcnss->mem_region, wcnss->mem_phys, wcnss->mem_size, &wcnss->mem_reloc); if (ret) return ret; @@ -327,7 +327,7 @@ static void *wcnss_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is_io if (offset < 0 || offset + len > wcnss->mem_size) return NULL; - return wcnss->mem_region + offset; + return (__force void *)wcnss->mem_region + offset; } static const struct rproc_ops wcnss_ops = { -- 2.53.0