From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B8B540682E for ; Fri, 24 Jul 2026 18:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784918517; cv=none; b=U/KApD3PmXuANcNMxDN4gl342LDEDifeN6G9iOReHKYMsUfERqgfdo8G/1vI+bJRzVhXTc6H490OLqtUoVelZycIaUt9gjfR/hpJTILpAkD3W3thtrrTBMU2QQT8s90fdlCgqYwsA3o0+mzs9noFdShgb8jYFjBqyAcINX/I6Qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784918517; c=relaxed/simple; bh=qNZvK7+AlNN2rB1roG+QzHztK+rI+mX+6qlTqpAyUSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WaEnj+m9JbPLXGSpkk6jsYZus5hAzYrj7UC3Dk+fX89FOLXdeXqNNQa0jPOthLenopaB6L9TMUpN5hRzmE5oTqFSGkJsa3nJvRletYbEoumlaagl5wdZ7MNwa5sgfYg+U+LBrZ2BDYOzpoGoviZqKKWDVdZptX+fevWKb3kHtO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bNu8HQQA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ckRk2eti; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bNu8HQQA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ckRk2eti" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OHBPKt3683649 for ; Fri, 24 Jul 2026 18:41:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7o4JihoclNc NdJZNe0ixXAAbiKqntyluapfzy3jSsTs=; b=bNu8HQQA9zdcauZol1AcpFm/tW1 r8rvsJTazUbRV+po27H/CEkb2FcawQ7vhFc5p10O1WqMMhGpf3PHzNPz/4GMA6cK 7zMsV56Lvvn8twfoxGhHd3htRTuV7RfBrN/DOVIizuinipXFlc/ebUIfXU68g6pT xlwPCdMYJAGWUpr5HrpfIoKlcmCoR0u6sovfCpOZxprwZ+dbC2IgMXcueFyxdP1t 4P7aBC6s4JqHmhnr+Zp+MPS23Omu10SrJkCnawCj4Tr9Z4S0kHOAq9UVbTn77gme 66czs+XGjXF9NS94Qr5qxd2Xa7DGpkfHP3X3dBnzIgeUYAUELTUhqokYKXw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmc7x0a5q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 18:41:53 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so1133590a12.3 for ; Fri, 24 Jul 2026 11:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784918513; x=1785523313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7o4JihoclNcNdJZNe0ixXAAbiKqntyluapfzy3jSsTs=; b=ckRk2etiK4GSdvmXXikpk/UP4gXFiSwfo0ST2NB42kLp+U70pwPF0Lu8Vu9+2pwcxl VJckcb9Hl8GnTNkExoapZhcu58YZzyKbrFTF1JVpDwvww7oripD+3Eut2RRBIGqKw0Vk ANWyj/tigmubTMJz7gIOJaq0Ja5qlor3vMDBTsroI9nzU3Q1JBr1cM5H48tI5ean/0Xw hX14sSU099ySMs7iAt6AR/KCAWv8ZEvfP0Ur0SCDwPeT7lcm+By2l0iHVe5a3AzSR0gr 2v3DynjsAtxEyQ+CMtj8XaFc7wlGqgUHrVhw3/H8UgWBLupiAXxL/qHgSkZmeRVOiTKB CCMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784918513; x=1785523313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7o4JihoclNcNdJZNe0ixXAAbiKqntyluapfzy3jSsTs=; b=CmqGzOxCBj8XgbmEyoSiguIfnBhXjUp6fVRRaXQAj738DGTsQ+IgrWlAe0wjosUDeT oRYjwaGA8iIJsh7WrOCRqX01SRNIVfdLYFolXH1M3QytwlDakBewZb2dem/+rx+hys1H qMm4bVJUZMHQOAzsInStovcdOxEIp1lS0+f7zaLYp35Ww/tc/Mb+Cu/yqD+hE9mAF86U LOv3A45j+6AiPV3eLdBrSuFv5S+bm2LCdfOaYDVdf2gsujDZAOjkHfWhlVIb+eNdOuHL IrcDDNQvCiGhWhS3/aBgSRRXJLb5eSsPZz0Ff2gcVG0uW9HgkdI5R4T1II9Qdq59YGek 8HBA== X-Gm-Message-State: AOJu0YyzEfvyIU6EFI7X9zNgip1Spc/tRNsl+zTUP5d8hKziWuxZSztZ tsHAYfENGFdb+73J2B9SM5UgU7E4ZdbHzEZUf/1wFPbizQjxl6GWx5lflYxkUULlppQ5VRhIAk1 2/Fs/TiBvPl84HmuBGNbX1xbvosZrUnIzPHrHTZ4opHyW1NpJbTne+IA/3ICghfCrlG4= X-Gm-Gg: AR+sD138qERP3wd0/OWzi8ATRlWwtsBAz67VnuOcqqm4H70l/W24vcZlrk5FvRlytd+ Ng5k9A+TC0t+6L9EY1d2F3FypsSAlWitK6B3Em1/2riT61eQ61vxpQR2n5mUGAJd9HaiP0jNDzO mIAnWJKjQwrpNFtTn16Jld2Nfw+prYHQxX146y2m1HjHbpIUOxLvqfbRWjTpVMxdauTZNhE1mhQ 3T4WVm4EugtiPV0psHmOyYhrbruXOlXavAG529gUzdB5wN+bW1JqvBiy27yuhG/FnuG2g4B8ro3 r1MH7RVcCtADNwVrNAbJW/+SwJhUD+50SayMMl1IpcxF4K3U7tb1rfEUFzoP5UO8clNKAxNwfa5 dyP9ag+bvwxp6F4nmFqOHZXadoYA= X-Received: by 2002:a05:6a20:2d28:b0:3b4:81b4:9b79 with SMTP id adf61e73a8af0-3c44b18d9cbmr10519008637.40.1784918512874; Fri, 24 Jul 2026 11:41:52 -0700 (PDT) X-Received: by 2002:a05:6a20:2d28:b0:3b4:81b4:9b79 with SMTP id adf61e73a8af0-3c44b18d9cbmr10518978637.40.1784918512352; Fri, 24 Jul 2026 11:41:52 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm2222283eec.31.2026.07.24.11.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 11:41:51 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Mathieu Poirier Cc: linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Mukesh Ojha Subject: [PATCH v2 5/5] remoteproc: fix OOB read via signed offset in rsc_table_for_each_entry() Date: Sat, 25 Jul 2026 00:11:32 +0530 Message-ID: <20260724184132.1878077-6-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724184132.1878077-1-mukesh.ojha@oss.qualcomm.com> References: <20260724184132.1878077-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: PcdDrPXrb4VUlOPU_TkA6NzzaNI6aKsb X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDE2OCBTYWx0ZWRfX3cG+k1Pnbl7S MjbbRjYJMoCG/aFdlaYdUz8txOvw9G6baLj2KOZ+9Q2wwjbWDRQX7o2ankauHYKEbS4/xwMuDIx Oq5QYacQu9Ba57q6Dxv7u8lb0r9ipFI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDE2OCBTYWx0ZWRfX7fIHdbIzOyRf infnewO77qBuajspmKvOF6g4MsgfcWQeyl4g3yrjbMj2DfmFH1w8GvvnVkNBg37NzDKr7j6yO6w Z7Qo+EM0qvG9qAgptKHuN4qDtI2/a1N/bJ+/JS1FO2+Tk19ooMBfjCe73VGEhOnMKLPISH3B+Ju DyVhy4mdEpwYIGdUwyR2ltSDcbncTzNlKsMt7rspWrBhWMEizO4inU57yL8mPYO1aj5Edb3VM2Q saHHSDDbNNHqEggpIdEwSG2nPMamNtOcASqpXYAMSIu3Myow6PVqg02h2bnMXLVPsiUWMXFUWiz RW25iOt3B/wbKrpksOlhmJsuo1rz0waSi/H9NYn/NAtmU9u0ofVWm/t61frvmJFua6Fhhbxl1MO aEIPTos4gBbNRgFqW0SZxx3JxsXO3I08uQdkOzbOWdUJSJZ1qA76Dmzzk45fuZ1sAKCkvg+W39h 02npy9bI5cagYjli60Q== X-Proofpoint-ORIG-GUID: PcdDrPXrb4VUlOPU_TkA6NzzaNI6aKsb X-Authority-Analysis: v=2.4 cv=bOUm5v+Z c=1 sm=1 tr=0 ts=6a63b1f2 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=_5PO8_XNLmbmSLjM89cA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_04,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240168 table->offset[i] is a u32 from firmware, but was stored into a signed int. A crafted offset like 0xFFFFFFF0 becomes -16, placing hdr 16 bytes before the table buffer. The subsequent avail check was bypassed because the negative int was promoted to a large size_t in the expression "table_sz - offset - sizeof(*hdr)", yielding a large positive avail and letting the out-of-bounds hdr->type read proceed undetected. Store the offset as u32 and validate it with unsigned comparisons before any pointer arithmetic. Signed-off-by: Mukesh Ojha --- include/linux/rsc_table.h | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/linux/rsc_table.h b/include/linux/rsc_table.h index b78c4760d83e..f9c5628e16cd 100644 --- a/include/linux/rsc_table.h +++ b/include/linux/rsc_table.h @@ -338,17 +338,22 @@ static inline int rsc_table_for_each_entry(struct resource_table *table, int i, ret; for (i = 0; i < table->num; i++) { - int offset = table->offset[i]; - struct fw_rsc_hdr *hdr = (void *)table + offset; - int avail = table_sz - offset - sizeof(*hdr); - int rsc_offset = offset + sizeof(*hdr); - void *rsc = (void *)hdr + sizeof(*hdr); + u32 offset = table->offset[i]; + struct fw_rsc_hdr *hdr; + int avail, rsc_offset; + void *rsc; - if (avail < 0) { + if (offset < sizeof(*table) || offset >= table_sz || + table_sz - offset < sizeof(*hdr)) { dev_err(dev, "rsc table is truncated\n"); return -EINVAL; } + hdr = (void *)table + offset; + avail = table_sz - offset - sizeof(*hdr); + rsc_offset = offset + sizeof(*hdr); + rsc = (void *)hdr + sizeof(*hdr); + ret = cb(hdr->type, rsc, rsc_offset, avail, data); if (ret) return ret; -- 2.53.0