From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D4138734E for ; Sat, 25 Jul 2026 08:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969698; cv=none; b=j++xf6NDizOCQ1yRuadW0NiQxm9ozqU2KzO+rw2VknqM8E+KMStxTcTJJljSQcx12zxhWfn0GYjHR2qigsxrkRhmwFczwNsSdXTxTmplmfxjWK8SK0noor6hqJCPqzZvWZwNmBknWVO9G2gH581g0sXNYE7gGBX+YeQIDKmLghk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969698; c=relaxed/simple; bh=xiW/dPZnS98zYyoDoyUDAjW3pvFKrz5PgiyqhLjHMXU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lcI/Dz+lcKRgowiScNS1reR7a/0HqTduI9aRJwW2QgXy/1crb2/Tqap9Wh+uuHs7epySNymu7SN3B8FKxGe0jXLclzFDIpuntyUKrPI4xfc+r8o26KLcgrEbgpn0FfvXb4YZGaYVNeYgp9c8lUwlXoT3sMPmrOMUaNbPTLJ8A/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NL6fQi02; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BHrdT7qG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NL6fQi02"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BHrdT7qG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66P4lEFM1145311 for ; Sat, 25 Jul 2026 08:54:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6MS8QdQp2SVXWBPY4VxZs1mNPKYNEyJucnvWMesmH7A=; b=NL6fQi02KehZdRDp y6HVKwYnq7P3f2XIBYQpaCXnaGEoZ83sYFlmJI4xVOKPEsPxOhYLJrSrDzd4SvRk A8uluKy/WBNhTrypEKyPe2hZxJIlVh5x1yBiIqmc9TqD9VEbNlG6W9YqmuMjVR2x sV7jrQvAR1X2q4R3UfTmAsB5CgulNIgwsqHCn/w/FI8nvaElf1Xg/7REaFfJM0Cx iYg4cBeIcjj6lahwqNLTvrMl1qiX/n5RTJqwo9NH3AL18YcQ0L+vO/dTzsvAaSfh MtfMHcHXx5hfa9gcqgZwcoZ1biqPpYE4IJXBQrA7Q7l++XYwcjLmkbzP5gQHcgyA 3DiiOQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmm570pky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 25 Jul 2026 08:54:54 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84c2c8f0a54so280289b3a.1 for ; Sat, 25 Jul 2026 01:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784969694; x=1785574494; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6MS8QdQp2SVXWBPY4VxZs1mNPKYNEyJucnvWMesmH7A=; b=BHrdT7qGa+EjoPYFJnb3Y8qo9FUwU1SmnWAHi82z6BGTuaqoYnREFOlckvQYiE9MLB 9uoBc+EZXHeVGqUDiqIG4WjRE9RoOyAptINBxUag4w7JQQW85w+Nowxog+sg3BYOChCX SfH6s+bt7o8HsIf91zq7Zaz1gr/hHEVzR3hXJ4pj2WW570vpvUGqWJc/XcjNyVCtxzOc m9iGZX0hGKMNtzC7HBj2hn9R/nzaILQv8CbqbTviQm2to6/ghg8zPFX7z22OqJkLXpeg tjdB1DZZrb3N8SCatQdaHBngXNxK6KpeuSNngHpvyvgQ0NZOQtF8qOfmgsSa4w0MrmOk 3irQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784969694; x=1785574494; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6MS8QdQp2SVXWBPY4VxZs1mNPKYNEyJucnvWMesmH7A=; b=gi1Y/e4t0gRJm18pHD1W5HjiRJ/4SNIbgVYrwJGR5gUaZzVCwVsUPgIeDNqLv/lmfG w32slSndmbUuSNARiFKEjNZQa3G5DvhQDOCyK28Cc78G+Ny+L754dupTZIuj0FF0axAd 77IGQKezmqU1jVAjuxVLjVv/0K+OetcOSmhQMRM061a6q9lIckBle32Cb7Dz0sImqv1R pGaTsIVNyQ8oV0oCzLt4s5gXe9wycbngXM54ZtRzIoP176dKOsc1EE+TVSDYxuhF+CA7 xWJZB7ZKBouKLSxJjpisRizkp7gIhwY1I0hqJsApllWPnZqBtEH1mewWDqOAx71rFFsz TD8A== X-Forwarded-Encrypted: i=1; AHgh+Ro9yPMvBZKpOZxfcJRMCX8OU8zXW9mgW4hHJTgk+NzZ4ozZqcZnW+JAI1s8jvnLOo8KMlSWjUSQIPqpDhc=@vger.kernel.org X-Gm-Message-State: AOJu0YxOLTTxJQiLPZxaM2x/mUlV+qrtaOeYh6tOhuL5CF9s4LIO3dfj Bm7xQ+RBAfD52aiBHdEFQwFXXXZZShoAZ3pcOPeWsOK5pg0rpypE6Tn3inQ/ti6kPqfsgM76/2N y98CZ8j+2Q5DF1SSZhKe8yP9R2kXapd5owQTLhcx3a+uWkFd9Gt9Jjh2Z6JtWJy3uW5Y= X-Gm-Gg: AR+sD107MrhEjmBGNW5hRS1A6mgpQM6CABHFvvlI5NmQ4Vt8bum0UhaYE+qrqM34tvQ D3BFS7LK8dcTLWYfRvmBiiBg66zXYTnHZ4LW/2klYE6iD7OnJsVbJGctll1aSZSD7ydHeN3ZEyf SUff5Eh9+qyVHiaueUPP3kZTdb/DJ2KIWLb5ePd0e1jyoyk5gEp0cPHQjVpY8ESJxR/56kXC2jC fy0uzsckAv8LDNPSzuUREJCOgI4oPPNVsUdd/6R/xKlF0y2LXWCpub4zYI9cQh9j8F84i4jsFJi Leyge80OqHlWLtEGCmx2bCGDkv9b5DwyJFvBLI7epfipIGhLyaqtyVTCki6BOcesplj6Pq6WbPR 8HWF8RyY32BKdeHjJTNyY2kbvjT8rFxr3oouPLpuSf8Dwg0w= X-Received: by 2002:a17:903:2f84:b0:2ca:d803:5c8f with SMTP id d9443c01a7336-2cfde689443mr13623075ad.1.1784969693650; Sat, 25 Jul 2026 01:54:53 -0700 (PDT) X-Received: by 2002:a17:903:2f84:b0:2ca:d803:5c8f with SMTP id d9443c01a7336-2cfde689443mr13622985ad.1.1784969693252; Sat, 25 Jul 2026 01:54:53 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc419c52sm7823000eec.10.2026.07.25.01.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 01:54:52 -0700 (PDT) From: Zijun Hu Date: Sat, 25 Jul 2026 01:54:39 -0700 Subject: [PATCH 01/11] Bluetooth: btintel: Fix diagnostics event detection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260725-generic_fix-v1-1-305aec261a19@oss.qualcomm.com> References: <20260725-generic_fix-v1-0-305aec261a19@oss.qualcomm.com> In-Reply-To: <20260725-generic_fix-v1-0-305aec261a19@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Chethan Tumkur Narayan , Manish Mandlik Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI1MDA4MyBTYWx0ZWRfX4brydlb1tYR1 rf6M25FGG6QOu0LOzTo6XSH/kkVFqg5falFK2p1J+5DYEaBgvbE08J8A7P8oMRvXBjeq4mSoUq9 r7TqKqqYNZ72h7KcVC3Ryt+wWFQ80BA= X-Proofpoint-GUID: IewlRswclGrKR3bkv9hK5PaY1HfYJoSs X-Authority-Analysis: v=2.4 cv=FOErAeos c=1 sm=1 tr=0 ts=6a6479de cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=w585p4NK48lv-ZABhGUA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: IewlRswclGrKR3bkv9hK5PaY1HfYJoSs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI1MDA4MyBTYWx0ZWRfXwzXqd/i0bcMl snX3mkN/fE9cW7rEPSIX3Y7XqP7YwiO+ScXYjMLSIHXP5sTLhNm+DUii6AeSFRzlV/JdsXqSjuC zz7/7ASDPn0b096vEvhUjV4BN6KRMnnuysyy2KjDo56mNJXP9EaQ4hIlpgvMnFyGCeMoNXcvXls XmjaaUuHjABNUThWNbuE73de5aD4GjMNdbBMUAgeK7dX7bYjPxPp98SvLqjTpVwZ8QhrYo/8d+B r62jkXvHpuktwSXyAUXdtb+m78pSdYgHdjr7S76poAMUVTiGz8S1DeieN5yJHtjve/fwhCBMrYn jGoe0uNwBchuHzuxKsIY3lb1X2FLj5okXjIZkq8ODFE+BOJkI53okmoO1pN2fWwW/Hz4qTfOvpv MG4T8AtJGOnRXQ2UzGv4xQbGv6s0QvBxZVMR4EzZxKOqXmjH5YvLiKkF+E6qNIsVkQlSm06VNx/ Khi8PzvOa54nnFed/qA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-25_02,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607250083 For a diagnostics VSE, diagnostics_hdr[] sits at the start of the event payload, skb->data[2], but btintel_recv_event() wrongly guards its memcmp with @len, which is measured from skb->data[3] for the earlier INTEL_BOOTLOADER check. Fix by using @hdr->plen, which is the event payload length, instead. Fixes: af395330abed ("Bluetooth: btintel: Add Intel devcoredump support") Signed-off-by: Zijun Hu --- drivers/bluetooth/btintel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 5e9cac090bd8..d7baf1b9d852 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -3826,17 +3826,17 @@ int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb) kfree_skb(skb); return 0; } } /* Handle all diagnostics events separately. May still call * hci_recv_frame. */ - if (len >= sizeof(diagnostics_hdr) && + if (hdr->plen >= sizeof(diagnostics_hdr) && memcmp(&skb->data[2], diagnostics_hdr, sizeof(diagnostics_hdr)) == 0) { return btintel_diagnostics(hdev, skb); } } return hci_recv_frame(hdev, skb); } -- 2.34.1