From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6959C3932D8; Sat, 25 Jul 2026 08:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969983; cv=none; b=Mzv/ed3jSyJ9P0BLnp9P1Lh6pHDcRQu1ZgZNpoNlCH41GLNPHgID1GByuYeIJTDjA2IEWj2DkUpPQfMCCCM7C8b8GF55QPCm9Y6ISdTl8+XPyvYpXU5+0QFLXWNNQLa6+Si86vZ7vi43AveHmn9oj5yvT5qNjevW6Wbj9ugdMO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969983; c=relaxed/simple; bh=M2vuFcwrXHaPCwsxtaEjo4x3S8tmHOyoK+Ae3ahk9rs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kWj+BTjs2VgJiX2tRvKnPN5sD1rqXi8O/Em/6SjjZzI1SgXIg3b8DUt77Z1ZGEMWgiSyXCZetacZQMt//ok8rktP3/9Rup1ZQ6L5VOCX4JJJ+WCPPv1QkxU6e209LSabtvbVaWrnGj36v0w04YZ77KSs4Gb/5ktSKioQRYilp/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LQfVGuqp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LQfVGuqp" Received: by smtp.kernel.org (Postfix) with ESMTPS id EFEDCC4AF0E; Sat, 25 Jul 2026 08:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784969983; bh=M2vuFcwrXHaPCwsxtaEjo4x3S8tmHOyoK+Ae3ahk9rs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LQfVGuqpx1ezyVae5q6BD5x74jNE/cMvV0MUlx7UU62bYdIPVUa3QyAKVLpT/fCOv CT/mbneuOeAldjQwC34HhFwsr6cFtdw+NHLsSPuxLv+l/MIha3IKSwrGfkKDUrY8mw NXsHH5i2HeGqklWe1/atQdo+q8InrXRkIpxibJ9/Obj5aLlKGhcWmW18xQnlLDpBPn 60wRVXo3EEzywuG+CoS+PgvOAws/Nu2JSRHmBkAco+DpR6ln/kkH7fDy0hwxErHxBZ BoUdXmZdPE1bRtX/MZcWlKvYUTTeAdkgVaoxbYL7DjuX7kvkRv5riAU1Z1nh2OLGrM 3PgWdli4wnoTw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74D3C531F9; Sat, 25 Jul 2026 08:59:42 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Sat, 25 Jul 2026 10:59:15 +0200 Subject: [PATCH 3/6] PCI/pwrctrl: tc9563: Power off only the external ports in tc9563_pwrctrl_disable_port() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260725-tc9563-fix-v1-3-ec4286e31331@oss.qualcomm.com> References: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> In-Reply-To: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Chaitanya Chundru , Bartosz Golaszewski , Bjorn Andersson Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Elder , Manivannan Sadhasivam X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1339; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=zLYATUwqJ3rAN0h7YuF5xAqQqTi6vwxszqFTr4nRMsA=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBqZHr7A2DEm6RUDhHmyToj3odcB1cKnGmF9o5z9 kfsCC8tQruJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCamR6+wAKCRBVnxHm/pHO 9d4WB/9yg3CA07T7iVSwySkVOdD4XhS+kDBwzPz2a/p0JMMRNgNkiMYw4Ar6PnY4QvX2Usp4B4u QhQ/uWrT3fdre9DpIMTe7CdGEfZmIpY1PhChddS/qL+W0aW3oqi/30Ovlz1jzwnmYWcQXCMXatr k1WXlFYrLP0DaBTIbUFGS5hobqe2VBgGDV3vZ+ne+BbRe4XEK+NQRM/Mwh7Y8Yqq1pP338bbRVv 7VJfNDxOWYXXYcSm3GPISLknXQyNJPFuNQJBxhFXGNEGwgHI51w4TRLDKhf0Hiyy46g6dM9K1Bj 2sn+vG0GMQKFprISPs2GEAmeh/Zu1Hw7GAq/9rNtbOesjkVd X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam TC9563 supports powering off only the external facing ports like DSP1 and DSP2. It is not recommended to power off USP and DSP3 as they have fixed ports/endpoint connected. Hence, fix tc9563_pwrctrl_disable_port() to power off only DSP1 and DSP2. Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563") Signed-off-by: Manivannan Sadhasivam --- drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c index 482e82e433dd..ca19bf60d290 100644 --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c @@ -241,12 +241,18 @@ static int tc9563_pwrctrl_disable_port(struct tc9563_pwrctrl *tc9563, if (!cfg->disable_port) return 0; - if (port == TC9563_DSP1) { + switch (port) { + case TC9563_DSP1: seq = dsp1_pwroff_seq; len = ARRAY_SIZE(dsp1_pwroff_seq); - } else { + break; + case TC9563_DSP2: seq = dsp2_pwroff_seq; len = ARRAY_SIZE(dsp2_pwroff_seq); + break; + default: + /* Only external downstream ports DSP1/DSP2 can be powered off */ + return 0; } ret = tc9563_pwrctrl_i2c_bulk_write(tc9563->client, seq, len); -- 2.43.0