From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41F6439185A; Sat, 25 Jul 2026 08:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969983; cv=none; b=ArrcwU7UXtmuyDvPzHm3JzjKb47lZBef/NnZMa6d/IaI7Zi5nHP9mbDDJlXgH2sa51BXP4a7EQYo7nUaNJ/wFLoYD3lliRMZ0N+gVtWM+EEeTY69mFTd2N7cuOzNDlksKv3bQPaFpnwDrmoPp7O90633dGUjH7B7ywOa2I0MNfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969983; c=relaxed/simple; bh=gJCqQ+ls6Akl2xg5rfI3vBzdw6CDZdsdxI56pKMlR84=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jRbdAt92GKqUwMdWWBu2mNfbB2YB+xkTc9FqLQHwB0R7rQWRS9ilQoa9Co0sasID5Rm392RaMiGQJNeAYAEa1Yhs0HrdbBcNp2MeI2920s04d3oEwSyzFuOmmKYWLqC0iNL/p4wsB4pqbNxiK+Bmls0lAXPLCoUhJ1cS7FBQ8T8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oo1Kgu/F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oo1Kgu/F" Received: by smtp.kernel.org (Postfix) with ESMTPS id 11F7DC2BCFD; Sat, 25 Jul 2026 08:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784969983; bh=gJCqQ+ls6Akl2xg5rfI3vBzdw6CDZdsdxI56pKMlR84=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=oo1Kgu/F6fU2Eo5OQahAIFu1EUv2t/odZBqaS/P1zsK8PKdIxLqPWD4XAdxxy8liE +9ABDQMwJaZ8xZ2WDVd8HEh49tPy3shZ2oxhUEaw+cbFCR9TNkoh8nCXGd47HXl/Wg qm0dZWrXiAZvH+XH/kLkc0aSVaEWM4cYfuNRhqcEwYRwtQl8skjjDwSwLgu84uYQgz IvoICDrJ5/bnqm5+wouoJSFDIrU/Desr3ZWkgXBp8fbnIC/cGBofbgPI69wxC21Cbe ZNisQkpBCsKcgyKGxvy7WFzi5SQlNgbBk6gSW8QJgNvrwjUjFvGk6zgYmN0mMdDOn9 GWcIX0lNINbzQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE457C531C9; Sat, 25 Jul 2026 08:59:42 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Sat, 25 Jul 2026 10:59:16 +0200 Subject: [PATCH 4/6] PCI/pwrctrl: tc9563: Skip Tx amplitude and DFE tuning for DSP3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260725-tc9563-fix-v1-4-ec4286e31331@oss.qualcomm.com> References: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> In-Reply-To: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Chaitanya Chundru , Bartosz Golaszewski , Bjorn Andersson Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Elder , Manivannan Sadhasivam X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1891; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=EGn5tsg1B9QVm91PpLmPy5u1U7n/Z+bnKmRxSSYCALc=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBqZHr7SNsPHW/XY2MtS+D+0iYl7FOL7fzBOEsDv nuI8tToBCiJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCamR6+wAKCRBVnxHm/pHO 9aiIB/9oVyGHq7cs4RtEXJTvESJLfesplg08buYt36fnlVhHANez0x/wXJRmYJYLQskwdAbN+GP QMJFGGCfr5lCKA0FPbvNhOGee5iHjcJ28Ro1n7FyAHRZ1cMWRqmieXzhzpFYcDssFEYUXh+hWN+ 49F+GUWuTXBVz6PZ3XnGeErlLw1EsBclbJb5kKQ/00WgI2AXv43Ohg9m7bELF3nE2AlNk55D//N JNMN60F4MdyEnjYImcKMa261HpflEY6Deoz+XueZowKjJb+x22GFOREhFyGHEWUL4zMWa3VIYYW jXW3RZEzgJsH6jBXrC3POjtASr/UWcdvPo/AqUxMD5JlnzxE X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam DSP3 doesn't support tuning Tx amplitude and DFE settings. So just skip the setting if DT has passed the tuning properties. There is no need to error out the whole driver because of it. Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563") Signed-off-by: Manivannan Sadhasivam --- drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c index ca19bf60d290..28e9ec3e172a 100644 --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c @@ -308,6 +308,7 @@ static int tc9563_pwrctrl_set_l0s_l1_entry_delay(struct tc9563_pwrctrl *tc9563, static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl *tc9563, enum tc9563_pwrctrl_ports port) { + struct device *dev = tc9563->pwrctrl.dev; u32 amp = tc9563->cfg[port].tx_amp; int port_access; @@ -327,6 +328,9 @@ static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl *tc9563, case TC9563_DSP2: port_access = 0x8; break; + case TC9563_DSP3: + dev_dbg(dev, "Tx amplitude tuning not supported for DSP3\n"); + return 0; default: return -EINVAL; } @@ -345,6 +349,7 @@ static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl *tc9563, enum tc9563_pwrctrl_ports port) { struct tc9563_pwrctrl_cfg *cfg = &tc9563->cfg[port]; + struct device *dev = tc9563->pwrctrl.dev; int port_access, lane_access = 0x3; u32 phy_rate = 0x21; @@ -363,6 +368,9 @@ static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl *tc9563, port_access = 0x8; lane_access = 0x1; break; + case TC9563_DSP3: + dev_dbg(dev, "DFE tuning not supported for DSP3\n"); + return 0; default: return -EINVAL; } -- 2.43.0