From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0577309F1D for ; Sat, 25 Jul 2026 01:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784943544; cv=none; b=k4WDrJ/cLCkfdZ28lIonvhzXUdkTf457mB4DJm5/qVxxVLPrRWnLhdvH+kGbtPLVqFtMys1ECF8hICdVBCaBHtUErHHMP8/8e3lU/l58psKwrYhwAINMYhjCk5Ky4GE8H0Gz7cXVuklDWn6MRVYzzEwQOl2lMJRl6ajl8b6GNMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784943544; c=relaxed/simple; bh=nhJB1o3/CftC74m/SJ7OOWafTqa/vTIxBKtN0cwNfC8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=i76ZJXBpwoywelbo9ka3vc02HxlUb0i/J5WX0wiYMyCFSxQk+LSIdK7ZQgGIX9tYwjzVR6E4cAzyIPmhtI2cbAKIQwbqpxp7oMkLlZhvHWxoj5j44q79gMrmnbaoxdnGCTxja8JSGNBCMapx/qHACFZaOprNztkx0cUvoWs8Wfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n8RWApPP; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n8RWApPP" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-4960a66d36dso125096b6e.1 for ; Fri, 24 Jul 2026 18:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784943541; x=1785548341; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xcYSfZGUx9sUchaQp0uiGsngi9HwNJwG+1+PdhVxlSU=; b=n8RWApPPiNavLQwTUSqX1O7QBEE1JfKMfE6Lx9NJjOd88WgLOXmwrUaWWitAYXvWit 6SjDPJR895lWuRn3q+j3y6v8OWG/BXXguFzUK++OEpqvDJIaBE3gckTi4wIxM2S3HPFa 1aigT9mpvG6VX4WzjCwOSPrtKLRCdSp2cHMBVpUfeIFaCKVBObiJzzN5FoWgOfsDKaQz A32vFkIxCLT+euHUrYVlr2XEXjlf/xtbEZFxaCynuabD4QQbjLbiNHEz92D20/vflL4S 3boJIJyO/hUNQGPmv6D7bmceCktlvav59hkLADDIQqIhF4wsnI+D8iKFHD0CFXhmYhq1 pSRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784943541; x=1785548341; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xcYSfZGUx9sUchaQp0uiGsngi9HwNJwG+1+PdhVxlSU=; b=UlLeYOEJuNMzDvfj0t24u+DKHuXCyezdMjF1sruiU5wRE1TzgNmFC1ne8OLXDTl25c gSCRWeJ1vxYilM004xho62M8c20aFjbHONClLnArbPNHDk4wc0BHJeQMpqFeqv0xgY2b xHTMOzxOpsBANGb75A4pLuYB+gtCqfGp2NFWoLxSdMbBJnnGYoPP1zWuOUW8oNq7/NK6 UECe/uBb0UOuCj6xeSfmHGg3Fx9cEmXxSlnv2QON6PXe8xny/zhlitSa3JMkGFKw/m++ 4UrVbqxBPpb8XGTg+eliXeyAPNGqTXtyWulwwwWbqB0i0qXujrBi6pAbxKSSf+GwImfp +wwA== X-Forwarded-Encrypted: i=1; AHgh+RoV5iFMPfj0DvqCx1qtp2XEjyWygXM6GnJX/sE54uESVFt+Wk4RbkybySTNdc2zKglbzhGGTdbp0yS0qrA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm3dWZDig7xLBl2MYeKdoq5jawq4ThW5ib/YqVRVHk3KbH1VnD sxdHvXUsOA/hyKl5gV4zG7Nin7a4LDxXN9xF4nrL+3i0QTLvwF6WLDTL X-Gm-Gg: AR+sD12dKhOdhrDkmNu81SnmUIUH5kGHPFgtDwECf0Ztz1/BTb+d0ivzQwDAewUhEfw blkht8riEDEVQyynP2jrDPd+BrwSGp41BeowNwhAkyVGghJpjBjCkrCNJ7B8Ppt4i14Z3JB42Om 0NsCxnC7RKCZqoftkv21To95xZ3ci4smyUJMVAIfV5uQWp2RJ/8S2raWIUvuPuYHLI86zhhZ4Uh FS2YNhHC3iT1xY0f9Oz6TYT6i5kX6o0l1qVw/v8rsZhpvc0a3iiWdcKE3dP83AM80NkxV8kdkl5 5aZEfuxH4ICGsuioA20OxC0hxncMtLDW12Gz4WyA6Fe/YPkgKRwqsXTXPL8gjrj5PeRklMI2uc+ Yh0R1TJldzUjNFPt0EJO0uDptjtYlnwx38zZxnjfWB3ey7PGbDeDecjVADMhOdTPcD/V2h9+4WK lximdHnEY9IdAF/PDoLVQFV7+eJ5hbI/tzWHCWob5hjm7m20XNZWXrhElCRIm8VEpHjLmF8VOJw EM0 X-Received: by 2002:a05:6808:2388:b0:497:da5f:d5c3 with SMTP id 5614622812f47-4ab6a1e912bmr607781b6e.6.1784943541506; Fri, 24 Jul 2026 18:39:01 -0700 (PDT) Received: from antares ([149.88.25.215]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4ab2cd31929sm5643564b6e.4.2026.07.24.18.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 18:39:00 -0700 (PDT) From: Bogdan Nicolae To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Bogdan Nicolae Subject: [PATCH v2] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Fri, 24 Jul 2026 20:35:28 -0500 Message-ID: <20260725013528.169218-1-bogdan.nicolae@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero out auth_status on initialization. Otherwise, garbage will leak from the stack to the firmware (when ssid is less than 32 bytes and/or when params->pmkid is set). Then, pass the params->pmkid to the firmware (without it, the firmware caches a garbage PMKID on successful authentication and denies a subsequent association request that includes the PMKID). Signed-off-by: Bogdan Nicolae --- v2: Split into a separate patch drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index 873754be5..2c59b5e57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, { struct brcmf_if *ifp; struct brcmf_pub *drvr; - struct brcmf_auth_req_status_le auth_status; + struct brcmf_auth_req_status_le auth_status = {}; int ret = 0; brcmf_dbg(TRACE, "Enter\n"); @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, ifp = netdev_priv(dev); drvr = ifp->drvr; if (params->status == WLAN_STATUS_SUCCESS) { + if (params->pmkid) + memcpy(auth_status.pmkid, params->pmkid, WLAN_PMKID_LEN); auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); } else { bphy_err(drvr, "External authentication failed: status=%d\n", -- 2.55.0