From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48048223DFF for ; Sat, 25 Jul 2026 05:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784956261; cv=none; b=PchX2xDfblJXfD4fBnD9aKJE7Xbdh8fvWBHY46uUTvuH2nzpW6zi0Ezooi3EUYzuGdkdVT0sIbPTiZnIZv4s5eiVqK1n3cEL9u2bzXe7FKqKQ0bw3n6UGvEMAA5N/uXQooRPq2ek5So7aHqa85zVJPRnOZfxm6Ija3iyLh0AXeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784956261; c=relaxed/simple; bh=JeHX5wCK+eWh2x0vBH8Tjole6M5Zvb/8/2HLBL9CW3E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qgGOUeDBlGooto00nidcX25KxQoVORrvECU9KkfPvtKiOVYOgoEQij0p3/fvE1fmE7FEFPyTzuj5fCU0jigDozE7y2W2320pAVFNBZNQG1s96xrQsea8ykvK9w6z5/8M090SiZznelIFvWc23wO7HrmjUWCSPOKUz5/uWNSF5fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kmvguw+u; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kmvguw+u" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so798930a12.0 for ; Fri, 24 Jul 2026 22:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784956258; x=1785561058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cYNr122iGMgO/EI6gg3d5n1DYFQvFWkuT6oNTUvaAfU=; b=kmvguw+uK1aFYCb/duCY9/KxDHWwbZ9XTv2fAsA0lldRnU3defio8wJChlXfsQdqr4 9gSHgUxFmllZ2hLn3KAE7FMz2UkqBo74bFIuxFAsYSfx4ofCcXm6vM9ok33wb95vuNyE m+rNdqJD5d71s9nKmj1mQbkhysJGy5I6VgHTkS2D5BZz9Zn9Ufl3N505XFsA8vUMo4KI uCQPSdjBi0+enqVp1D3Bj/37tnukj5Zkou5Csul/3U9CzI/lOylPYjuHX9Yys9Sc3hoM 0YWrFgzCNnzLRviffJ/uFM1FuodIEDTk50CdLJI2KSHhF7+hiWRiziDXLCMHvNyes7A1 HL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784956258; x=1785561058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cYNr122iGMgO/EI6gg3d5n1DYFQvFWkuT6oNTUvaAfU=; b=cPmeO13V9q3fMmuFMI3H+71VjaDWbetOelrv5qpiieHQv4742RKdyyQUsNjXId79vu KCDRj27kCsiz5fLoS0mgfOvTE0Lfvemqg7ZYu5zOGXmCM45Oc8HqjpghuxfMglE83q34 oIMVe8jThqn6VILlfIzAn1nQSpxlh9/3ow6xTUcW07+CzfRzSdAerUmGSPnARCSZw58S 0hpTWt2roh1Z8co0giMNjHm8zpwDVxHD5iE/9S/S5O5Z6ktGQ4QGqe8Vsx42V4Qcnh7v 9iFWyYoyXGY59no4t3IcWmoOdA4/AJFtTLAoh7/TUhkuGEvW+vXpv2v8NodPwFWL+yF0 WTUg== X-Forwarded-Encrypted: i=1; AHgh+RpqRqt7Cehfzqyuoxh1LxMn+v1KB4g8rWgCgCZNoSICCURwLpv07jSvJlgL3PLyd/ijceS/8HxT1loELo0=@vger.kernel.org X-Gm-Message-State: AOJu0YwuUjSm2hgB8e0wEuivsmCfoej5mr6xrSxYMpCWcxkZIKZVs4Cr EIvliGrrsZW9Uq7ifNZl7hCK9oQa/RED7/GyPxCBocCZNTzn2jH+WWqv X-Gm-Gg: AR+sD13P9vxtSZtEsqIMWI8Iog/OEeEGTBlOBb+nKEOb3lvze20srGaEhkV2v5OWXD1 hyKaUEyt4U+H38EDS8A+6XC89hmHzrStGpACsvMSvWDEY8oXqk//oM7yImp1HBEJEuj+oxbsYBc SH+ne3FltcEtlI3lBHpTaYcqEqGdrquzQpJx+M1SHPxnWfVFlwKUJWRLFQdjMAWL1P3FXK3+c2I 78ugCNc0G0t47WNQfrJEYL3xg00lfgAdv//ft35pnJ4joD7Bb1vHg3/OXiXsAmz7wREXasGwg67 +tvURNG4XwRLYaDTmDV1vAwZLqIwAP8NqAEQZR+qHqCxngtGCkMZiGJ0W2q1c/5LivvC85lSmVx TUOMRSLxM5lMJQxuXhrE7nhxfBoQh/rhXH13K3GrVZPrzZlYPEMqTZ4KETnfFd9jBJzQxyIjTDf 8ABXEWoJgc+tAN3ucl1pzOWoescKIhmpM0CT+dCzXU5Ulf7atpi0mraMVrhH7mbwQ= X-Received: by 2002:a05:6a21:6b8c:b0:3c3:8315:80b6 with SMTP id adf61e73a8af0-3c67267e948mr3145679637.32.1784956258481; Fri, 24 Jul 2026 22:10:58 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([36.255.90.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e127asm9263154eec.2.2026.07.24.22.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 22:10:57 -0700 (PDT) From: Moksh Panicker To: jic23@kernel.org Cc: dlechner@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH] iio: light: apds9306: fix PM reference leak in apds9306_read_data() Date: Sat, 25 Jul 2026 05:10:48 +0000 Message-Id: <20260725051048.5616-1-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit apds9306_read_data() calls pm_runtime_resume_and_get() but several error paths return directly without calling pm_runtime_put_autosuspend(), leaking the runtime PM reference and preventing the device from autosuspending. Add a goto label before pm_runtime_put_autosuspend() and use it on all error paths after a successful pm_runtime_resume_and_get(). Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor") Cc: stable@vger.kernel.org Signed-off-by: Moksh Panicker --- drivers/iio/light/apds9306.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c index 5ca4c87524fe..014db7a1787e 100644 --- a/drivers/iio/light/apds9306.c +++ b/drivers/iio/light/apds9306.c @@ -475,19 +475,21 @@ static int apds9306_read_data(struct apds9306_data *data, int *val, int reg) ret = regmap_field_read(rf->intg_time, &intg_time_idx); if (ret) - return ret; + goto out_pm_put; ret = regmap_field_read(rf->repeat_rate, &repeat_rate_idx); if (ret) - return ret; + goto out_pm_put; ret = regmap_field_read(rf->int_src, &int_src); if (ret) - return ret; + goto out_pm_put; intg_time = iio_gts_find_int_time_by_sel(&data->gts, intg_time_idx); - if (intg_time < 0) - return intg_time; + if (intg_time < 0) { + ret = intg_time; + goto out_pm_put; + } /* Whichever is greater - integration time period or sampling period. */ delay = max(intg_time, apds9306_repeat_rate_period[repeat_rate_idx]); @@ -510,7 +512,7 @@ static int apds9306_read_data(struct apds9306_data *data, int *val, int reg) APDS9306_ALS_INT_STAT_MASK)), APDS9306_ALS_READ_DATA_DELAY_US, delay * 2); if (ret) - return ret; + goto out_pm_put; /* If we reach here before the interrupt handler we push an event */ if ((status & APDS9306_ALS_INT_STAT_MASK)) { @@ -530,14 +532,15 @@ static int apds9306_read_data(struct apds9306_data *data, int *val, int reg) ret = regmap_bulk_read(data->regmap, reg, buff, sizeof(buff)); if (ret) { dev_err_ratelimited(dev, "read data failed\n"); - return ret; + goto out_pm_put; } *val = get_unaligned_le24(&buff); +out_pm_put: pm_runtime_put_autosuspend(data->dev); - return 0; + return ret; } static int apds9306_intg_time_get(struct apds9306_data *data, int *val2) -- 2.34.1