From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EF9F3BB13F for ; Sat, 25 Jul 2026 11:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784979440; cv=none; b=njj1uIwpgrEY1zLNLZ4KG8I1Mu6qV53uxw08Q4WF4trbD9PjJKSsY3oi622AE09NKBqhCP7xXzetUHsEhxRJeE/QFvacf/suPJ+sDNqJr4in/2JRxEmePRwyBx4Wu2WORpRmMQIzuus96XrgTaVJ8eUDAbtX4ZS0yMeqd4nYxvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784979440; c=relaxed/simple; bh=uc+Z6a0PVB/ia4S0bITwPuYxjRsDEDME8Yx0cfaGsRw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dxB+1abFAC8n4qOlsx68Z++1N5MRmdTGKSqyrOa7Z3kBiExG2lRLaSHiLIhgxJPSHxdm4+SkeNATBnmAkq+okPR7O/ryfF+6mpcdhVETMx1hut+28hQYwnOARyPWTex72JsWVX85rJy77Y5qqkIpK1EYZYXU247g22dk3FbzxHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=mz+B2HYD; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="mz+B2HYD" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D63871A9A; Sat, 25 Jul 2026 04:37:12 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7184F3F86F; Sat, 25 Jul 2026 04:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784979436; bh=uc+Z6a0PVB/ia4S0bITwPuYxjRsDEDME8Yx0cfaGsRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mz+B2HYDvTEO9e6Ms3tCfMzs+6RrVH8V+ZUgK/+nB31YsJhCF8ti7cH7q76WyTnq4 8PXBpqIJKjta2oMppJqfTDai8r8aPPmS0PwFaPpmYCo5BP/acE7HS3pmGeeuL3QzQl X4la/vsBwwQx6KAgpq3s5Y3oZONgv+odSmPe9gvE= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v9 08/13] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Date: Sat, 25 Jul 2026 12:36:40 +0100 Message-ID: <20260725113645.57519-9-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260725113645.57519-1-yeoreum.yun@arm.com> References: <20260725113645.57519-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cpu online() check is done in coresight_validate_source_sysfs() already. and smp_call_function_single() will fail when cpu is offline. Therefore, remove redundant check in etm_enable_sysfs(). Signed-off-by: Yeoreum Yun --- .../coresight/coresight-etm3x-core.c | 31 ++++++++----------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index 7a1e183c0b48..14e0724a43a1 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -519,25 +519,20 @@ static int etm_enable_sysfs(struct coresight_device *csdev, struct coresight_pat struct etm_enable_arg arg = { }; int ret; - /* - * Configure the ETM only if the CPU is online. If it isn't online - * hw configuration will take place on the local CPU during bring up. - */ - if (cpu_online(drvdata->cpu)) { - arg.drvdata = drvdata; - arg.path = path; - - raw_spin_lock(&drvdata->spinlock); - arg.config = drvdata->config; - raw_spin_unlock(&drvdata->spinlock); - - ret = smp_call_function_single(drvdata->cpu, - etm_enable_sysfs_smp_call, &arg, 1); - if (!ret) - ret = arg.rc; - } else { + arg.drvdata = drvdata; + arg.path = path; + + raw_spin_lock(&drvdata->spinlock); + arg.config = drvdata->config; + raw_spin_unlock(&drvdata->spinlock); + + ret = smp_call_function_single(drvdata->cpu, + etm_enable_sysfs_smp_call, &arg, 1); + + if (!ret) + ret = arg.rc; + else ret = -ENODEV; - } if (!ret) dev_dbg(&csdev->dev, "ETM tracing enabled\n"); -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}