From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2F62AD16 for ; Sat, 25 Jul 2026 14:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784991310; cv=none; b=l8iNuBdavZESbTHJ6ohq1yJqlbJSlhzOa+uDipvUkk+6xVhXf0wrJgRkaIHj4LtuM35AaqdrJyiTTEzlriI3K2E5Gf9Kegxb92WXOFfL9j86QspgiGnIoQ7WiXhqsDvnq4WF3x4c+3FOuwGKO95hzqaWHUVFvvm+SjNGCUmkVuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784991310; c=relaxed/simple; bh=spjSw6yeJ632vB5+0y38xFTan32fRzqh6cEX15wFX8c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JOA/XndG4LCWmbPPLbgXz5lWdA4+CLtQKFNQXBtfU0ZIQbLs79ekak2OkSXBJUI702HXHs/+OjxFUCAG62Un21eZK+/ReozqYWa3o5bS0kqTcWwsVgPDkmV4xMDqWp6HxtT/DBH6cxWshgJTbZ6kDShpkwt4aj00zKP43undrZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4T/I54h; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4T/I54h" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4956242332dso12067775e9.2 for ; Sat, 25 Jul 2026 07:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784991306; x=1785596106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=f0XuvWRktBewvvd9x2WhTr5h8Kzvho38+5X4qE2gVJE=; b=F4T/I54hy48dXT6AehL8/hxM59qdUkiCYSeWRIjwQT9xrNTWVHxoqxDJAgoZRPZOfo CB555yTqttlNzWMVd9MuqjJq9T+A5TEsUBMMBk1jyObqY4IAOa1Ez+RS3zUBlR0j/6AD EU+mHNJSFuQicmgBmu8tHVBVfpnEz3yttwV70gZTJqhVtsJJOK7EfymNvN9jP/F2Tuf1 4iMH8e/clUMZzss8wJGMC5tWm8gyz6vTfYO3qY/L+VMvLVmEaTNH6fkAOhCS18CFrVVl BtgS9HqVTd+wIr3YzR5WbLjlqFYBuUERORn/lTxXhr53SZc+L433DTwPd9gDzkhL/0OJ n41A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784991306; x=1785596106; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f0XuvWRktBewvvd9x2WhTr5h8Kzvho38+5X4qE2gVJE=; b=P3nbHvgJ8k8wiBzASsc7rG24qd7so2hZxilseCILdki4ozp/X1vLZH8fRZH0KU/yc+ R641uedim1qFsoY/5bQam1XI69NM8NqEdFgQcxuefd2MBUo8Udk9zWEEnbt2khhaxcpQ JB+/88f16/ewFa1dYVnIEDbtUflBMpsmwz5CUWpT7pu/57acXJtHV0Idj24ybu6l3j7B MozqocZfhBXFtU1ncy1MaUlytahEuVvR4bd600AMGwiMrbpGqbQQPkRRfLMfKndiqXNU XJkLSmT+8C/WBAQdn5qkXFmis730sbmLN7X/QvO2P6dq+1XCJgJPRIo3pJj9mowZR7GF FiCQ== X-Forwarded-Encrypted: i=1; AHgh+Roz+t9q+5K9SZYxwcBp2xS8RhXrtRiw5b00MEulQVjMabxCYmMSiLKqZjwE+vrRYTDEv1g2jo0pkdGZ2EY=@vger.kernel.org X-Gm-Message-State: AOJu0YwdanzM6jevXHILBrca56Wd1BNsHSfj7MllhsTxqY+OfWXT6a5l GEYJFm1zOoWd9EPrxQ4iPFnN5ktxFt8U1HCYFucN4muY8xF1ai9o/jsl X-Gm-Gg: AR+sD13lIE9bcGGGozfBc4Rw0abXg1+llzQg4oNDZa110H1X7CbqqmYlSK/3GPnBoFL 6N6v52+TR+izug5dOWZJmX20eKOoMPs4rdKhKR+YrZvD/JyKFax9M2cxCZ3gldCfmoQs06hNO3F PkMZkMn41+ccpmzvku9zTJt6eOJO5aEstX/6ajWt0/jgOPiA9KklE9X8weF7Q0bRu9yBs64D03H DFB3JyAnFoa8xZ16tfg0JNmExDNscJ8PAZCGODvahWmGd13hPazC7T5pDJ6KbHtcKU7PKkx26hj GmRGxs22wBf/OUA390rX+dPoO1yXGdaiANDCTPjuxElgyKlU3nFE08TQb2sdBk7z0uAPtXsZ7RI 1xmEcxSqnE4HCrhI3liAMPYYrLleUEXPpk1kjh7H7V6OS9Zq76MsfZ9Xmgq3M5717Dv7rzD6/KT 4Cb0IE0I0X X-Received: by 2002:a05:600c:c87:b0:495:4a34:16d9 with SMTP id 5b1f17b1804b1-496b570148amr30507565e9.31.1784991305433; Sat, 25 Jul 2026 07:55:05 -0700 (PDT) Received: from archlinux ([2001:861:79d1:d140:7f91:4899:f5d3:d30f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4f5f9f8sm70300965e9.9.2026.07.25.07.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 07:55:05 -0700 (PDT) From: Ronan Marchal To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, Ronan Marchal Subject: [PATCH] net: niu: fix missing register write in niu_txc_set_imask Date: Sat, 25 Jul 2026 16:54:24 +0200 Message-ID: <20260725145424.435297-1-ronanmarchal29@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While reviewing W=1 build warnings in this driver, I noticed niu_txc_set_imask() reads TXC_INT_MASK, computes the new mask value, but never writes it back to the register, making the function a no-op regardless of the imask parameter passed in. Add the missing nw64(TXC_INT_MASK, val) call so the function actually programs the mask as its name and signature imply. I don't have access to this hardware (Sun Neptune NIU), so this was found through code review, not tested on real hardware. Signed-off-by: Ronan Marchal --- drivers/net/ethernet/sun/niu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 88df15e6dd74..37079a6d6ee9 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -4650,6 +4650,7 @@ static void niu_txc_set_imask(struct niu *np, u64 imask) val = nr64(TXC_INT_MASK); val &= ~TXC_INT_MASK_VAL(np->port); val |= (imask << TXC_INT_MASK_VAL_SHIFT(np->port)); + nw64(TXC_INT_MASK, val); niu_unlock_parent(np, flags); } -- 2.55.0