From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844673033FE for ; Sat, 25 Jul 2026 15:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784992272; cv=none; b=C1EycedOttlMz+ffS5Jk58a1Y2ry5LpGkUCbBqnAAexf0H0YUVPcYP26tH1PIamRsk/5QM78+xQ/Y4/7ELnjz6Y+B0iNYN9XIDZaFtx0IZZ7aRvox0zOrO13xzn2XP01dmeM2UFg9k5qT0p9AV7sWSCiw7Ix6y0gxFDekLQd5pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784992272; c=relaxed/simple; bh=PPpYtX1bCmCOUQqG3jMTyzpSC2XUlQ7hOUx+Jcf23Lk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NlLGw4scGiVdozu4PUkun//sR0FImKQOqOMIuf7d5XG+cbiB5u1z5lECshPiiKun85LPxvXQgBPgDTO8tzH0KrThjDMA5no9Vzj1/E2u6ZNQ4/2IYPMdADFzX12wOfTuYHay9m4TqlhZMtWOt20qBZhyCTORK5pOXmZ4cJvgZAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FL1A7bdF; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FL1A7bdF" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38deea72eebso1547912a91.1 for ; Sat, 25 Jul 2026 08:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784992271; x=1785597071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qd/dKHIuRS/CtItZlX4/17nIeCWsz+xndXH+6leeAfQ=; b=FL1A7bdFymnK166iyxUeYPTmy+4LwNUt6AiRAki4pVefKvVTEDjk3ukfQ/Qe8pecn8 PcMgUP9J8HVnqxUi1GsSFF5xoNAfK3IcjrPiFXeDFrWhi5P6wrN7eeU+4OOkyETt6lnJ yzzQcRIF9jerK7yf+OJaEeJWy5TM4DHY2quddBIGr6SYSf7IQptvFNCazU6CKMqdrhg1 O4dWGUES1/JpJijR2C0knEbPKO0XqIj4Sp/CW9mahpz0kSJ9lWRwncYxLdFiY7KsB9mM RRfOaorhp8P4oE0i7IGZ2paJ94O9jvsH5T4CjwoPyEjsrpXcmdydoZA8P0lvBapgKaJp 4mGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784992271; x=1785597071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qd/dKHIuRS/CtItZlX4/17nIeCWsz+xndXH+6leeAfQ=; b=npOFFxjqlO/kc20boBq4Y7wekfR2PoodueRRFhnxvfLND99oGeG+1c6MfV3JFsmLvg pLIi5rxd9FbaiZT0dwXKGtzTRVXM78nQtu75s10HwfEjWxtJeG7KFBg4vw6TLmjR4wku qzHzvmG5EYKJ780AqbARsKVx0SxqatmEJQAH6+cu0DtIELr6SvZfL9EBlZI9qhQ2KMDC vSRFpZ6SyuE1srgDHXQjZ3uYasHAkRqaFbXt+JHhVkM7RsuNmzBRs8Zrt3+qdn6YB95M 7RFQKT/xTUbHn/n8iPch6jvGZxwsh+jpxgefVETCvlFzdfjRxS9XzxPF+C5hFcN/Yvfo gIsA== X-Gm-Message-State: AOJu0Ywuiqt5XEEPY/9NGbFpNf2x2b61CYhJL69J0tsNnHfSzn1yDpTS QssU3tr7mzmEkG0KiqnyR5lT8cnAgF9mR8ej3CZF3WtLs1a7lnO5Hvus X-Gm-Gg: AR+sD13vE0UD6aSO/yRxDtG3mMoHlcVGSE5E32Ql5KnmFoVkMKjcEamWR0aZkoTVSER JnWgyde4mqPtzqMzs3GMasmNiGsQL4iL0PeSlxKLOJPrQxkRVomilfW4qo73YNiINXkjdZh1/l3 8E56/wmPVZVZ/s2sV7d/Zx7jVf/Sa4wrX5vkBDzOAuUnPDcaPWoMj4D5oHx2M5lMwlbEbDmPZF9 83U9J2nYEwGeOpSayqbeVME3wcbkv3eWURNm/e3UZ5yfCquOZEDB/6HSlSEB6QHllk1KS46OyMw pzLrTP5kb/cj9Q542EyVu9YXZ0o1q/TVxMlaTFGc7Tg8BjlR1DQnApb/+LNhzYUHdPeLT8SsTnM bgYhXxTtbHg6sBEcBNrWmiOairtX9A+uhK1z+Nnr/S2jScCTSIvfGlnAGTsaQqGeoepw7babR X-Received: by 2002:a17:90b:55c3:b0:38c:e9e9:e7ce with SMTP id 98e67ed59e1d1-38f293cfbbcmr2529181a91.3.1784992270583; Sat, 25 Jul 2026 08:11:10 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f031d1d6csm2907665a91.0.2026.07.25.08.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 08:11:10 -0700 (PDT) From: Sang-Heon Jeon To: kuba@kernel.org, Ivan Vecera , Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v2 1/4] dpll: zl3073x: remove conditional return with no effect Date: Sun, 26 Jul 2026 00:08:49 +0900 Message-ID: <20260725150852.859188-2-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260725150852.859188-1-ekffu200098@gmail.com> References: <20260725150852.859188-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/dpll/zl3073x/dpll.c | 6 +----- drivers/dpll/zl3073x/out.c | 8 ++------ 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/dpll/zl3073x/dpll.c b/drivers/dpll/zl3073x/dpll.c index a2a641b8358f..0488ae6ac486 100644 --- a/drivers/dpll/zl3073x/dpll.c +++ b/drivers/dpll/zl3073x/dpll.c @@ -2272,11 +2272,7 @@ zl3073x_dpll_init_fine_phase_adjust(struct zl3073x_dev *zldev) if (rc) return rc; - rc = zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01); - if (rc) - return rc; - - return rc; + return zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01); } /** diff --git a/drivers/dpll/zl3073x/out.c b/drivers/dpll/zl3073x/out.c index eb5628aebcee..410d15b96d0b 100644 --- a/drivers/dpll/zl3073x/out.c +++ b/drivers/dpll/zl3073x/out.c @@ -85,12 +85,8 @@ int zl3073x_out_state_fetch(struct zl3073x_dev *zldev, u8 index) if (rc) return rc; - rc = zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP, - &out->phase_comp); - if (rc) - return rc; - - return rc; + return zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP, + &out->phase_comp); } /** -- 2.43.0