From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46557318EFF for ; Sat, 25 Jul 2026 15:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784992282; cv=none; b=rep6TwNc1C3uXSsx/fhZb04ORI6u2F811BVUgxu4T9mf6zdFzL651MJMxt38yKMp1dETbCq4dfVmLJFtwJFeKj8O+ivz6zquWSzGmz2z1nlTr6ShuXYd9RlyoHfswG62QYQ9+5OsUAxqMBqyHi72Xij7WrJR+7CDQJ65CF6bj0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784992282; c=relaxed/simple; bh=B6lymHMejMusKsix96D6ZvtfN+w//IbnFJ1SbsO3Lew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MOLv6R2kcMLDDQnkqvtpDtbKSwcXcLepQu6fFHV7D4CpLqXXbuz9yaADt8Q5VlTVXbu4oXQRJKL4Qw0CytBSLykPQYqdtFX2zKOBykeeHGWmCHyQWtB9pPt5BW05eIFtBkpVPGP00NJlFnjqZylGxIqrG+jreMVD0JmNWimjqkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=faYD63Jv; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="faYD63Jv" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38f0f132f56so965635a91.0 for ; Sat, 25 Jul 2026 08:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784992280; x=1785597080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YXxSD90foPdzE3hbVwfCejb05zTmh4PTg573m1DJENI=; b=faYD63JvPaxAhJdYanP2hkw3lsybKW2gT3wiwPgjTcLpq4ETOL0Py0AfoRQWUfdEe5 HJ5KU08fG7n4iq1nqjsA3f32IAJKlcl4FfeoPd5bC9YY00RZcH3wDuZG+Q4vs93NcQpQ 3/9Fv32xgVYblQGWUu9ALFU9q7sAI6xM7zTaMu4jjXqem2fJyqU8eRmXujfLWy3kIEh1 otYFXFecdG7ne6RDgaxVNikoGZf3HFdas1xW94Hb6WHPXwW+1s5Lqz0nfVadFCez7wQv pJFyRkIX/0c7LcLjm74VYrYKl3J4KjsACGzRa48T6LHcQ1Fry9c96OwF61COwdm8JShD 9SaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784992280; x=1785597080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YXxSD90foPdzE3hbVwfCejb05zTmh4PTg573m1DJENI=; b=fUuDzC6Ge1II9rzBtTAHjEtV3BWkbndcMyRYD23tjvTmC9c2Uz70TP/3jx8/+mP8wl xCmmyNwC7ORh3/PaUvnB3enIS6G7a5P5HJGHFmujVNHp6BNvxsrSRyhlXIWK+kqI1MDG plGNSnkxeR8GhvMpi2xxJC/zKlHs8Q7Bvi3gUkgjvf0nKFbjSvLLF95AwCcIa9w5GIYD FREcE0e41C8RS8Xwkp006O5WjB7IUd2No5FJtqK6N8XcQWoigXHCLtBXdgT1Feo7Z1VL AZIQA+zp5DnojSs2TsxxTX4Qvz59BdcvrWRND7P4m3kr1UxcK22a6oEtYhaeEHkRlbaP aMDA== X-Gm-Message-State: AOJu0YwZ4MhzSfcgTPd3VdvwSTfMuEvviRuIhn5NwlFHEBsl+UgmCFW9 +3NoyfZnPvhX7mZHptalz6o+uLwdDrfWqfFjkW9Fl/Nom8VrjeduzBgD X-Gm-Gg: AR+sD12pUXjAiZG0NDsDyOUJOsCiq9Fqw87S8bewbHl+CfNVWipuWXFKb/JtglkjNpa J+5CO8gSLWLFc882/6K059OZsXPe8lRCqHD9ufkLm6lLpvXDaN8FrOppkV/8LqieCotDm1ZG1qb W+coTofzemUpJCL0hBiloKLcZWqjQotLB/VNJYbWu4BqrWTXkFVeztEFDCWuNHdv5+ebZzDRAQp PYXE+74IU2Vv1XslUfOOvWeaWX3f41TaXUd2WRwXyNf3QXT5z9XrFiG/d4fbmgVdlBhfq9nV6/t oq8ZCWMGZ4OP61+EJj5dBwk4ltFMYKyQ178KUXZLWZQaRD3/qR4H3YrDwOeCfzXmGqG9NULy412 x0GgYsMkvHpIM4KcOs6HxDxUvGSBhbwFBizVUumRLFxF2FRDjjnStJ7R5a4qHThm89B1EUa+n X-Received: by 2002:a17:90a:c2d0:b0:38e:9ca8:e99 with SMTP id 98e67ed59e1d1-38f2a953af5mr1796822a91.5.1784992280596; Sat, 25 Jul 2026 08:11:20 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f031d1d6csm2907665a91.0.2026.07.25.08.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 08:11:20 -0700 (PDT) From: Sang-Heon Jeon To: kuba@kernel.org, Arun Ramadoss , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Oleksij Rempel , Kory Maincent Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , UNGLinuxDriver@microchip.com Subject: [PATCH net-next v2 3/4] net: remove conditional return with no effect Date: Sun, 26 Jul 2026 00:08:51 +0900 Message-ID: <20260725150852.859188-4-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260725150852.859188-1-ekffu200098@gmail.com> References: <20260725150852.859188-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon Reviewed-by: Andrew Lunn --- drivers/net/phy/microchip_t1.c | 6 +----- drivers/net/pse-pd/tps23881.c | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index 62b36a318100..3292b2235c8f 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -1028,11 +1028,7 @@ static int lan87xx_read_status(struct phy_device *phydev) if (rc < 0) return rc; - rc = genphy_read_status_fixed(phydev); - if (rc < 0) - return rc; - - return rc; + return genphy_read_status_fixed(phydev); } static int lan87xx_config_aneg(struct phy_device *phydev) diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c index 49d6389da067..8a3bbd623412 100644 --- a/drivers/net/pse-pd/tps23881.c +++ b/drivers/net/pse-pd/tps23881.c @@ -1520,11 +1520,7 @@ static int tps23881_i2c_probe(struct i2c_client *client) "failed to register PSE controller\n"); } - ret = tps23881_setup_irq(priv, client->irq); - if (ret) - return ret; - - return ret; + return tps23881_setup_irq(priv, client->irq); } static const struct i2c_device_id tps23881_id[] = { -- 2.43.0