From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB5833EFFD2 for ; Sat, 25 Jul 2026 16:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784995451; cv=none; b=py1+XqFgZKLXROs9cqwoidaixd5UH5A9xTchoPPe3TVZB53/Hdm7J7GFF+r1wqRh8o69qehkVPF5Mxtvqr0TKmx4ZNDrTYuG5w1GTup463nhFf5Fw+tfloDCvA3cUY0vUTtuhj9F6I/8QkoOO2zMs3MIiKECkmUQ0ZBsU2QhEpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784995451; c=relaxed/simple; bh=jKNau2Jp3w8kXsZXkN2dT2k9Gfxstnz10AQQGpZh7t0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xgf8DyeOZIxMiiH2KIv4yynxt4fWWRYK3oUB+oEJHn6FMLPEMa5blVSeuYgYKVKKPFritdiMnNjWjTm9WOJ82LzUugerMkeFWTienztZC+pzJphjJtjMjAd1G23a6ZUA/zqg80jpo46oAOJylXRO6BEVB1oxNnLoVWOqaA37qnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dIP5nY9s; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dIP5nY9s" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8486672f03cso1352450b3a.0 for ; Sat, 25 Jul 2026 09:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784995447; x=1785600247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b+iaDxI8w/adsDf0nAv56q2sZiIDOJGK49M5xG0vhiM=; b=dIP5nY9s0ZqD7zMp6n+lp03bQF6oUKNcdDt/WGGQcgYMp/0LJz1n4SxQOETkAhrxWX JY8pI5KY4YhbpxQCBKO93cxAPEB6L21bbGDbjhX6SuFKr5O3fYtNWAE/g3PQP2xT5jSr +ulglEJKOaODVBpnxQZVcc3doIeYD4luWnkvm/3b3UDtXM/RVN7WA5pMUdEYv6q6VX4u gM8pHWLb6WwewovlXgXgr/vA91BFu/69d7vIBwWxHKs/R5hXaiMhIEetKc9qpQOda9m2 0R2MOmak/+O+pPtvJ02cR3o0gEIEy0V6MPksnqLUnobkT1B/Zkdl8jUyUmVJZkj/NSLO jKFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784995447; x=1785600247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=b+iaDxI8w/adsDf0nAv56q2sZiIDOJGK49M5xG0vhiM=; b=VrWqvd9Bb7SkJ8hz4pEI30L/WmGXZZGtythq87SC/zuJ6tfVeYLjd5QbCbDzgXGAdJ DZvDoDcD8lxOQzHdZbZWIiO0lz/m7ctWknUiygZ8PfyV4nxXnpMcyC14y3hO4zD2rtiU A2sbcUgNQlgj8I1us/yfXBYiB7+du0BznRBM58si71wEzJOOOLnvv5PkwevZsHR0XeCr 2A9UyGirxWYxWOtKWRUl3FzLnvzPxmePiVV6+2W8DGsNYR9MU9vqVNa+n3h0kxj0fPII VE6DRPsgAh71vjHEpwxivFdt9gZdTVFP3E3ZfeuYWtsae3IhOi4156LrF76xqG5vqnOV xiIQ== X-Gm-Message-State: AOJu0YwpUYcu2wxILKo483ZtWyYoahYfOZDE1cAT304a37PXRp1RhGd/ m6X9NfTSE7PnPJsKVo1dO4PT4ntYRmoJiErscVpv9pxXvwacIJELy9Sy X-Gm-Gg: AR+sD13dfuan6Pa+Lgkg6lSt50bUdFepWMglM1uAcFztqYAQzMkuyL3+tmVxeTt+J9D RTT2vhoabX2T3IG6qVTrdfNpHhX+Z9YPFITg2dBCkJ3ETsTcoGx9IFyvozkFWrKn8M/avQAdrU5 sjdUhliWRNNKdXo5WG+32C80TfrTMbjHnxMo9IFBI7RiTL6AEZA6hKlZIC7k+I0UuOzUdjnbmV2 yBl7lW/EZIqdbuVjuB8SG17hfsrs3VRx/lXxB3LG3sdLSQ/Fb/FlUqlg0HY1tW7NJ3z4nysjAXP LF87c8C2ILZsgFvj7w9HdRFVhsIzZN3aRWT6tDlFEycON+EgrFCYxAwUcIZK4+2DM5M26th0UzB 072rWDZXeQy6byKpqbGtFoI6la8wcnERXLUDL+dB0oTKpTN+oKxNGI+SmdBBYr7cuZusvl8hZCF lNwVxmYqM= X-Received: by 2002:a05:6a00:27a2:b0:845:cf73:c1d8 with SMTP id d2e1a72fcca58-84e5940a882mr2082288b3a.14.1784995446789; Sat, 25 Jul 2026 09:04:06 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e5341d8f0sm1171554b3a.44.2026.07.25.09.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 09:04:05 -0700 (PDT) From: Sang-Heon Jeon To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v2 3/4] ASoC: samsung: smdk_spdif: remove conditional return with no effect Date: Sun, 26 Jul 2026 01:03:42 +0900 Message-ID: <20260725160344.916838-4-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260725160344.916838-1-ekffu200098@gmail.com> References: <20260725160344.916838-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- sound/soc/samsung/smdk_spdif.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/smdk_spdif.c b/sound/soc/samsung/smdk_spdif.c index 2474eb619882..515e4dfc1432 100644 --- a/sound/soc/samsung/smdk_spdif.c +++ b/sound/soc/samsung/smdk_spdif.c @@ -130,12 +130,8 @@ static int smdk_hw_params(struct snd_pcm_substream *substream, return ret; /* Set S/PDIF uses internal source clock */ - ret = snd_soc_dai_set_sysclk(cpu_dai, SND_SOC_SPDIF_INT_MCLK, - rclk_rate, SND_SOC_CLOCK_IN); - if (ret < 0) - return ret; - - return ret; + return snd_soc_dai_set_sysclk(cpu_dai, SND_SOC_SPDIF_INT_MCLK, + rclk_rate, SND_SOC_CLOCK_IN); } static const struct snd_soc_ops smdk_spdif_ops = { -- 2.43.0