From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9AD282F03 for ; Sun, 26 Jul 2026 04:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785038595; cv=none; b=JWVpMQMR70yehlboSb4wEQeJP+s5klw2RSWMScs5255Z0xb4CF3lcSPPqyctObpSh6zJ4mNXPu6oc9oJXV7s5UDQ80rbkvI/Ni/RY04ZQdOfXSKMUWFSRKrFSWIeVegVWOJIRx4zg2gh9sJwzu9JcW6AIXPk05OS36rGX6Tc/Es= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785038595; c=relaxed/simple; bh=Rcfs5xE1BKazurPU71g/CAnl+Vr3skpjOPoqgsEa66k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IBYjxt7QWN2j2JpuzMC045hzgtkImQ1fIiwtWHNy4PqVXsB++YS814zcGkgZwkwREmnuFYviAYeStovGXs9zZWwOSF8gImd2zYdiZKTepSm9xGRymUHvu9RQMxZtAOIssWr7L1OK5zHA70WrQbp2DjHYqGCqJp3x7M0QlUPsPMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YxtbrJsf; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YxtbrJsf" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c999f162c9aso1190651a12.3 for ; Sat, 25 Jul 2026 21:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785038593; x=1785643393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=TftBonCo65/KM8j4iUvNEUfLj3iQNRTb5idjXeff4V0=; b=YxtbrJsfVwQRrZt4y8aq8jvkb/IpCxFUcg7HCd0YDPf4kIRKlBuHSAxuw/7bnvYtKR YhSEfx0reu1JuaDbqQfQ34RHY1fyZeJK3Y+cv3yIgSVHgZOUz7F7CArOb2E9aUIwQOic 1Zu1tnKO+/eRMhqbflBVw6yU0BKltKiYZQGi1KODRiU3nRaY+AgDo6xWAJJ9F+Rppw9s y4F1qIYFnR6ZoX1xqtdKYlTK9OPuKj+LFhjiC6iPZiD0ZBgBitZySEjLjmttbQY77zi6 BLjpMxDLI/2LphWeVby0N9xgseTvW4GcSrKYcWb2a3rDtx08Rv3hQUIQYFWkW+EUhuj9 1uaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785038593; x=1785643393; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TftBonCo65/KM8j4iUvNEUfLj3iQNRTb5idjXeff4V0=; b=iF7WYDy8pmQdcRAjpxslQBBfOGJgPfXn93Ur707TAj5JxSC8XD03wTe6NcOdA45PEr jaFRKkh/UZJx84CznRgTh8PbFj4gSabN9GaIeyXjirKumK/s4sz3heDIbp/X+ZZZgt73 f2IDD4c2nZP9FJrdNzItSPWCqiSSkPxd0fDF5Gt6Rbn+lHYRKRer+bxgXByZpMn1Hk1A gQhEBb9phGL2lwZvsY+p/Jnkoj0slYp8/shkSujG90Zaorv4/Tn1t3GchqULCApMLm1V MCFDgo/0edeGfUr7I9/wP73xN1d0tF63gU+rCf5nyJkqNziCeOhtB30pzmkazfODgtVj WXqw== X-Gm-Message-State: AOJu0YxNaD1k2r7kW1/OmG5UKngDHyBY5MAFrIDw3auoFQqdQVBZyHUQ RESmrat1t8mSIFEOra4F2rbsWUJTGFz7QZfUt6tCSKWByFF6zVHIPAhq X-Gm-Gg: AR+sD108a/0lZs7yyPMMLIkAhRHHmjBNOSEsA+IWj6aewgM7YSqrRXfPZieHdiq/t0u c6g2De4iQoy62hdYrQHFcr91RdcHFUHhfCOPJgXFEEgIMHj+BOMaDyswxiLZouryNs9U6/ZXRH2 n0irb7JFxHASQFdr0JXfe8xHZte0XKfKO6umylCY+9Ag7+AaL6wNlf87YfSUIGr00SBVE7sPfNV IokYv9MXiEM2qgW5e4ss6yicO5LatHji3jC44ywgqObhF2INmaWJmyU1kKtbfRT0JBOIqQ0zS7x 6Q3DVuV+9m570xvpXMB/U5q9OaBedgvZ7G4nB5TGIb9o7iKjARq43kTPZqDKySmgHzB9j/lQH3h XyF+jY/6CmUfFdF6b+AX+dVGfQagqSWZQ+Cc9ZyGhFU9UpnSBhdO/eHYA92IyY7ce0IgCZmpcBS Fc X-Received: by 2002:a05:6a20:e291:b0:3b3:1c7b:ffb with SMTP id adf61e73a8af0-3c67dd89f02mr3753060637.34.1785038592948; Sat, 25 Jul 2026 21:03:12 -0700 (PDT) Received: from gmail.com ([58.84.62.138]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc44cb92sm27244599eec.13.2026.07.25.21.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 21:03:12 -0700 (PDT) From: Sumeet Pawnikar To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] powercap: intel_rapl: Fix kernel panic during PMU unbind Date: Sun, 26 Jul 2026 09:33:03 +0530 Message-ID: <20260726040303.280299-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rapl_package_add_pmu() fails internally at perf_pmu_register(), and rapl_pmu_update() leaves the global rapl_pmu.pmu structure zero-initialized via memset and returns an error. But any previously probed packages retain has_pmu = true. When the driver is subsequently unbound or removed, rapl_package_remove_pmu_locked() sees has_pmu == true and unconditionally calls perf_pmu_unregister(&rapl_pmu.pmu) on the zeroed-out structure. This attempts a list_del_rcu() on a NULL list head, immediately causing a kernel panic. Fix this by checking if the PMU is actually registered before attempting to unregister it. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/intel_rapl_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c index 1006d183d508..22100f1ca222 100644 --- a/drivers/powercap/intel_rapl_common.c +++ b/drivers/powercap/intel_rapl_common.c @@ -1652,7 +1652,8 @@ void rapl_package_remove_pmu_locked(struct rapl_package *rp) return; } - perf_pmu_unregister(&rapl_pmu.pmu); + if (rapl_pmu.registered) + perf_pmu_unregister(&rapl_pmu.pmu); memset(&rapl_pmu, 0, sizeof(struct rapl_pmu)); } EXPORT_SYMBOL_NS_GPL(rapl_package_remove_pmu_locked, "INTEL_RAPL"); -- 2.43.0