From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0AA3368D4F for ; Sun, 26 Jul 2026 06:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785048176; cv=none; b=fRkM1xmr40vbdAER308kGsVqKkxX6phWDFiD2iaTlsd+8ri2MzGLrdgCpCBTeWUQls0S1C8crx8Qmt4boT6awqhbvxXiMt2XXqg2cJMXq6qL4n0M4ogkpwslBq2g7QLSmtNGl+KVpCI6uvPcFLwDB7gI2OYwac5k1ZeMIgVQNTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785048176; c=relaxed/simple; bh=N9+QbAUPaPXmQUpTCidHoZEU0HdMC1BH/xbdtpe2YFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KCkagyhgUhDt5ix5tFHeCbbqayqj6aLMJf9V/qZTx7PhsWQuGdhRbFLL7ZPj07iPWFYEyZVVzBXReNZ24wBlP17JAT614qfvZXfDcpYRHTAiNUDwAKcgFx+10jlxvDHCAXLAIocqxcofSrTqTpSP0Ce2XdeyEU9zV0CgrTvIj/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJ0n/mpv; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJ0n/mpv" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-381b831d535so2081252a91.0 for ; Sat, 25 Jul 2026 23:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785048174; x=1785652974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o2F8eP/jjp9Ke0LSHUP1E0ukxaqDAr6L35/n8rcUGLw=; b=fJ0n/mpvXy+ESmhFkrBAZliIgYds92/h6LwxD1CmKQsJjJs3zudJUKDFR23ER5FzpR PTUB5aSs92hiNI+NKPNNZORwLQ887cvxhDwK/J41MNcbzeAb0dB/ra+RI1CvU8W31Qhi UTodBYRUKIldr2TS1/f5FLNGq7uOwi3OvqhMiTgMmTacF4KxWkp73a2NnnXPe/1ADymv 6QqMG3nhPjboGfMF83IzNVkbg/lfXFPXFfanOk3koBxP3ur+MHSB1mu693i4WhiXGiBk GOwUGsD2ShqnUIcvVpT2AKh7zbr5HOPS8B58Fj/2uLjtC8b+IuILrl2+zuo4srZkj/OZ 98nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785048174; x=1785652974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=o2F8eP/jjp9Ke0LSHUP1E0ukxaqDAr6L35/n8rcUGLw=; b=PqVhBx7NEbwh0G1rdrBXUlzHFexjLa3coTLwnwJ7qMGpbniJYiw7EvE9OgkAAWaMlS 8YT8fU1X+LQpdVI+zzgPXXyobbjdqaDNelyfUDEWSPfTdOfk0goF7tNZT8Hcx8IbZaAJ jafOFQV0pre03+gtyf5g1CchHuZNNw48nLbOvFActT0Y+J9PBgH419NMqoFg+J6JuNVZ NQ55SEtY3lXdYjt4uRAdebGK9NzY63dGymA2Zv8uORNSKUI2Nl84n+e9nV5/11UjhuBt otVcr2xGk9OYtZLE7BdK/XMFMKuJ+E34/2MKbzgOFlVFLQHOkQCCpBTfTSFucm95OHej s2HQ== X-Forwarded-Encrypted: i=1; AHgh+RoR/kq9sAxWpPqk/f+vX4OjwqDPG8kF5jgyN0YdwByj2MjYtfhnRcjMl2/vRMWBK35+fHlUaRwwnDV0Cxw=@vger.kernel.org X-Gm-Message-State: AOJu0YycLntH81kL9zAA2KHAeVuACWI5AK81B9Fi8I3Fh9mBj1adaMkC Mc7t/5i2xy1T55JlinasgG4klHRbfg2+r25VOdsLrNu4ekJIIcWbGGHw X-Gm-Gg: AR+sD11/5mQWP9LyOOG5JVuGUkc41QQEbyFLNSCIChYtTUzeioc6qpdoNW5zats2r/h gaUOFZRgoc0apRKZ0A+breIMaA2D1r2nuGfaXpyhaGlVCb7YBknMdNMzZXstM/4udtaVzTQQfa2 f8qmlQpqyhS36KyxQp8/UBBgkNl4BgJPfYYiIFF0tln3YjAgvNz2Z0HLJZE6l+0wxEexDVgx+r6 u0q1XVukJIzV6CNCG74XP1BiIleMJSk0UPxxZa7Q0GBmNFVDSpOsUSKuQIZXLRgb5pvGAigYrwa Q6nT2RIyBkzoINmTnrpXlmJBP1EfPRK6UysfrVGHDsgbhW7BoSYD/pZTHMXstI88E0mROGNBYvP IFYYu5sV4PE4zaEdTiYXcju45XTjb3cIjaVZpF66Vy5BxHM79NHjTqjZSF6niv2cXTBoRGq75pu y2 X-Received: by 2002:a17:90b:6ce:b0:387:e0db:3fb2 with SMTP id 98e67ed59e1d1-38f298bdf9amr4170246a91.43.1785048173954; Sat, 25 Jul 2026 23:42:53 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:50c0:1b11:5404:3b67]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e1285sm18919605eec.5.2026.07.25.23.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 23:42:53 -0700 (PDT) From: mdshahid03@gmail.com To: Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] fs: hfsplus: remove redundant NULL check before kfree() Date: Sun, 26 Jul 2026 12:12:28 +0530 Message-ID: <20260726064228.248199-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260726063939.247892-1-mdshahid03@gmail.com> References: <20260726063939.247892-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kfree() safely handles NULL pointers, so the explicit NULL check before calling kfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- fs/hfsplus/unicode_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/hfsplus/unicode_test.c b/fs/hfsplus/unicode_test.c index 83737c9bafa0..7f6b2a3c69d9 100644 --- a/fs/hfsplus/unicode_test.c +++ b/fs/hfsplus/unicode_test.c @@ -39,8 +39,7 @@ static struct test_mock_string_env *setup_mock_str_env(u32 buf_size) static void free_mock_str_env(struct test_mock_string_env *env) { - if (env->buf) - kfree(env->buf); + kfree(env->buf); kfree(env); } -- 2.43.0