From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE867321F2D for ; Sun, 26 Jul 2026 07:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785049304; cv=none; b=R34AuuUZqMeHwLAkR1zKp0jmmKeqZMN1rn3rkTKySTMpX3RsxxWNwmdfPzYb1bWKxJLTxPALNQwpRKxLzdqCn3uT0YHyqq0X6J75lv0EqRFNVzd1GZBhT16zhFx84MGQptAo4f/Usr8C1vi6IhCbqTbmLp/qzkDuefeHCqSX/MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785049304; c=relaxed/simple; bh=XVQ4K6t/aKmeJaXRT2NIg9IPgvotPyRWcYA+50Uk3j0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pKgYLwO1MN//6AqNQznkc3qG2Ell8MjHM1PtKmHf5ZQKx3BLBEtQspbacop69yWZvz+06C16MSR47LG2cwxeXjB5aoovfjGDEJO2XBM/I+U5AvSloK2sHHUcAtJI5SISVMZmLFk1Cp8b62/rHoKRJ/x2S5/EovvWulJAzj0VMsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jU9IhGsr; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jU9IhGsr" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ce7d2adef4so21708245ad.3 for ; Sun, 26 Jul 2026 00:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785049302; x=1785654102; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=T5WelClJpxas4ruVu3+pWlz7YW9bPmso8om3006Hc5Y=; b=jU9IhGsrYMnpNrtSXREZBBGc19vXoK6L2LLgBikCV6LaHdZj3NA2bZIsOwY+FeQKdp zZBOeqg7MdXDkF592wLepRIhDRUOc88GtwW/IP4kLizXP7ZpQWXuylDf3bO7uoAW+Fa/ JcUcZ3OUmklVAbICRKvE6ddBQ7qHb3cQY4XO9DfOzdegDj3N+Xd5v6ufytzVCsjoNdSs xs7/UvYFoSdxd2s1VKxkQ55AamaGqrchmpaSM5O4cwwm5uDMwnfFCbjNpkq6/rRkxvGO axGihbW8Vjuec7uYDuYEN1jbSbvsxdD9eSBhaKI97eR1lxC6ZtSOu44OUXaoKQZRSHWA UzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785049302; x=1785654102; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T5WelClJpxas4ruVu3+pWlz7YW9bPmso8om3006Hc5Y=; b=H8QL3jshozKvX4iCNi1hLHeXN8U9comW24xWitHn3xZQ5So2pYNArz+5k4yhdoqkmG CmEKakur11WNRvrLqDhIgQzGH+My9IVhIXm1oCOQ5p3S52K6+8lhp/b9lgZw2f6+Qap+ C1KhptRlU+A9/7WgjLk+nmQOI/c7+uG2snWKj+7m1FhITco1wR50UcxxOPClmrsv3ZcF Z/jM5TShW10SChO7RP3qZ2MeWnD4M8mkePVoC1gh/1JvvUhOWnK1kcfsrGWVwZI8wSMb OIfOKnFpyZFtCshRaBO8KTwBXxCJLmDvpsSj/LNSo3VY64zZRU0PezhiplqzO1piqIWu B2Gw== X-Forwarded-Encrypted: i=1; AHgh+Rq91JbAv6mfMA1L39MiMY5WBvecTEfVZcv13vmmcnj6C9IrJcBCzD/uF0fLDKeaURIBufEigfvzt9gL4QI=@vger.kernel.org X-Gm-Message-State: AOJu0YwIn0obAOg5BKAjLI9DYSCbC2vP2095Od33Fh2Lv2422/+Rl+w8 KbLaB39QRW2D0Xx7sX9tX/LYXobec080g1Ic6IPhyaGkWrzqUotvQE6V X-Gm-Gg: AR+sD10f7h2nTh620gGLWo1r0q2K1D3cjjIeqP3srUl804vOhCHimpf5JkJ+X2C+R6f +c+Tu8+reeUhMAWT0Z1v7oO//jI8b1gv60bGW1GWbY/tmtOHbE/Eq9z2Q+IMDG1Lsf3v3QKxjDr ls4hrvu0RHzpxKUv/hJk99s6FUsehjSKbULmw3KoPH/q0LGbRgMKlSqe3NYo/OJ2m2htcBYeUbm /5rp1cESrzkT+F90OTX3QxCoEyX9GpDjdVUtN4AC/Wc8gOYu7uH5fA+LLp/zORA+hD522HK6Fra /I4Yz2BigXj9X93pS/ocZDNav23mgYv9L3jZnfhO33PEAb+MzE4/WAz15OiCodQmhmstjSGT85Q UGuhNMofZOOw36imX/m4TNIIGOzU16bOrgmlxIsg560biiq3PWhL1n2n+fcYzq101aHzJ3zIMYc gR9jyGl9s= X-Received: by 2002:a17:903:f8c:b0:2c9:97a9:2097 with SMTP id d9443c01a7336-2cfde89441dmr42250255ad.43.1785049302096; Sun, 26 Jul 2026 00:01:42 -0700 (PDT) Received: from omen-arch ([147.46.174.207]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e2b44sm17215565ad.27.2026.07.26.00.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 00:01:40 -0700 (PDT) From: Junseo Lim To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau Cc: Stanislav Fomichev , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Sechang Lim , Junseo Lim Subject: [PATCH bpf] bpf: Reject negative optlen in cgroup getsockopt hook Date: Sun, 26 Jul 2026 16:01:22 +0900 Message-ID: <20260726070122.2407344-1-zirajs7@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A cgroup getsockopt BPF program can shrink ctx->optlen after the kernel getsockopt handler has run. The kernel-buffer variant, used by TCP_ZEROCOPY_RECEIVE, only rejects values larger than the original length. If BPF writes a negative optlen, that value is accepted and propagated back to the TCP getsockopt code. It can then be passed to copy_to_sockptr() as a size_t and trigger the hardened usercopy bytes > INT_MAX warning. Reject negative ctx.optlen in __cgroup_bpf_run_filter_getsockopt_kern(), matching the lower-bound validation already present in the sockptr-based getsockopt hook. Fixes: 9cacf81f8161 ("bpf: Remove extra lock_sock for TCP_ZEROCOPY_RECEIVE") Signed-off-by: Junseo Lim --- Reproducer and warning: https://gist.github.com/ZirAjs/a177ec6d8f2c8ed7d93edca6313a9255 Tested by building and booting the patched kernel. The reproducer returns -EFAULT and no longer triggers the hardened usercopy warning. kernel/bpf/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c index 4355ccb78a9c..c04a244fe2e6 100644 --- a/kernel/bpf/cgroup.c +++ b/kernel/bpf/cgroup.c @@ -2235,7 +2235,7 @@ int __cgroup_bpf_run_filter_getsockopt_kern(struct sock *sk, int level, if (ret < 0) return ret; - if (ctx.optlen > *optlen) + if (ctx.optlen > *optlen || ctx.optlen < 0) return -EFAULT; /* BPF programs can shrink the buffer, export the modifications. -- 2.55.0