From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0376826B74A for ; Sun, 26 Jul 2026 10:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785060272; cv=none; b=FqlMsVgnwS2lr5fbcp0ZJKtFeTj0XOv6StZjz29SP0tR3H3q1VsB7XJ0TXc+3QITkGZLZj79ACFTYoXdRomAhvzCTTjrw5MLCE7iG2CLGusqmWScCupJe2ARxbXtPqaayxYQH/R0U4fBEF/0jpkMJMDlsizbjFiWYXrg5ZZZ9p0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785060272; c=relaxed/simple; bh=7B35YZE6oc15BiSnsGvUCtFqLPIM1pzfUZ2v9rqMQOU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nvH3j62r82AbAtJIA7s9odAAk2L6dXuiA6yYLh5ltfP5PWrwxlL7Urnd2to8lLwBoBr3GK+nqPp2oprkwNYESGKj+ZyJOsXMZ1bkNKqpRnV8pxwQkfhF/5DZjogNe7Ba+oakZzQWtComcITCLb9MobFip8dHR7ggtivgMjozOmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NB+jg4EE; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NB+jg4EE" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-ca12086c06eso1422323a12.0 for ; Sun, 26 Jul 2026 03:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785060270; x=1785665070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8ylvgAcOl9oKpTpFug9fyDy646d3xIKNYqdv16u3reo=; b=NB+jg4EEdXBCHJJJ/dcANjctDrBbxeVfDrkh/TLcwzQ3qVmvxtocCh4xSB2YCX9oxs L5TU0TD8J6qT100SLPUDwEfubUUqhZskmVC/yUiErQxPsQMoO/haq7YSGDDO7v3vay7V wOiRAUhw6Madf8+eHQZuaSBiM+YNbkcnAFKfQ/Aet3IDv+i68e2iRoDI8oMsiN6g1Moq dUXKKKXO8iXbKPwZYVNNVqEJnm1AAajnQ0Xkl/kg4lKS/5ic6p88Ym7nz/EgCAj3N3LE 1wXlNkaREFOup/rRZLEo7D98zQZEycwrfP72TxmV6CjuLXzkGnHvOmJmIjcv8ba8+tRk FbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785060270; x=1785665070; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8ylvgAcOl9oKpTpFug9fyDy646d3xIKNYqdv16u3reo=; b=WqF9fDUtSll4fo4UOpgThBtNHAqAHXQkDnujB6ExsAzTR3v6kw+WDegkklSUQKjYE7 BW2PhV/uU9HBJ9yv7RB5Y1xppMpNynr9gMfhHrvCeaR3JX7Hv6nlrjGf2fQ7P0ArWjiY t1EaehQKbSaC80Hvjz3FGRrCEX6Z7MDRRwEDVekIeArxFAlw4xXs9vA5xhkmvoNwQJ7p N1bH0dSRvCNb+Tq8NVlBcp727LgZhKVE0QKoXJiw+qhERueGLbC9Ig9SgRZ2qz7k2gJS sNLjpGkFOaCzdkWxgWIayNlgrVOHKlQ0STKET0HxUy1muLIGrz8h3NVvJyJ3VVrJ8PZZ lGKg== X-Forwarded-Encrypted: i=1; AHgh+RoTIgv5KocNKEbVy3s85NCApj0hPgcGvFVcDW0eCexMzdS5NlAf4Zyz0+IYtxPEezYVIX0mhod9yVVLphg=@vger.kernel.org X-Gm-Message-State: AOJu0YwnI+UIhf1jx4i0vfQLhBdYOfG00t8YDGfLrpLHTWjj12SenOFJ SzOpI0Kr5+lbb1UcrogSRiW6YBzb7LQU8ih/1S8bjil/ABKSUtcSa1k9 X-Gm-Gg: AR+sD10rC+2nXOcmNrHTBfs3o0U216AMQzU3bAKYyE3cWHP1GniETBNmpq6s9RL5wy9 l3+5Uc10JL81pJSaNvpuzsSTYQhQIIVrqHFDw4a2qoexc4DYJSFPcP2dFTx91LwF128RDs7cjik Z5DC/Qvo4RJrFWY68Pege/LN/JHEclQZpptBa59inwNTiKS9Tt3ZLSti7W5PhttreTOOVNBqewW 7jE6xFgMPryLR6VW7m+kKPfpMHDR0pJyt+mkHkAxlwd0+VgyH/o8w6xhDphX58PDvcVKT8oYzIL J9CjVqNYSaEPei//FnTFjhMwhaRoYol6WW1cRUjmBiDxevfj+pzGbewIO9FHNdtTRO+CGdKO9mS oiN0eyremj1g+mhS8wegQHUqN39mfHkfkr8NfVXnd16qYFOANKGQaw92kKExCtqOps0zHGaVsu+ wCM5sJ29z5sG9Vgzr0zl8= X-Received: by 2002:a05:6a20:d12f:b0:3c3:83e6:c705 with SMTP id adf61e73a8af0-3c67df08725mr4678734637.35.1785060269292; Sun, 26 Jul 2026 03:04:29 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc57ae17sm16923506eec.22.2026.07.26.03.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 03:04:28 -0700 (PDT) From: Cong Nguyen To: Thierry Reding Cc: Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Cong Nguyen Subject: [PATCH] staging: media: tegra-video: fix syncpoint leak in tegra20 channel init Date: Sun, 26 Jul 2026 17:04:08 +0700 Message-Id: <20260726100408.3262831-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra20_channel_host1x_syncpt_init() requests two host1x syncpoints. It stored the first one (mw ack) into chan->mw_ack_sp[0] and only then requested the second one (frame start). If the second request failed the function returned without releasing the first syncpoint, leaking it: the caller tegra_channel_init() bails out with a bare "return ret" on a syncpt init failure and does not run its free_syncpts error path (that path only covers failures after syncpoint init has fully succeeded), and the channel is subsequently torn down via the kfree()-only path, so nothing ever releases the orphaned syncpoint. Release the already-acquired syncpoint on the error path, and only publish the syncpoints into the channel once both have been successfully requested, so chan->mw_ack_sp[0] never holds a released handle. This matches the handling in tegra210_channel_host1x_syncpt_init(). Fixes: 0e2c4117c351 ("staging: media: tegra-video: add CSI support for Tegra20 and Tegra30") Signed-off-by: Cong Nguyen --- drivers/staging/media/tegra-video/tegra20.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c index e513e6ccb776..f8acb6834a0b 100644 --- a/drivers/staging/media/tegra-video/tegra20.c +++ b/drivers/staging/media/tegra-video/tegra20.c @@ -429,12 +429,13 @@ static int tegra20_channel_host1x_syncpt_init(struct tegra_vi_channel *chan) if (!out_sp) return dev_err_probe(vi->dev, -EBUSY, "failed to request mw ack syncpoint\n"); - chan->mw_ack_sp[0] = out_sp; - fs_sp = host1x_syncpt_request(&vi->client, HOST1X_SYNCPT_CLIENT_MANAGED); - if (!fs_sp) + if (!fs_sp) { + host1x_syncpt_put(out_sp); return dev_err_probe(vi->dev, -EBUSY, "failed to request frame start syncpoint\n"); + } + chan->mw_ack_sp[0] = out_sp; chan->frame_start_sp[0] = fs_sp; return 0; -- 2.25.1